Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp240156iol; Thu, 9 Jun 2022 03:00:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz5w/DyaXgoTbgC3iHcBrmiK/BsGs/j0/W83BQb8XQoPMAaDbnrxQ2X3C/LF+c+9gFVmj57 X-Received: by 2002:a05:6402:228d:b0:42d:e319:7297 with SMTP id cw13-20020a056402228d00b0042de3197297mr44364271edb.79.1654768845494; Thu, 09 Jun 2022 03:00:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654768845; cv=none; d=google.com; s=arc-20160816; b=gz497v+I1JkD+2ofA1T5LpS+gS+lN/ZmBEoQneYkBstROvdmLoYVMESG8ywNZIyo0b 1zlbAnI1TmgjXPburqaa63hI+xD6gwumZ/v3n95hdW/OABBg1kO7G9tCpz6w38btVKGo XW24Zl+ZsydS+cHYTNDt5+lQySS6ScrkMuB1WIXeTxuMtB90C/ZjK03F4c6f0LMU/Mbe yfBtFL9u5Zrz5ZWxqirntboe9mNnbFUBbAncjQ7TevLO6Ftfr/ylEaMlWxbZvhy3usuc cL6cjvxrHKBwjYn7/UcdMiabftTpJuUUXR6E84YBumoCkzGVtmIMMxF9YiqlVsxTQjYA 6d5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=ZhzOVUao5w9DMEnzkkUCheIUF8AFcs8EVh0y97t4Z14=; b=xM+WtW2tiTsqhDh0PD5Y+50VG2GoiAiUE1b3wWTWh/9tyPBmcbrxhVxZvXQbm95bKj OcqA6gDEW9731DjkpqJCCEBnwvZcwIWQSF7MxH3SVx1FdfHrVo3dDFLY6wMYlDgWofTx RGF0GH5gzpZsQztv012cQtt2gIdI8l6ocjBOX7fkCmJt5Rx1y5hjXFY7shwpK0+/nTB9 Dft9EG9gXwDTWjEEgW2KbKmNcr3oRRJWg13dzBsycHah/gfAynBnwn7Z2df9xnrZSpGy R8LcSqcFMPy+v6lCWVgaasScA9wtfV7ZbOy+zsDamEWpFB+lwayz7/U9yRMweqmjhPIz GcgA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f15-20020a056402354f00b0042b42c7f655si3824169edd.33.2022.06.09.03.00.18; Thu, 09 Jun 2022 03:00:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238718AbiFIJyV (ORCPT + 99 others); Thu, 9 Jun 2022 05:54:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234671AbiFIJyT (ORCPT ); Thu, 9 Jun 2022 05:54:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3865119425B for ; Thu, 9 Jun 2022 02:54:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C952C61CE3 for ; Thu, 9 Jun 2022 09:54:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E2D4C3411B; Thu, 9 Jun 2022 09:54:14 +0000 (UTC) Date: Thu, 9 Jun 2022 10:54:11 +0100 From: Catalin Marinas To: Patrick Wang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yee.lee@mediatek.com Subject: Re: [PATCH v2 1/4] mm: kmemleak: add OBJECT_PHYS flag for objects allocated with physical address Message-ID: References: <20220603035415.1243913-1-patrick.wang.shcn@gmail.com> <20220603035415.1243913-2-patrick.wang.shcn@gmail.com> <8fc24ba3-1467-b845-a70e-7ed77750e6cd@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8fc24ba3-1467-b845-a70e-7ed77750e6cd@gmail.com> X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 07, 2022 at 10:32:26PM +0800, Patrick Wang wrote: > The leak check could be taken on physical objects. Conversion > of block address from virtual to physical before lookup should > make this work (this is useless currently). I think we'd better > know about this. Yes, we could add this, but since all the phys objects are currently 'gray', it won't make any difference, other than an extra lookup in the phys tree. -- Catalin