Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 9 Jun 2022 11:13:48 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Tao Jin <tao-j@outlook.com>
cc:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hid: multitouch: new device class fix Lenovo X12
 trackpad sticky
In-Reply-To: <CO6PR03MB62414DD2A91566B0D4C1C1DDE1D39@CO6PR03MB6241.namprd03.prod.outlook.com>
Message-ID: <nycvar.YFH.7.76.2206091113370.14340@cbobk.fhfr.pm>
References: <CO6PR03MB62414DD2A91566B0D4C1C1DDE1D39@CO6PR03MB6241.namprd03.prod.outlook.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 19 May 2022, Tao Jin wrote:

> The trackpad of the given device sends continuous report of pointers
> status as per wxn8 spec. However, the spec did not clarify when the
> fingers are lifted so fast that between the interval of two report
> frames fingers on pad reduced from >=2 to 0. The second last report
> contains >=2 fingers with tip state 1 and the last report contains only
> 1 finger with tip state 0. Although this can happen unfrequently, a
>   quick fix will be improve the consistency to 100%. A quick fix is to
> disable MT_QUIRK_ALWAYS_VALID and enable MT_QUIRK_NOT_SEEN_MEANS_UP.
> 
> Test for hid-tools is added in [1]
> 
> In addition to this, I2C device 04CA:00B1 may also need similar class
> but with MT_QUIRK_FORCE_MULTI_INPUT disabled (but it does not harm to
>  enable it on non-multi-input device either). The respective owner has
> been notified and a patch may coming soon after test.
> 
> [1]: https://gitlab.freedesktop.org/libevdev/hid-tools/-/merge_requests/130
> 
> Signed-off-by: Tao Jin <tao-j@outlook.com>

Applied, thank you.

-- 
Jiri Kosina
SUSE Labs