Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp252787iol; Thu, 9 Jun 2022 03:15:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwh5Kk2E8SiX7pMUmLsMG8O5lskZ5cwEUS0qjkH5kTXUJ2lu12XJlokwv8bPaXBilARGChY X-Received: by 2002:a05:6a00:cd5:b0:51c:19f1:4657 with SMTP id b21-20020a056a000cd500b0051c19f14657mr20719435pfv.67.1654769734830; Thu, 09 Jun 2022 03:15:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654769734; cv=none; d=google.com; s=arc-20160816; b=PfbQbdulekCldT2THkPpSAd6TsYOqRxFk5ojRWMQU2Zhymki8LK5Q4H/9tUpeC1iit KMBrA6iFjPQEZMuOOr+4iK9nN9BrOlaDFRI22gcwe44mgyy6nYXGX4PZecHig06npoRM YDk18ZsUEYaDNuEsUVFYRLqMXjg2ulKp58by+lNqs5o6ufzPn3YTLlliMcaoAEcbsGWu aua2K6UD33LpXUz8TVZsSJjAzR3+5XwNChRsiKwteSE3PEfQy7gCPiEoy/rl65KDIsdh mgMghmxADh3hP3T4EADcgx2eAk3zF/3bpzFoHgT3TNWb8hLS76WZ+luW7Snb+tCL+03m Qjog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:dkim-signature:from; bh=eRfpj8LYR/qudJbazlWGs6E/wa39JqTF/v+5dFNEkBk=; b=lb+T8ajgrxxhUh7YZgaQUDqHrPic3YHDLCNOn0SYvWC9H6JFbgQKm0spuCcPMDz8AX fWw/eDl08t55VLXdoxTCBc4iyiFajvfzSjB2dQF3yIM3FJbtBczVX8sYr7EPKMLcZ5RD M1QzJ8HRUgqiFoN5uoNOKw49K0i/09UiHaTT8jICoyGkiIJGvUdvRTfJPGwr2KJRPbwP k3HCDlK0fbIgwaPFLCB/4LuwLQWK9FGJ16wfP6ZMqvVQtMLyJXdFCympTJDjgKZbvL29 +8qInDiubbtdxb+5OdDScGZeDNIVIdAwXtweQSPKTKBO878+xsRrOkta89knR13Bn/hg 12Vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@puri.sm header.s=comms header.b="V9/MIKvN"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=puri.sm Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x6-20020a17090abc8600b001e056b31018si27252193pjr.166.2022.06.09.03.15.21; Thu, 09 Jun 2022 03:15:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@puri.sm header.s=comms header.b="V9/MIKvN"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=puri.sm Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234028AbiFIJp0 (ORCPT + 99 others); Thu, 9 Jun 2022 05:45:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230246AbiFIJpZ (ORCPT ); Thu, 9 Jun 2022 05:45:25 -0400 Received: from comms.puri.sm (comms.puri.sm [159.203.221.185]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4EFB50B14 for ; Thu, 9 Jun 2022 02:45:23 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by comms.puri.sm (Postfix) with ESMTP id 703BFDFDD0; Thu, 9 Jun 2022 02:45:23 -0700 (PDT) Received: from comms.puri.sm ([127.0.0.1]) by localhost (comms.puri.sm [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KnrSODr8z27T; Thu, 9 Jun 2022 02:45:22 -0700 (PDT) From: Martin Kepplinger DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=puri.sm; s=comms; t=1654767922; bh=13VRg4Lwk4+BEnm3SUM2cb0pYq53kKrwUDqrt4YlzQc=; h=From:To:Cc:Subject:Date:From; b=V9/MIKvNERmqtpSd5O4VRXuaCcwmEMjmDBxKaLvBGLG7nbWDxpahnGafIQcn2XF9K pxSwLPVxwZmqgUCV2eNHTmhDCGtGrzV4kSgEeU52EUlshc0JtoMnO8fim+PW5fcgDQ GzCjnEmNawpU6VUUx/pGgTz2MFMJJrRzzmHQWJGhnBULWeJmItGsyQrEuAsjUSG+Z5 WwKFxdasmbbMYweNJHiaL6lDIaFxevPb3RDGE4unaN4jNg400e6G7vXnN3hSRfd01E 9J9HW2LQuCCCehgah9orN5uxPsKa/GSTKGs/3caNnG8CWVLerxOm0eyhblGePQpX2l X2RF9MxOKC7cg== To: shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com Cc: kernel@pengutronix.de, kernel@puri.sm, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Martin Kepplinger Subject: [PATCH] soc: imx: gpcv2: print errno for regulator errors Date: Thu, 9 Jun 2022 11:44:53 +0200 Message-Id: <20220609094453.2120099-1-martin.kepplinger@puri.sm> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Make debugging of power management issues easier by printing the reason why a regulator fails to be enabled or disabled. Signed-off-by: Martin Kepplinger --- drivers/soc/imx/gpcv2.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c index 3cb123016b3e..311507a815c5 100644 --- a/drivers/soc/imx/gpcv2.c +++ b/drivers/soc/imx/gpcv2.c @@ -233,7 +233,8 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd) if (!IS_ERR(domain->regulator)) { ret = regulator_enable(domain->regulator); if (ret) { - dev_err(domain->dev, "failed to enable regulator\n"); + dev_err(domain->dev, "failed to enable regulator: %d\n", + ret); goto out_put_pm; } } @@ -372,7 +373,8 @@ static int imx_pgc_power_down(struct generic_pm_domain *genpd) if (!IS_ERR(domain->regulator)) { ret = regulator_disable(domain->regulator); if (ret) { - dev_err(domain->dev, "failed to disable regulator\n"); + dev_err(domain->dev, + "failed to disable regulator: %d\n", ret); return ret; } } -- 2.30.2