Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp292866iol; Thu, 9 Jun 2022 04:07:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwpB/u1Qi7KH7PHqS/j6kg9A5CZ7DOAvHCqNNG0hOqaoTmvZR+QIgK1LMj3lxvfi1zfnUM4 X-Received: by 2002:a17:90a:e7c7:b0:1e6:8093:3fc2 with SMTP id kb7-20020a17090ae7c700b001e680933fc2mr2955092pjb.7.1654772823280; Thu, 09 Jun 2022 04:07:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654772823; cv=none; d=google.com; s=arc-20160816; b=SPAyHX1RJsM0c2SwI22AomcSpkSveIcxPPw6Vm7irDez7vhH5u8+LITRC0n2br0E1A ae3BL2cjfv07dou2O/W2hHeXcKFuKfcWrw4d7TgaWXitGkru3egGvy9FbT884mmb3xg9 00hMFwHuwkJYMo1VRIc9HzhGDJCCgHQYTi4f74s/UZT7U57sz2SOcLGROLx0hYxLSOGp s3fXQbaelIYVHvWD2GjsyGTzIZNramU2iRb4UgBlOyxnl8OKhliESxb8dmyPRxIo3zTQ es22QO+AXUZPJg7wlrvrYjvgy4pSlISZBmyCLj8EF04aTr0h35mQL320Nz/yqnYfwtVR SzaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Oxc4iqp6RR0L+UCOiB+4EoO5Jv55eJP5b0WUEy+Sbh0=; b=d9/gqtPReJ3Wxd1Qd0ErOCuY6arvwoNf0Ca8NwapP1iaYkExHqT3s+HHd1kQXadWCz 5HpVZf0ZteBlgE9XylL/5Bjdd4jkQ14qSUp32W9b/lQZ+knobamoZqHLCuKjUndORTQB OpyoBU76HPwzucGjYziGWnRpmDQE6vNJ+4XbM/YTNUgMbyRjiNIz9hmNfuOudZU1fpuI 3jj2DHDGZEUV2IKjSaS/ayV6COsHnE8xyYDXaI3QVncT+el0O4gH3mh9CsPjLcE5/C+U QKvBoov4EBDt8ufOX5dDBopMOq2jhP6EALO7GDOvav+E8VL50GwiKDBDORlLkLNA7a4u wXkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pluRCe16; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q144-20020a632a96000000b003fcea910b03si27863190pgq.523.2022.06.09.04.06.51; Thu, 09 Jun 2022 04:07:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=pluRCe16; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242966AbiFIKz1 (ORCPT + 99 others); Thu, 9 Jun 2022 06:55:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236028AbiFIKz0 (ORCPT ); Thu, 9 Jun 2022 06:55:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66EA12622; Thu, 9 Jun 2022 03:55:23 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E5EE261D69; Thu, 9 Jun 2022 10:55:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AE994C3411F; Thu, 9 Jun 2022 10:55:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654772122; bh=fFvXj5SRoTp6Hhi5ZcyQ5FroE/o0H8XmIrhJK4iz2Ho=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pluRCe16VSHhiKwQqtHn/heSRjUJgv4phLQst9mzI3o5ksVNMtTXeElw1YZXgOaSO oeQCNorZCg/CIJrivCpOc9Pfck+Ki3RfzaaJAehf9VVjkL7VoXs6QDDdkh11PNzUGa +CQTjrwRAKgKG5AM7ci1iIWCanvmC32Kkm1NU6JxMW0C6H9aYkntKHoDR6uTLIau3R bDLlTxHkGftnC9JWhUKyNBVaSFX6/imoNzF7C3/N/Vt0y6kSFuCRCWbd+M+63IptAV HGxekt2l3LlK4UQXNRWbfNH7O9HUhUxEm9GEfgnvl8kCD/5lxDMyeFAPu7hTjI4vGj DvqecRiM/KU/g== Date: Thu, 9 Jun 2022 11:55:17 +0100 From: Mark Brown To: Yang Li Cc: conor.dooley@microchip.com, lewis.hanly@microchip.com, linux-riscv@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Abaci Robot Subject: Re: [PATCH -next 1/2] spi: Remove unnecessary print function dev_err() Message-ID: References: <20220609055533.95866-1-yang.lee@linux.alibaba.com> <20220609055533.95866-2-yang.lee@linux.alibaba.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="0bXiklFNAPTpnN3I" Content-Disposition: inline In-Reply-To: <20220609055533.95866-2-yang.lee@linux.alibaba.com> X-Cookie: Space is limited. X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --0bXiklFNAPTpnN3I Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 09, 2022 at 01:55:33PM +0800, Yang Li wrote: > The function platform_get_irq() never returns 0, and the print function > dev_err() is redundant because platform_get_irq() already prints an error. Are you sure it never returns 0? Note that 0 is a valid IRQ number on some architectures. --0bXiklFNAPTpnN3I Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKh0ZQACgkQJNaLcl1U h9DOywf8CpYl578fRtjDaeqN5f0T9EqOZQtgYzfzILNoXGC066ucH53ffM+mJrOE eEy3bPlm/63pb7NUyNfc3wqEK8lIXR00D7VmCw7xBcfvDKsoskfXiN8ipLE3cDS4 0wMY94olcidpbXmrZgghFqSy+J5+cy9Fqis1tw6qygnFnXyUpoFULOJFdujP7Pi8 VU3cunpin9zsBXJkGbJfgcSQBW9TwZnve7+Zi/aJ0wk+Xm49lO0easreafN2IRa4 0dw1Xfm4x2kIADe9tNbms7TqjbNfG55pnHWseFT2y6yOiz6MKGDDlJMoGehUV56J SFjy59OdlizDGuu1EtBePOPim4CKPQ== =bqmh -----END PGP SIGNATURE----- --0bXiklFNAPTpnN3I--