Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp367086iol; Thu, 9 Jun 2022 05:35:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygN8QtAyBaXWGtxm/Zm4obJpfglKKdlQEV2UamxjhDvgcGTik1vcWr4Yqd+1QqJREF5Ep6 X-Received: by 2002:a05:6402:3293:b0:42e:18a:d6eb with SMTP id f19-20020a056402329300b0042e018ad6ebmr44774434eda.293.1654778154394; Thu, 09 Jun 2022 05:35:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654778154; cv=none; d=google.com; s=arc-20160816; b=TFCQboB2Ija3F/ptGCQlStvsX74Ovm37E1PuJiG59DaWAW7dy6Ju7cUUuFiWYPIwQB cH8PBCYRs37vYwHw+26k/VYbPRFmGAEQOv5prP7rNbG/c4Dycgf9TK9iGG+gP2857AE4 OyDicnEt04MGa+s6WpTnnS2TVjsqBv8Y257Ip1yz0wT+WGg8yGPNK7D8aiOwrkBh/898 xQub/fUyN/DUB60/G2ISWUvnTXcIFo8Na5OkftOFPTU7KDQlYkgaIJkRYhPHb9BZVLnu sWLo+6hnAI4gNhmQGnMkKkrV1yMHP+qBRTKmBjoF73/4/B+KKLc4eA4ZjIenQUuua9x/ lo5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=WbC87y9wl4WsCtucOrEr0iSsJGhDjZVjnD/A+Ep8H6k=; b=rQ/5KOXmz1toQwhQdkcyQ4ipIGEhkEuytRFNxUn1LsGUpIm0hzmXg24IEN5DQT/2lq uutX1UNdIQi8WFjNT/pvW6E916wbJ6OZDOGN+xYEMqQf/CR/tMl+dAFhSCuQq7SgZTcd A2hDTKUjBrC0apUhgV522gKGzE35Fl6zfi6T8k8rCzjverZ1j7y3Ql+fOv3K6DfcT0lH /Czk0eZinttEq1N8BW3YBXZuE2Qh9pPlsibWc+fWimk9/aOzUCJxBiaa6Y7j+3jWQ5Kn r0pvGsObvzbtSeG0MldMMOl4kKmgqvwZgyp6qKfPxEoo2nxK1j1Ow9iOhMJAb+KW/sQY S81A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=pbSU+bRT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h13-20020a50ed8d000000b0042b4f2fcbeesi3764188edr.68.2022.06.09.05.35.17; Thu, 09 Jun 2022 05:35:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=desiato.20200630 header.b=pbSU+bRT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242094AbiFIMaC (ORCPT + 99 others); Thu, 9 Jun 2022 08:30:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235653AbiFIMaA (ORCPT ); Thu, 9 Jun 2022 08:30:00 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50003140F8 for ; Thu, 9 Jun 2022 05:29:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WbC87y9wl4WsCtucOrEr0iSsJGhDjZVjnD/A+Ep8H6k=; b=pbSU+bRTaDv4jE0cm2tg8t7JZi sLoAv+oJoZ4LhVl/Kd/G9ctq4kG/KfDXL9qouiIHmvpzaOpmc748lbYq9lNsyrM6Fyq4l+gVeUJac Mummxv/4tUgpL+nLTZH/qDSpxZA3OBOppJbNKNnLOP+Nr89d2bpOnMMJ2SdWvp++YmA24HQfR/i4Y 3aKqWrSaa1cT5eo0CgLGnVk01bhypMBvxw42stT6tPMaQIL5+Y/K0UXCutbdcGo2q/ytI2bVfSRBc twKVi+d9iYJ7iduK42/AXH3MtSDboyLKEraBMUxKbi3fg9QNiBExNtWZehb19GtOoe1hbH+463Azg TBZfKWyg==; Received: from dhcp-077-249-017-003.chello.nl ([77.249.17.3] helo=worktop.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzHI9-006N4r-Am; Thu, 09 Jun 2022 12:29:38 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id 5316B9816EC; Thu, 9 Jun 2022 14:29:35 +0200 (CEST) Date: Thu, 9 Jun 2022 14:29:35 +0200 From: Peter Zijlstra To: Huichun Feng Cc: Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , "open list:SCHEDULER" , jserv@ccns.ncku.edu.tw, Chin-En Lin Subject: Re: [PATCH] sched/fair: avoid redundant hrtimer check Message-ID: References: <20220606122612.2580930-1-foxhoundsk.tw@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220606122612.2580930-1-foxhoundsk.tw@gmail.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 06, 2022 at 08:26:12PM +0800, Huichun Feng wrote: > The check is required iff HRTICK is enabled and DOUBLE_TICK is disabled, > avoid the redundant check by adding corresponding sched_feat() . How about: 'don't do that then'?