Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp392391iol; Thu, 9 Jun 2022 06:04:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/Ye5UpuguWIPSM/syrVRS58zcxg5QsgHMm1V2FdREs1lKPnz6C/uk9xAzBaCWCipAY1Pa X-Received: by 2002:a17:903:2c1:b0:158:f9d0:839c with SMTP id s1-20020a17090302c100b00158f9d0839cmr38842459plk.118.1654779881973; Thu, 09 Jun 2022 06:04:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654779881; cv=none; d=google.com; s=arc-20160816; b=TqjikhpJXU66Glq3MgFw/pvvmPPpclt7b/6vK8mHPHNzmFQ9Whod1xxQ7UqbEkeK9C BN+A7Kx4iqnQD2jZ2GzoTcY6oZiO+DpsPEMi7IHCCSXnUHTMIhkilR5p2VzM08L7Kcv9 IzgSWFb4IZJrl579g4N6mAvIPR+xsi1ayGYRbwqYpE57Vp3/SzPHgl4qYsZUHlT1NPL2 asAT7vwx50sqr6hMaamsuSbvAvefdNIydnVyWgeKKTeAXV2IaQ+8e/4kfV2GBzW2/+wS 7XWKgthen0r7mC3Teja2nrLsRz+vvtzrJexLCW3vZeNHEuzeG0JUz4htdONOjIklLz6q z6HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=W2pDJyYht7VOnF3QgO48EKFIgXumd2pCO0LJ2y8eqgA=; b=ev0YhiFNYbB0PRqMYKhhzizYRNW4qiJ0Wu6Q7BX6QWlych92ukBXaicp5Q8zNyLxAr M9Bv3BIasF87Hze2bsufui+T4nxBb3DnOXX5yYCdPDO8uqFA/v8HMKKd3IROajFX5wZ1 rRt/oc1Ow1R72auUm269Ll2JJnlsbuD44DuBhXy+xbSBW/+krrSGJ82JrtvOg8ivOPZJ VrvgI3dysfaRFYd7f7hxaVKBkBXhKc7V7LSn4U+VFadPbZoS9fJboVV42bn302+qwa9k AuD8DzJjDF9BlvuT68ewa+bssfMlYjSRgglTcmypdZbHT90sBdpCxJmKXpuA7x1xGhhF t4lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@crudebyte.com header.s=kylie header.b=XwsV5kVP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=crudebyte.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u76-20020a62794f000000b0051bd440b069si24885951pfc.14.2022.06.09.06.04.14; Thu, 09 Jun 2022 06:04:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@crudebyte.com header.s=kylie header.b=XwsV5kVP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=crudebyte.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343526AbiFIMoh (ORCPT + 99 others); Thu, 9 Jun 2022 08:44:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343552AbiFIMoQ (ORCPT ); Thu, 9 Jun 2022 08:44:16 -0400 Received: from kylie.crudebyte.com (kylie.crudebyte.com [5.189.157.229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE7AA4925F for ; Thu, 9 Jun 2022 05:44:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=crudebyte.com; s=kylie; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Content-ID:Content-Description; bh=W2pDJyYht7VOnF3QgO48EKFIgXumd2pCO0LJ2y8eqgA=; b=XwsV5kVPYRzw8zsik48ZXpsC7h uDwZnQpMlIxxjUheod91CQGw864EqMlZVWZq09/Mxscjowvp+hI1riI0px/ZDhl565V/TO6vVRtNx jlypaJo+m0C2Nml78GnSuwbLj7ltbP0bvS/hxwQ73dKzvwIr8BvEz0yItvmcrWm0XPRcVBAQW3voy gImgVviuU2LwSIf9TG9G/FYsLKvnNH7EUgkcysLtrvXZCvWmvAUKG/2i5/noqXURujrSPYw4VhyzW eo5Fk7lhbJC9C1FdTQd/H4tzIXC4wCqoWGswEfe2Lealfbs1yskeMg1AgTv5eo6KFC+SnQddzg28M hYXyPM6+R/vKmDbOZ/BpHYlNvHyugj9zk7IlobMnEe+k/swj+hxMCRFJMIWkqX9ip8zIAwPGYlY1y Xmqu+p1OZ2NfgpAB3edEsE4aYQl2AUBx7LXvHdZSlI9aKjAxClCxVUEtVkAF4H1yM66o4YqDpM3g5 uaF2nvE2kQyUMvg7ufHN3roO+Fhi0vgn5jjHyE8M63qgOBrD8dXKyq4AxZF42nAMkdHY3T4DouP0I 6AW/Yy897JCJUD0tfe9O2uJ+QTBGaAFy3Tdze9z5k3vDvOXALMP2pG12q6wc2sGKt7l5kmZ3mRIEw SgGmlyMq6DK6kIgvpoOYhgMUw534Qo6BBwPQK5wqU=; From: Christian Schoenebeck To: Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Tyler Hicks Cc: Jianyong Wu , v9fs-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/5] 9p: Fix refcounting during full path walks for fid lookups Date: Thu, 09 Jun 2022 14:44:04 +0200 Message-ID: <7291261.iO0hoOTYzs@silver> In-Reply-To: <20220607034110.GA7401@sequoia> References: <20220527000003.355812-1-tyhicks@linux.microsoft.com> <1849605.JvGbLJQp6r@silver> <20220607034110.GA7401@sequoia> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Dienstag, 7. Juni 2022 05:41:10 CEST Tyler Hicks wrote: > On 2022-06-01 16:28:49, Christian Schoenebeck wrote: > > On Dienstag, 31. Mai 2022 16:28:29 CEST Tyler Hicks wrote: > > > On 2022-05-30 19:14:43, Christian Schoenebeck wrote: > > > > On Freitag, 27. Mai 2022 01:59:59 CEST Tyler Hicks wrote: > > > > > Decrement the refcount of the parent dentry's fid after walking > > > > > each path component during a full path walk for a lookup. Failure to > > > > > do > > > > > so can lead to fids that are not clunked until the filesystem is > > > > > > > > > > unmounted, as indicated by this warning: > > > > > 9pnet: found fid 3 not clunked > > > > > > > > That explains why I saw so many fids not being clunked with recent > > > > Linux > > > > kernel versions while doing some 9p protocol debugging with QEMU > > > > recently. [...] > 9p maintainers, is there anything else that I can help with to get this > bug fix reviewed/merged? Thanks! Dominique is the only active 9p maintainer for a while and barely has time for 9p anymore (hint: implied call for volunteers hidden in this sentence). Dominique, do you have a time slice for this issue? I agree that it makes sense to bring this issue forward. Best regards, Christian Schoenebeck