Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp407404iol; Thu, 9 Jun 2022 06:19:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLB3LD5aGGUOs30e7HjXjbI/NnCRwHK9KnyXQt/rZdD0g4TDk3fO0/V3Cp9B0aBNJYodnm X-Received: by 2002:a63:144c:0:b0:3fa:6f09:a3e4 with SMTP id 12-20020a63144c000000b003fa6f09a3e4mr35121591pgu.102.1654780778829; Thu, 09 Jun 2022 06:19:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654780778; cv=none; d=google.com; s=arc-20160816; b=rX2qr9JHoox2ifyIay/OxcyZAZ9DlBeZ8cLCWNkSS9YbS/ilM7pK2zJ48XkGjfm7/S US9L2hLKzifIiwHDpVXtvwvfvP/uUi99dnjPFddhDLpjt7HOFQhjlMl7O9h572wNpmX8 JK4Dhwjk2wVDyirXzvWJaCo6FbQ4Gxi+1uUqHhoc1Zh7bpz5KLidclTcXBOXicsmI32J 80/nunK2rYYivM9oV5/ChKHgLoVkI1RchkstcrkHhSRHjlY3b3S3+ZBvcjWG14wdwNN6 1Es+Wvw2Q7wxSEU8q01pZhwZkYnjrBRcJYWGQkbAkTQQk2h+ilI+xqNJR8qF+hKZ+VAz Ujew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=F5ZSToeEB4YLYYrt0Hm/nSJBH+HVxSfxNH1oQ0BpYBA=; b=oBjzkqEBOoEeUdf4qftP3lQlAkBPmh1vgM/y5eX0CKoxmDdyjbi6zbIEasYkmo/Wjs jjfioQ/eo/QZ3Ebx13OySyrOeppvOdwpI2G+54iHZ5a7p1sw0QfT0oF15SrWQYlCKF/A cXTp+zqfToB3mFuSXslcdsF6ldPQLbZlnQpjL1gibtu/k5CFRqhy/7rrw7zNdFN3QftC z9vEYJaH4ZzyCxGtuRRVdQBlQJwaziiWC2AJYu6gfYkiIbae0/pNXbY2jEd7O0WNI6Qv Nul5zg0udYWFH7BbxWPYQtTjI0RcnhNcFv73qN46fjTE5Nl7EKIOy96EKDM9B5o+VLnO GCHg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=X3lE4bYA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u62-20020a638541000000b004019c5f7652si1371979pgd.640.2022.06.09.06.19.18; Thu, 09 Jun 2022 06:19:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=X3lE4bYA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243080AbiFIMou (ORCPT + 99 others); Thu, 9 Jun 2022 08:44:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343847AbiFIMob (ORCPT ); Thu, 9 Jun 2022 08:44:31 -0400 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::228]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDF0756B17 for ; Thu, 9 Jun 2022 05:44:26 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id A9CDD1BF210; Thu, 9 Jun 2022 12:44:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1654778664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F5ZSToeEB4YLYYrt0Hm/nSJBH+HVxSfxNH1oQ0BpYBA=; b=X3lE4bYA80dhA8Tjx2zzr4vxS9eWKSv0kf9+Y0lVmwEzPyP308WNYQeZmZnmNAdfj8F3Uu jBpNtGMPOnLBAshF5LDSf5RDQR1WZlVLz/jL02iV3f45wz/t2K2Z9F+MecULTxfb7mFS5p ZZJgd6RuJodW1MzYJ0luARRy04Vn74OAAZEsYjta4vJggKLbL6R5Ip+LUKcIJRDCnZh2Y8 D2HWvBASgwvyUzpnu1ldXCnoq3hpMNxTge2VffCzgrCzoR2CfW5nmHy/Ooc3VNXC0+lPDD Qv8ed5eKrpLT8aSY/J3+T5YXrH1y9UxsmovY9RY/UwK9udO44msGGEoPDmeSFg== From: Miquel Raynal To: Peng Wu , miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, christophe.jaillet@wanadoo.fr Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, liwei391@huawei.com Subject: Re: [PATCH v2] mtd: rawnand: cafe: fix drivers probe/remove methods Date: Thu, 9 Jun 2022 14:44:23 +0200 Message-Id: <20220609124423.209280-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220520084425.116686-1-wupeng58@huawei.com> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: b'18178e03b124b0c6be17abbbca914157642f5d7a' Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2022-05-20 at 08:44:25 UTC, Peng Wu wrote: > Driver should call pci_disable_device() if it returns from > cafe_nand_probe() with error. > > Meanwhile, the driver calls pci_enable_device() in > cafe_nand_probe(), but never calls pci_disable_device() > during removal. > > Signed-off-by: Peng Wu Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel