Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220606122612.2580930-1-foxhoundsk.tw@gmail.com> <YqHnr8SA2gbf45ok@worktop.programming.kicks-ass.net>
In-Reply-To: <YqHnr8SA2gbf45ok@worktop.programming.kicks-ass.net>
From:   Huichun Feng <foxhoundsk.tw@gmail.com>
Date:   Thu, 9 Jun 2022 21:23:26 +0800
Message-ID: <CAFbkdV2TCZ38ngMViCHgS_v2vMKVMpJwQBR7nZ0a=z6Vwam2Fw@mail.gmail.com>
Subject: Re: [PATCH] sched/fair: avoid redundant hrtimer check
To:     Peter Zijlstra <peterz@infradead.org>
Cc:     Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        "open list:SCHEDULER" <linux-kernel@vger.kernel.org>,
        Ching-Chun Huang <jserv@ccns.ncku.edu.tw>,
        Chin-En Lin <shiyn.lin@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Peter Zijlstra <peterz@infradead.org> =E6=96=BC 2022=E5=B9=B46=E6=9C=889=E6=
=97=A5 =E9=80=B1=E5=9B=9B =E4=B8=8B=E5=8D=888:29=E5=AF=AB=E9=81=93=EF=BC=9A
>
> On Mon, Jun 06, 2022 at 08:26:12PM +0800, Huichun Feng wrote:
> > The check is required iff HRTICK is enabled and DOUBLE_TICK is disabled=
,
> > avoid the redundant check by adding corresponding sched_feat() .
>
> How about: 'don't do that then'?

Looks good!

Should I send a v2 for this? Or could you help amend it directly?

Thank you!
Huichun