Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp432963iol; Thu, 9 Jun 2022 06:47:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJysRXZiBjjnKywIxQ7rhBgSzp/onkZ1Fo/ee6zOHwc2LYOrlZvIUG7wsFDeLzWltip3rruF X-Received: by 2002:a17:906:5e4c:b0:70a:4673:bdcc with SMTP id b12-20020a1709065e4c00b0070a4673bdccmr35057326eju.511.1654782432601; Thu, 09 Jun 2022 06:47:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654782432; cv=none; d=google.com; s=arc-20160816; b=GeOb7B58zV7QkdF0kIwC3O5DTb5OI3DX2tYYAUHbMV6YRv8iULm8ya69ou1MusSSA8 /Ac7MDUWx8w1jPCJO3N+eLLXsNB1ciIsjTcLjsup7vzFVVVYUxTL/3hqVJEyIEdiXF8W IWeGS66+G4YTM0aaYpp4gR0KPDKdXngorayIH7zLVJsmgE37+4YqaV9emAIZW4nJhl9m qiCP+cSULONr4LIMniOIih7Ckey6LylgvwAeRlxm3bN4dnn5vk9UHzRJf09+SjHrDY76 1++L/Pp+FjqFNsiHwpnLIMBROXDTPy5E/9PKntEtolBb5fD/RQhoD1qCPslmvfjcMrYJ lqMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=qivlgdc/cztAuyEVTvXwN0p2uVuSMV9HgTJpX4k6pDM=; b=eGOtR7UWJB1YH4RpiyXzyk9hIAm4gfKXt4QE4R9YnvJHjL8GWouad2nej3/HNbQERL 5IJ0wikPb0UNgwTz+9rErGu93ddEKS17XH6IULU6slNMHFGsZUwr8okSeX9UWZmc8M3f 3OY3ffamXvt8q81XZrSNKFj9mBgzW8PnMlhvNGq0R6t8YcneRDHm8Lb6CI3ibdOiHHiv gzaXu3jJLRXUwZj3fadL/EqHq4W9forjz6+XouVpgCFnfXRZr4G10cG8IlgaPCFcLja9 eGqWvv+O5r34UugOA4zXEkvhimi9hzkJZ1jEZ3Pd1oWhwmX6Ul2v00DyLtMvGnGv4EqK 5x/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=Jj2sZBM4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ht22-20020a170907609600b006ff47214f59si6028475ejc.515.2022.06.09.06.46.44; Thu, 09 Jun 2022 06:47:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bootlin.com header.s=gm1 header.b=Jj2sZBM4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=bootlin.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245738AbiFIMmq (ORCPT + 99 others); Thu, 9 Jun 2022 08:42:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238255AbiFIMmp (ORCPT ); Thu, 9 Jun 2022 08:42:45 -0400 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::224]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D3482DAA5 for ; Thu, 9 Jun 2022 05:42:43 -0700 (PDT) Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 1FE66E001B; Thu, 9 Jun 2022 12:42:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1654778562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qivlgdc/cztAuyEVTvXwN0p2uVuSMV9HgTJpX4k6pDM=; b=Jj2sZBM4vkrS8sixZpkHNa6eZ3gYoPy0pMoREerBewJ5iU1VVEQgQe1oauXSQ9rrPN7Qrv HQAFc4JiJzacfcDxjXm8m1+x544Zqf3jn7MpToRpm4ZglxefAM8RL/mROKoKECuAoaxVxV +DIRu7CdNFCOxwIN6yiR+9p4KD3gbRiiH4zpUJrVy5I5wLD4XOpmfmpliABQXdZfXDGqLu efj/Lwb0Fvx7gQ2ekvubXpeEA44Y43mYC7PihymGlo0Lm/4s4/gAKgKj+BHI5cKZiDu83W aN/TOUuIXJxEtSkLV/3DSg3bIju9q9zMCjUnPdRxdnJV6KH3aFeVOPQ8/DWxzA== From: Miquel Raynal To: Miaoqian Lin , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: parsers: ofpart: Fix refcount leak in bcm4908_partitions_fw_offset Date: Thu, 9 Jun 2022 14:42:40 +0200 Message-Id: <20220609124240.132923-1-miquel.raynal@bootlin.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220605070726.5979-1-linmq006@gmail.com> References: MIME-Version: 1.0 X-linux-mtd-patch-notification: thanks X-linux-mtd-patch-commit: b'd2b8a88a113d20dad823e32cd6b63b94c2da49b5' Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2022-06-05 at 07:07:23 UTC, Miaoqian Lin wrote: > of_find_node_by_path() returns a node pointer with refcount incremented, > we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > Fixes: bb17230c61a6 ("mtd: parsers: ofpart: support BCM4908 fixed partitions") > Signed-off-by: Miaoqian Lin Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks. Miquel