Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp452462iol; Thu, 9 Jun 2022 07:08:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzXPogGoWIWpnlnat498gM/twnAmMLXKNtYdZRX2GbPaxOfd5xQ2josZq1714AwPwwvt06 X-Received: by 2002:a17:907:3e82:b0:6ff:1e04:a365 with SMTP id hs2-20020a1709073e8200b006ff1e04a365mr36370401ejc.617.1654783721396; Thu, 09 Jun 2022 07:08:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654783721; cv=none; d=google.com; s=arc-20160816; b=0+Sw2rsX01AMEYSPNaD1r2y8nW+O3RG3OXlZpSv35Hy+FqqXEWOx8Py3DSSqO4Lk7A +HAUFfwjtMR1p23Nf+bxOu7M3jN58+OCnxvWjPHnhjYbfDgRR7AHKdkgoB/INHK5NeEZ zmlOjeraOzGNb6Zknc2j53+smWgZPARD4tXltUlOkYii5lcf/0ijs5HN6bswrnjJjB+l CvFmXiQ9icL7PD25uKtq5p5yJr0ouch54xUrVBvh42oyyc53h7RLxCeuy0AB60tWerzr FSJ62Bm5ycnK89LIIMik6pwJzLcTWxOcJfa8XCmRWFVMexjGjxIPdLOW/A58mocwE+uG ITLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:to:subject:message-id :date:from:in-reply-to:references:mime-version:dkim-signature; bh=Gepr+P/b1NDSmcOnfY4R8HvcHSNLzUy+z/OdcbwQQN0=; b=zmmpEBMxxrK3gV2HtWyEILE/mYoFOGdzr94miUZOb8dGttFmECLoGjYogGrK4SWuoz 1H+W2XfwJTD3MIDHO0p/0FXYIUB7yby2KZViAlqD7Wv17buN9E84hjqrzScIkvi2zcq0 Tc7sGVx8SFEcj+LmLjaJcr9J3vKn35R03+NCbmkiPkMz0QVe0bed2eONx38/D2sqWOmx s1h51dWCrdStwSRHKjPA9jNoHEKDTNBrNQW1exzAQ9NqUsEVqGjAZHfr5tvhxF/dHnrv 94Bi8d6ECrVciUTHy0FKRLfvDosvvu87lSHjmRYJ/b56YnVwQAaSRuU3kPm6RrF/IdY7 lqtA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=IVDzHPmL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e22-20020a17090658d600b006fe9609be80si33960782ejs.870.2022.06.09.07.07.56; Thu, 09 Jun 2022 07:08:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=IVDzHPmL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343665AbiFINCz (ORCPT + 99 others); Thu, 9 Jun 2022 09:02:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343664AbiFINCo (ORCPT ); Thu, 9 Jun 2022 09:02:44 -0400 Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com [IPv6:2607:f8b0:4864:20::b2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCD5B11C3C; Thu, 9 Jun 2022 06:02:41 -0700 (PDT) Received: by mail-yb1-xb2f.google.com with SMTP id r82so41593590ybc.13; Thu, 09 Jun 2022 06:02:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :content-transfer-encoding; bh=Gepr+P/b1NDSmcOnfY4R8HvcHSNLzUy+z/OdcbwQQN0=; b=IVDzHPmLeelA9KNfGflsoBU8djymr45P8BxesF2r7710KLlLMckE4z+3I6W4224ev3 37oiqivW+s7XbwUGnNyMeBS94wdkeZNbfdy0yAiKVOzj8EeQBKDc8A9XoDnGlYyFFS3s TWR1sNbw+IYPMT1NUZ7B2GCHAToHwtQKHmnUfZziuUZKYPamevhwYPC+G0ZuirPzJgWY 2qb4bjxZCyRnS5rUUpGN2wFgE7sj+q0DbYiXxJQ4+2SnlXlF5px58u6RogmEP7ve5aK7 c2v4exBQWteJgnPXJz24OPgNQ/YLMdY+ZAUHD1qzc6BVsb9JNfqb1/uOY+kgZSwIYyy7 nwzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:content-transfer-encoding; bh=Gepr+P/b1NDSmcOnfY4R8HvcHSNLzUy+z/OdcbwQQN0=; b=Oiy2REWl7gBmopr3jeInFfnGbc/qm6rW2ibjCvP8gHyBlfD0+xWPlCiCKMzfHcphHr FuRBiRnUXqRskZ/+OkD5vmyjsMo5WxDKeZZwYDR96Hb57UiLcAaNV9lxEf9Bg14Kjv/V ZGM1uRz1LHRJ/WgAXLVrg5Germ9EinKxX0wACgL6/QfZcsC3u6vPTBXn+Go53hDNVkUW MoIhOLp6PG0WpCADngLI4wK41CrwWXkmMMQmtcgDf86NH1qOwUkThLrhSklf7JQFiJyq vvBQ+dkstUlaXwkvO+Gl85EuxHHGW1CN4/EOOWY+j5uwHF9/S1yFMvMAQoDzi3AvofrQ AiqQ== X-Gm-Message-State: AOAM533xAbe9ITyrmlPpgCGY7J3ReReQ6ZpKZuqVGEX6SMr/TxG2H5Up V+VFyf52ES+shh7QOz8GLkSfv44vn5rDAM3N5A== X-Received: by 2002:a25:d03:0:b0:664:37a2:4d03 with SMTP id 3-20020a250d03000000b0066437a24d03mr2409941ybn.308.1654779760779; Thu, 09 Jun 2022 06:02:40 -0700 (PDT) MIME-Version: 1.0 References: <20220525032341.3182-1-warp5tw@gmail.com> <20220525032341.3182-4-warp5tw@gmail.com> In-Reply-To: From: Tyrone Ting Date: Thu, 9 Jun 2022 21:02:30 +0800 Message-ID: Subject: Re: [PATCH v6 3/5] i2c: npcm: Correct slave role behavior To: Wolfram Sang , Tyrone Ting , avifishman70@gmail.com, tmaimon77@gmail.com, tali.perry1@gmail.com, venture@google.com, yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, andriy.shevchenko@linux.intel.com, jarkko.nikula@linux.intel.com, semen.protsenko@linaro.org, jsd@semihalf.com, sven@svenpeter.dev, lukas.bulwahn@gmail.com, olof@lixom.net, arnd@arndb.de, tali.perry@nuvoton.com, Avi.Fishman@nuvoton.com, tomer.maimon@nuvoton.com, KWLIU@nuvoton.com, JJLIU0@nuvoton.com, kfting@nuvoton.com, openbmc@lists.ozlabs.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram: Your previous suggestion about this commit is highly appreciated. Thank you. Wolfram Sang =E6=96=BC 2022=E5=B9=B46=E6=9C=889=E6=97=A5 = =E9=80=B1=E5=9B=9B =E4=B8=8A=E5=8D=884:03=E5=AF=AB=E9=81=93=EF=BC=9A > > On Wed, May 25, 2022 at 11:23:39AM +0800, Tyrone Ting wrote: > > From: Tali Perry > > > > Correct the slave transaction logic to be compatible with the generic > > slave backend driver. > > > > Fixes: 56a1485b102e ("i2c: npcm7xx: Add Nuvoton NPCM I2C controller dri= ver") > > Signed-off-by: Tali Perry > > Signed-off-by: Tyrone Ting > > Much easier to review this way! Applied to for-next, thank you! > Best Regards, Tyrone