Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i8771445c:Fastmail
Date:   Thu, 9 Jun 2022 16:22:53 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Saud Farooqui <farooqui_saud@hotmail.com>
Cc:     jernej.skrabec@gmail.com, samuel@sholland.org,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org, wens@csie.org, daniel@ffwll.ch
Subject: Re: [PATCH] drm/sun4i: Add return statement in
 sun4i_layer_format_mod_supported Add a missing return after the
 IS_ERR_OR_NULL() check in sun4i_layer_format_mod_supported()
Message-ID: <20220609142253.7aad4jlaoahqkmy7@houat>
References: <PA4P189MB142180104916392C559B44308BA59@PA4P189MB1421.EURP189.PROD.OUTLOOK.COM>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="pau22cvielrudrtl"
Content-Disposition: inline
In-Reply-To: <PA4P189MB142180104916392C559B44308BA59@PA4P189MB1421.EURP189.PROD.OUTLOOK.COM>
Precedence: bulk


--pau22cvielrudrtl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi,

On Tue, Jun 07, 2022 at 02:51:50PM +0500, Saud Farooqui wrote:
> Signed-off-by: Saud Farooqui <farooqui_saud@hotmail.com>

Your patch doesn't seem to be formatted properly.

The commit title should be much shorter, and the commit log should
explain what the issue is, and what is done in that patch to address it.

Maxime

--pau22cvielrudrtl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYqICPQAKCRDj7w1vZxhR
xY0uAP4yFkFuPx+QhUwoeXQChX42nSHYYKQzaiiHP57iWvmKZwEAy4n3+I9JSRKm
0sGsGa8eWevNsiB22zOUiDwpFvY+3QQ=
=56V8
-----END PGP SIGNATURE-----

--pau22cvielrudrtl--