Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <CAHk-=wh6+KUi+T8Ncn6BWTHDTJCzrJxgT47SWbq-ZWs1_vbvHA@mail.gmail.com>
References: <CAHk-=wh6+KUi+T8Ncn6BWTHDTJCzrJxgT47SWbq-ZWs1_vbvHA@mail.gmail.com> <20220422134308.1613610-1-svens@linux.ibm.com> <202204221052.85D0C427@keescook> <CAHk-=wjahn2fZtMxmc4D9UOUGWVws1wZ=X46jrTV=_tEpzXeoA@mail.gmail.com> <202206081404.F98F5FC53E@keescook> <CAHk-=wiFn-_OaWKY=nXt3YSiy=obrNoQW_u7zKO7qoArez=GUw@mail.gmail.com> <AEEBCF5D-8402-441D-940B-105AA718C71F@chromium.org>
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     dhowells@redhat.com, dchinner@redhat.com,
        Kees Cook <keescook@chromium.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Fabio Estevam <festevam@gmail.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] s390: disable -Warray-bounds
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4147482.1654784079.1@warthog.procyon.org.uk>
Content-Transfer-Encoding: quoted-printable
Date:   Thu, 09 Jun 2022 15:14:39 +0100
Message-ID: <4147483.1654784079@warthog.procyon.org.uk>
Precedence: bulk

Linus Torvalds <torvalds@linux-foundation.org> wrote:

> > Yeah. Happily, this has already been solved, but it looks like David d=
idn't do a pull yet for it?
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/=
log/?h=3Dfscache-next
> =

> Good.

Do you want it tagging and a pull req generating, even though it's a singl=
e
patch?

Note that Dave Chinner would rather I converted code like:

	struct myfs_inode *myfsinode =3D xyz;
	myfsinode->netfs.inode.i_ino =3D 123;

to something like:

	struct myfs_inode *myfsinode =3D xyz;
	struct inode *inode =3D VFS_I(myfsinode);
	inode->i_ino =3D 123;

where the translation is wrapped inside a VFS_I() macro in every filesyste=
m
and wants this across all filesystems.  I think the former looks cleaner, =
but
he has a point about how to deal with yet another layer of wrapping being
inserted in the future.  Do you have a preference?

David