Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp539638iol; Thu, 9 Jun 2022 08:41:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8CEwcZTJFPlVZ551tEJNgofrLa2OZ8bSCW8ME2wMt4e3xII62hN9l4HHmk4z6i/9MI6Nj X-Received: by 2002:a17:90b:304:b0:1e3:4489:193c with SMTP id ay4-20020a17090b030400b001e34489193cmr4049534pjb.78.1654789282852; Thu, 09 Jun 2022 08:41:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654789282; cv=none; d=google.com; s=arc-20160816; b=rvfyOhf1NrUVPrWS6X1kO+SkY3ppagAq713LGqPRshbcls3zmXt2aGaONpS4Meo/j2 1ah6HspZXc6nQqypmhhQiK1Ef2uKyIU1w2jkhQPzmlhY6Dl/y5fLsLIlISMtxyiVXQ2B B9mYGPqmTgXN4pwNg6lM2YS7MZyz+Bu+QXXDTWyB13E9NY7sQHH8BOUGHYoFdg/YwL92 kMySCyfOtPSjEW3N1vXOoynLFDfcxFESySlGFm7aNKn1Sv4uo9NIzmra8ZfLxVjxJGzF IKmxq0Lkq6v39LMMDr0hdxasyEcW+X8YVnU2VKY/wp0cvcMhLrVdk5dXI13c34K45TBf 0IFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=GViOxLh/L9Z1BaBIaaVBUq7TYT5YUplZnmqvB9r+mo0=; b=nSLsLX0RtxA269ywWuQZ7gp3NCXmK4FWga6vqBjyDyurK92QTtRnMDndA5u3zH56E+ K7EVik8HppfU2x2CXTXGDtFtZvjf/WNSrsr0df65cwTkTAsYxJ1jt7aCJgIfHd2onAsm 3oMQkE78gaUSxRSUN8eMNb/164Vub2vB2zHU/9RZT2RiURLHQJe/0WB4C72GF/5ZQC0O Ennetjfu3flkSh3CnY2MOHkFXyDJRgh/nI61lYqeVRxETXh9yY3IPSlgBkK9ejPEQ7Ye ZA2NSPa136FTO8yHrhtQggPqXcjqWkFVl09WDu99G1KZyIAc4uBIdfM8P5QeYMWmfM79 i7PQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k7-20020a170902c40700b0016206ea00cbsi37782911plk.61.2022.06.09.08.41.07; Thu, 09 Jun 2022 08:41:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344184AbiFIPPZ (ORCPT + 99 others); Thu, 9 Jun 2022 11:15:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242062AbiFIPPY (ORCPT ); Thu, 9 Jun 2022 11:15:24 -0400 Received: from outbound-smtp26.blacknight.com (outbound-smtp26.blacknight.com [81.17.249.194]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 611271BE9A for ; Thu, 9 Jun 2022 08:15:19 -0700 (PDT) Received: from mail.blacknight.com (pemlinmail02.blacknight.ie [81.17.254.11]) by outbound-smtp26.blacknight.com (Postfix) with ESMTPS id 40165CABE2 for ; Thu, 9 Jun 2022 16:15:18 +0100 (IST) Received: (qmail 23872 invoked from network); 9 Jun 2022 15:15:18 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.198.246]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 9 Jun 2022 15:15:17 -0000 Date: Thu, 9 Jun 2022 16:15:16 +0100 From: Mel Gorman To: Muchun Song Cc: mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com, akpm@linux-foundation.org, vbabka@suse.cz, peterz@infradead.org, dhowells@redhat.com, willy@infradead.org, Liam.Howlett@oracle.com, mhocko@suse.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org Subject: Re: [PATCH v2] mm: sysctl: fix missing numa_stat when !CONFIG_HUGETLB_PAGE Message-ID: <20220609151516.GA30825@techsingularity.net> References: <20220609104032.18350-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20220609104032.18350-1-songmuchun@bytedance.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 09, 2022 at 06:40:32PM +0800, Muchun Song wrote: > "numa_stat" should not be included in the scope of CONFIG_HUGETLB_PAGE, if > CONFIG_HUGETLB_PAGE is not configured even if CONFIG_NUMA is configured, > "numa_stat" is missed form /proc. Move it out of CONFIG_HUGETLB_PAGE to > fix it. > > Fixes: 4518085e127d ("mm, sysctl: make NUMA stats configurable") > Signed-off-by: Muchun Song > Cc: Acked-by: Mel Gorman -- Mel Gorman SUSE Labs