Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Peter Korsgaard <peter@korsgaard.com>
To:     Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc:     Srinivas Neeli <srinivas.neeli@xilinx.com>, a.zummo@towertech.it,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        michal.simek@xilinx.com, sgoud@xilinx.com, shubhraj@xilinx.com,
        srinivas.neeli@amd.com, neelisrinivas18@gmail.com,
        devicetree@vger.kernel.org, linux-rtc@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        git@xilinx.com
Subject: Re: [PATCH V6 2/2] rtc: zynqmp: Add calibration set and get support
References: <20220609140833.1784738-1-srinivas.neeli@xilinx.com>
        <20220609140833.1784738-2-srinivas.neeli@xilinx.com>
        <87r13x28o4.fsf@dell.be.48ers.dk> <YqIJektBvAwOqNkA@mail.local>
Date:   Thu, 09 Jun 2022 16:59:45 +0200
In-Reply-To: <YqIJektBvAwOqNkA@mail.local> (Alexandre Belloni's message of
        "Thu, 9 Jun 2022 16:53:46 +0200")
Message-ID: <87mtel287y.fsf@dell.be.48ers.dk>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

>>>>> "Alexandre" == Alexandre Belloni <alexandre.belloni@bootlin.com> writes:

 > On 09/06/2022 16:50:03+0200, Peter Korsgaard wrote:
 >> >>>>> "Srinivas" == Srinivas Neeli <srinivas.neeli@xilinx.com> writes:
 >> 
 >> > Zynqmp RTC controller has a calibration feature to compensate
 >> > time deviation due to input clock inaccuracy.
 >> > Set and get calibration API's are used for setting and getting
 >> > calibration value from the controller calibration register.
 >> > As per RTC spec default calibration value is 0x7FFF.
 >> 
 >> Where do you see that? ug1085 rev2.2 still lists:
 >> 
 >> Programming Sequences
 >> init rtc
 >> 1. Write the value 0019_8231h into the calibration register, CALIB_WRITE.
 >> 

 > This is a very weird value. Last time I had a look, I couldn't find an
 > explanation for it.

Agreed. I am not arguing that it is sensible, I just wondered where this
new value comes from?

-- 
Bye, Peter Korsgaard