Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp553631iol; Thu, 9 Jun 2022 08:59:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzpvfH6aNucwwoyPygzuBgNTcJKTKeCaYJBrjqDrGXfp/38NwSDdXxL5yGc49z2osdqUTTT X-Received: by 2002:a17:902:7442:b0:167:8dd5:6a50 with SMTP id e2-20020a170902744200b001678dd56a50mr16627664plt.68.1654790342069; Thu, 09 Jun 2022 08:59:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654790342; cv=none; d=google.com; s=arc-20160816; b=i+KdL0JI/mrXjXrcrL6Wm7ACsJDCULpJvDVXb+boZbGWCCriDoY8JKPcsUAFMUHVDZ H3BgEBocmACmVMvko1/56xA9skoLVMQNkrx2iiNYgQQq+5Iqr3NIZyTioIJCyYFWHc0k h6AmVytahMJSTW8d/J3CfvsuLrH87RT4yWcUADQxqNxKiNkX6DOYEW7XpdObvjDAdkWM NB/S7UG1viaZWnZuuW1mQhz819frDf+U6nJLGP74EjNIImv4IhsoBGUi0HJJOaPF7Frw PAw/PDJPVTKf3lQkiH1daDqHaRypL+AtZT7xpepGcN/A6D/D2l5sQ53lyMmbQOojp02q sz3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from; bh=5eAemRgYbqQNlB4iHj1pHJwBcMqZAvR1xKonGp5uaZo=; b=qgH5RhPVcxQx92EwdPcFZ9ppG9nTNmS7c+VTLlgkoVPnZ0CD8kMrUAdgbHQ35RY/u0 Gt3uNJR/S+kGgQWRu+WYcHPj9fs8PL5a6ijOtF+BsBeQPR7ZmJeNFqM68bW1iCkCg0Ad 0U5HvUEChHF2SBX5vYu4U2Z2UlpSNMVCQYX2hp3jopKNLrGBhbowMgcNudDp3lB5mphM H5DOj9c4TXYMwz0WnaDS7+jyORSiJmAUOIijWhOPDFu18C5GYRdUfCauCQ24picVttQC XF9WtZ8sYVH8s66o2IjTfqayMlcD0KZW2YJLhfB7pX9FnPuLK2aPUL2Yix0TJAfL6ANN yVmQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bm18-20020a656e92000000b003fcd3d1b031si36208933pgb.562.2022.06.09.08.58.44; Thu, 09 Jun 2022 08:59:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343842AbiFIPAA (ORCPT + 99 others); Thu, 9 Jun 2022 11:00:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241569AbiFIO7w (ORCPT ); Thu, 9 Jun 2022 10:59:52 -0400 Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFC8A1F8993; Thu, 9 Jun 2022 07:59:50 -0700 (PDT) Received: (Authenticated sender: peter@korsgaard.com) by mail.gandi.net (Postfix) with ESMTPSA id C09A3C000D; Thu, 9 Jun 2022 14:59:46 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.94.2) (envelope-from ) id 1nzJdR-0029HW-SW; Thu, 09 Jun 2022 16:59:45 +0200 From: Peter Korsgaard To: Alexandre Belloni Cc: Srinivas Neeli , a.zummo@towertech.it, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, michal.simek@xilinx.com, sgoud@xilinx.com, shubhraj@xilinx.com, srinivas.neeli@amd.com, neelisrinivas18@gmail.com, devicetree@vger.kernel.org, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, git@xilinx.com Subject: Re: [PATCH V6 2/2] rtc: zynqmp: Add calibration set and get support References: <20220609140833.1784738-1-srinivas.neeli@xilinx.com> <20220609140833.1784738-2-srinivas.neeli@xilinx.com> <87r13x28o4.fsf@dell.be.48ers.dk> Date: Thu, 09 Jun 2022 16:59:45 +0200 In-Reply-To: (Alexandre Belloni's message of "Thu, 9 Jun 2022 16:53:46 +0200") Message-ID: <87mtel287y.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "Alexandre" == Alexandre Belloni writes: > On 09/06/2022 16:50:03+0200, Peter Korsgaard wrote: >> >>>>> "Srinivas" == Srinivas Neeli writes: >> >> > Zynqmp RTC controller has a calibration feature to compensate >> > time deviation due to input clock inaccuracy. >> > Set and get calibration API's are used for setting and getting >> > calibration value from the controller calibration register. >> > As per RTC spec default calibration value is 0x7FFF. >> >> Where do you see that? ug1085 rev2.2 still lists: >> >> Programming Sequences >> init rtc >> 1. Write the value 0019_8231h into the calibration register, CALIB_WRITE. >> > This is a very weird value. Last time I had a look, I couldn't find an > explanation for it. Agreed. I am not arguing that it is sensible, I just wondered where this new value comes from? -- Bye, Peter Korsgaard