Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 9 Jun 2022 18:26:53 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Srivathsan Sivakumar <sri.skumar05@gmail.com>
Cc:     Manish Chopra <manishc@marvell.com>, GR-Linux-NIC-Dev@marvell.com,
        Coiby Xu <coiby.xu@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        netdev@vger.kernel.org, linux-staging@lists.linux.dev,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: qlge: qlge_main.c: convert do-while loops to
 for loops
Message-ID: <20220609152653.GZ2146@kadam>
References: <YqIOp+cPXNxLAnui@Sassy>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YqIOp+cPXNxLAnui@Sassy>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fBPuflyvVGonM93BOXPnHD2/Zh6X/eDbNoQyj/0CGfWIN2V6hgPRbVx0oz+8?=
 =?us-ascii?Q?mWUP7j3gp0aAYrtqWgNNcvMAlKNnCJxiOW3afHqjZ76d/htnaMvsfp4Kp5V1?=
 =?us-ascii?Q?G3wxhCGaizJzQDJ+Oz123KRPE2nA3jVyth3jdxoymn+Ik+RdV8zvLYH7ThDG?=
 =?us-ascii?Q?7c+yAbaJID29e/M0BWkyom+1+u9AuHyYoXdB1EfqKjkUaS6ULjXQrT2r9Jeq?=
 =?us-ascii?Q?XGbtVLftlgD16XF8EYmH2ELAhZfhcBmvbmNau1c6iMb1MfYWFui9POx9XRvX?=
 =?us-ascii?Q?/AhquxlL6n22EddNhZP/lGbxU+3cXdpuoyjhiUbHgI9Vn4fO3vKpPekoD0Ad?=
 =?us-ascii?Q?HbyQeXdULhOB8V7Qb0FJvzSfEHoCfXI0jX/tzoDi08VDVxDOJR2pvw8W2d7x?=
 =?us-ascii?Q?yarttkADtzBmQ4axHUzPLJ3PhCAoI++D9SlArFSP/yLm1RnOb9dGKdPWsUWh?=
 =?us-ascii?Q?CydiEjd8YqC1UbLoi5PyREsPY9kMjKziVKOGyzYuJNo/qTH5UGOIJWzYcBPY?=
 =?us-ascii?Q?DsMl/WUUbtD77vT95fjLKm92kN+F3a5uM59nk15spOa1/mC9mCuJZ3TUM2gB?=
 =?us-ascii?Q?8k2wBekzACN1peVNaz7yH6pVIEMMLhemdW3VijoNu6wAIP7fLSsfArrro3hK?=
 =?us-ascii?Q?pqle3gOlyq6OJ2Z6X1lzYwSsv4li98jYxJly/UB+1e0v7t0TDNgMH/YiXfB7?=
 =?us-ascii?Q?ZpGZ8Fiww8t3GUdH3kpTl/7Wxb+uAK4axQqaRArHlqjLTZhQCv8PZ9jHzgR3?=
 =?us-ascii?Q?VygK5HtGIdmCOOCyC86rSJdR7VWjKvAa+xUpuyfB/E9A8Iqr51i8Cf78uN6g?=
 =?us-ascii?Q?kFgOF389Mtpw80Je/eEWk5cV0n71oYVL3tDk5d8R9DLJVQX5/ROCgWykiYGR?=
 =?us-ascii?Q?zAKFFcgBTwc86uNqoed7O/GcnHsSV0m3osCoNHgGekby2dLyXgAA41ApekPu?=
 =?us-ascii?Q?dbbuq0PqZdHRFubca2rrBhQVXcdtJtdZ1k/JiXasv0ZSHHcPP97Q9med4CGr?=
 =?us-ascii?Q?6bRWoSNA3ljONUh8PZkYeejJHv3blFkzq4X8JFZpj2bKu8EB3aIFy3Hapzdf?=
 =?us-ascii?Q?Q1C2vL+OhJv3v/5YkjiD8TmAwTxzqqXqu4uu7yHNdlxhgjB4teSCwo3nl/Ps?=
 =?us-ascii?Q?rq2duKHuBUtdZb6XoGIae5ccjn+Vq3obTu13X1nBEwP+sFSKzkG2QrnTx5Qs?=
 =?us-ascii?Q?zaQx6mCsRdFsHHf8Y+Sb1Q67NiMogu7ivqCLQJiLQIXhwrlfjrRCj93QmNsz?=
 =?us-ascii?Q?JbhLW9Zd9kclk5kKjNrikz2Ui0kkWLoXcqwPw89G9PAZUNxkbk1vccG86rDX?=
 =?us-ascii?Q?6lQkde+rMrhVEzG4AmbYnWQczcLFtMoQazyjacdLkQOihuyJiqG5SDXuIfFA?=
 =?us-ascii?Q?U73IeJi5M6GwzOUgvPZ2FdD8pVU6IBFtHLefXwTyKjlJtZt+4qUvC8uobawD?=
 =?us-ascii?Q?S/EN65+o0j+921k7k4gFRjjWZvDEjWyeaIEA+VYLWg7e3BlKEyZm8k0Ga/Mw?=
 =?us-ascii?Q?5azPQT4+0iDg6XhhyY08R61mFEO1NHcunmrFoYkFOgBpxDb2fPhBeAlOxj9Z?=
 =?us-ascii?Q?J1bmS6HjgT15wG1nP4G1zN/KkzBMwYT2qii22VDXn5CHikQwpm1KnznR1fLH?=
 =?us-ascii?Q?vaM7tX5d38HGXHirQ2RdFBo+rivDMYCV+cgg2Uena7+1zX/UBGRyllwsfmbA?=
 =?us-ascii?Q?9i3DEIb44cPzm2sN6FtqG/30CxNJeyRwO18D59Pn1UoPMEGolu7XvTZBYawk?=
 =?us-ascii?Q?rgvRAvEcLwEmxdNQss2pDRlYo+MMIpI=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 107be47c-e042-4f77-0a4c-08da4a2c8858
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jun 2022 15:27:16.0333
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W+JKGZ0IhkMQpxTe+Wjqjt7NfxmwbE5KsXF4lgOsf/eRa+ThX1KQYmefbZlXebOIdkUUkJppTFetq8uZFlSq9mftFSR1SrV+B6VOKjNLn4w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1974
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-09_11:2022-06-09,2022-06-09 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=956 spamscore=0
 adultscore=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206090060
X-Proofpoint-GUID: ji9CPhnqz3ES1U2AOivEXSteVOJq5TGf
X-Proofpoint-ORIG-GUID: ji9CPhnqz3ES1U2AOivEXSteVOJq5TGf
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 09, 2022 at 11:15:51AM -0400, Srivathsan Sivakumar wrote:
> diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
> index 8c35d4c4b851..308e8b621185 100644
> --- a/drivers/staging/qlge/qlge_main.c
> +++ b/drivers/staging/qlge/qlge_main.c
> @@ -3006,13 +3006,13 @@ static int qlge_start_rx_ring(struct qlge_adapter *qdev, struct rx_ring *rx_ring
>  		cqicb->flags |= FLAGS_LL;	/* Load lbq values */
>  		tmp = (u64)rx_ring->lbq.base_dma;
>  		base_indirect_ptr = rx_ring->lbq.base_indirect;
> -		page_entries = 0;
> -		do {
> -			*base_indirect_ptr = cpu_to_le64(tmp);
> -			tmp += DB_PAGE_SIZE;
> -			base_indirect_ptr++;
> -			page_entries++;
> -		} while (page_entries < MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN));
> +
> +		for (page_entries = 0; page_entries <
> +			MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); page_entries++) {
> +				*base_indirect_ptr = cpu_to_le64(tmp);
> +				tmp += DB_PAGE_SIZE;
> +				base_indirect_ptr++;
> +		}

It's better than the original, but wouldn't it be better yet to write
something like this (untested):

		for (i = 0; i <	MAX_DB_PAGES_PER_BQ(QLGE_BQ_LEN); i++)
			base_indirect_ptr[i] = cpu_to_le64(tmp + (i * DB_PAGE_SIZE));

Same with the other as well, obviously.

regards,
dan carpenter