Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 9 Jun 2022 11:25:52 -0500
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Hongxing Zhu <hongxing.zhu@nxp.com>
Cc:     "l.stach@pengutronix.de" <l.stach@pengutronix.de>,
        "bhelgaas@google.com" <bhelgaas@google.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "broonie@kernel.org" <broonie@kernel.org>,
        "lorenzo.pieralisi@arm.com" <lorenzo.pieralisi@arm.com>,
        "jingoohan1@gmail.com" <jingoohan1@gmail.com>,
        "festevam@gmail.com" <festevam@gmail.com>,
        "francesco.dolcini@toradex.com" <francesco.dolcini@toradex.com>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH v9 7/8] PCI: imx6: Move the phy driver callbacks to the
 proper places
Message-ID: <20220609162552.GA514635@bhelgaas>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <AS8PR04MB86768DB1E04AAE3D63E8BE618CA79@AS8PR04MB8676.eurprd04.prod.outlook.com>
Precedence: bulk

On Thu, Jun 09, 2022 at 06:20:16AM +0000, Hongxing Zhu wrote:
> > -----Original Message-----
> > From: Bjorn Helgaas <helgaas@kernel.org>
> > Sent: 2022年6月9日 2:58
> > To: Hongxing Zhu <hongxing.zhu@nxp.com>
> > Cc: l.stach@pengutronix.de; bhelgaas@google.com; robh+dt@kernel.org;
> > broonie@kernel.org; lorenzo.pieralisi@arm.com; jingoohan1@gmail.com;
> > festevam@gmail.com; francesco.dolcini@toradex.com;
> > linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> > linux-kernel@vger.kernel.org; kernel@pengutronix.de; dl-linux-imx
> > <linux-imx@nxp.com>
> > Subject: Re: [PATCH v9 7/8] PCI: imx6: Move the phy driver callbacks to the
> > proper places
> > 
> > On Fri, May 06, 2022 at 09:47:08AM +0800, Richard Zhu wrote:
> > > To make it more reasonable, move the phy_power_on/phy_init callbacks
> > > to the proper places.
> > > - move the phy_power_on() out of imx6_pcie_clk_enable().
> > > - move the phy_init() out of imx6_pcie_deassert_core_reset().
> > 
> > I'm not sure what "make it more reasonable" is telling me.  In
> > subject line and commit log, please say something more specific
> > than "the proper places."
> > 
> > It's probably more important to say where they are moving *to*
> > than where they're moving *out of*.

> Thanks for your comments.
> In another review loop listed below, Lucas used said that it's not
> good to hide PHY init in imx6_pcie_assert_core_reset() So, I make a
> try to move the phy_init() out of imx6_pcie_assert_core_reset().
> And move phy_power_on() out of imx6_pcie_clk_enable() accordingly.
> https://patchwork.kernel.org/project/linux-pci/patch/1646289275-17813-1-git-send-email-hongxing.zhu@nxp.com/
> Okay, I would specific that they are moving *to* later.
> 
> > > In order to save power consumption, turn off the clocks and
> > > regulators when the imx6_pcie_host_init() return error.
> > 
> > Is the power savings the *reason* for this change?  I can't tell
> > from the commit log.
>
> The error handling of the imx6_pcie_host_init() is not mentioned in
> the subject.  Should I split these changes into two patches?

If they can be split, they probably should be split.