Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp600895iol; Thu, 9 Jun 2022 09:51:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuPA+XE4PvF3NjgQK6mRIIligU4T371feP5E++VuhdY5g+GUpsyvrP2XAbzGXvpurLVB2V X-Received: by 2002:a17:907:16a4:b0:711:c9a7:dc75 with SMTP id hc36-20020a17090716a400b00711c9a7dc75mr21252854ejc.542.1654793504935; Thu, 09 Jun 2022 09:51:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654793504; cv=none; d=google.com; s=arc-20160816; b=vL/uZLqkWRnKBkFbZuYHjF/A90wbsECkJ+/bif5XaDHzRzGJYqMiJOL8W6DaZ9Dr+p KOvBxpJ57Bfx29vQx7TAROB76qEt6FSrkw0SvfIzlra9RsrR3MBuWZ0XWDANFOD2fgf9 7nj/rmEVtKrKg2//uNhi9yn1+ByfRhfQGrSOLHW+kJ2PXi96mrEEPOhvgZ90aFI6Rygu RKEveCDot3XOliKluuPRWOPn4OehHE731q6k5xkjr3SgI7Xl6TdBI+vqF1u3ZCJhkmdH uPefqLPWfqMeCnbXd8uA4kLupb3kxXU8pMQ8vEu6wb8kEXHoxFda/3IimNRO0WIWqzBr gYOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=RUNdNGsx1EbAWX4hDBzAxRNhEnEW7aJCCSxaBq4YHiU=; b=SQldK3xfeu1AOkktM3qIbj4dH0G13eD3eX5lXauKgmVCkUbSO16NI50zFh7Kr2GCR4 cZRq6420YvCis5J5vk1GsuIb0V0MVEwHBrybtlUZtWPOhxrjsSb9luvIgfY8l6MbzJV9 G+8xXYdp/o6i0UFwO2sNX5H4j3sAlxGOkzVQvZX65t3MMxi+mBg6XuVWpU1MYUhM5VBB fpKpiA0GHRNRPBKEhLQ1yKDEkPvtdtZXSc3l3XOj5SEd4qfK9MyeXteKqmFc3/ecHd46 MYcSUgki3CwP3ShrYFrRG3XKmntfikjWjAxlA208xcv+TWSUcZrp3EPL5rIbcY/ak1EY t/cw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="I/OSSC+L"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w14-20020a05640234ce00b0042fac061a54si23449866edc.513.2022.06.09.09.51.19; Thu, 09 Jun 2022 09:51:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="I/OSSC+L"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244326AbiFIQVi (ORCPT + 99 others); Thu, 9 Jun 2022 12:21:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237389AbiFIQVf (ORCPT ); Thu, 9 Jun 2022 12:21:35 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2241B55BE; Thu, 9 Jun 2022 09:21:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654791695; x=1686327695; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=0CsSwkvejVm3bVTO7Azc2brKlKE9Yji53qGgFJwL8DY=; b=I/OSSC+LOPbYIcRBRIlnWwhEvDzUz4c76FAwOpo2jOZM48P+Lv6IvImX u/A5ydLhxMWG4BiOLwqklfK/Q0njFNb10u7bwPxzQEqtT5YalSQZsTs6a vG0xhgLCVgKsQCxoxlZQkdaDjZaQQoAL/+TNx9GpXVax2lD0UmWGmWKg+ yaBiA5RZx928T9NlxqqEJFmbDFRkFBSxYKgQ/8lKXx6cJSW6HmBrxwyG4 1KhRA3ZXPiXdl5Va5SqDUA9B5/knA8RFUYJZbEd0ueahMtyXOXLVowLAj Q4rYyZSDIwZMy4pKAurE1wUnATFavNqK5ZO9HcY5LvkpmpesBXCzBtvtY A==; X-IronPort-AV: E=McAfee;i="6400,9594,10373"; a="277363613" X-IronPort-AV: E=Sophos;i="5.91,287,1647327600"; d="scan'208";a="277363613" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2022 09:21:34 -0700 X-IronPort-AV: E=Sophos;i="5.91,287,1647327600"; d="scan'208";a="585661484" Received: from jeremywe-mobl3.amr.corp.intel.com (HELO [10.209.173.145]) ([10.209.173.145]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2022 09:21:33 -0700 Message-ID: <7652ddab-53a5-ac8e-33f5-d25527acb1a6@linux.intel.com> Date: Thu, 9 Jun 2022 11:21:32 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.9.1 Subject: Re: [PATCH v1 14/16] soundwire: Use acpi_dev_for_each_child() Content-Language: en-US To: "Rafael J. Wysocki" Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Linux PM , Mika Westerberg , "Rafael J. Wysocki" , LKML , Linux ACPI , Vinod Koul , Hans de Goede , Sakari Ailus , Sanyog Kale , Andy Shevchenko , Bard Liao References: <1843211.tdWV9SEqCh@kreacher> <5296779.Sb9uPGUboI@kreacher> <63d7f3ed-b5a9-c869-5d25-a33a1d4e63c8@linux.intel.com> From: Pierre-Louis Bossart In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Shouldn't the return of sdw_acpi_find_one() be trapped, e.g. with >> >> return acpi_dev_for_each_child(parent, sdw_acpi_find_one, bus); > > Sure, I'll do that. Thanks! I also added this EXPORT_SYMBOL to work-around link errors, not sure if this is in your tree already? diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c index 86fa61a21826c..ade6259c19af6 100644 --- a/drivers/acpi/bus.c +++ b/drivers/acpi/bus.c @@ -1113,6 +1113,7 @@ int acpi_dev_for_each_child(struct acpi_device *adev, return device_for_each_child(&adev->dev, &adwc, acpi_dev_for_one_check); } +EXPORT_SYMBOL_GPL(acpi_dev_for_each_child);