Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp664631iol; Thu, 9 Jun 2022 11:12:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxbns03Kccyrwpxj7VyBJH8FUWPgsZvq2PRBnsa5cS5LEsH+n+J+CcOMhAK8UkZqS6GLvJx X-Received: by 2002:aa7:d88a:0:b0:431:32be:f2d4 with SMTP id u10-20020aa7d88a000000b0043132bef2d4mr31659554edq.360.1654798356382; Thu, 09 Jun 2022 11:12:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654798356; cv=none; d=google.com; s=arc-20160816; b=LFXlQepVx1uJyHyilFgLBL6zZQyNTXYWT9jx4+0FaralSiBDEMH+KaHc/DV19BONSD R3pu5N9qUYsEvj0YcCa7QOJm6ThKS66fQByYggkKbwxGmxPLnCuXNNLfxbfRdfF1o+Nc Wzq3Ysm1t8C8sbtuKcCAFQt5Zgp/5WPfkwEQEy0nrWiG29U9COhI6UNuEZGETK91frF/ 5YC7cgDa3K8dKIZIsZQsd6/pIf6GDJToAtTeSNdGqNKS8bFYCV61ALTWUI3kbeyE8JIB iB/iwqcQ6o3i+QoWtl5ETdETF3qrAPR99G+z0ywvKgFkgF2mMtIEZgmtSd4NevBQPOe8 W15A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:robot-unsubscribe :robot-id:message-id:mime-version:references:in-reply-to:cc:subject :to:reply-to:sender:from:dkim-signature:dkim-signature:date; bh=dHielvjeadYHFGOtQOVaGYUxq8bvjP3EnPYD76F6TmU=; b=SorLwbl4/+Pt+UsT7r0rkQ3aJj31XnxQQ9DeE6myDsEKIPqREf/7d9POSjZvf17qPj VmvoT1P1LXbwp65MYlSsSQW9xiBeZaUKSxMDkEkgyyeVLNHO9gIdZm6cxv8W2pttvFeo wq3AnuEvcH6TzC63YUBP1G2EoiN2p+vtNnKdmyYkM4jy3dXsdm7bBe2xloKakRaZp++f 4IaGAW1nLbO+KgWFkiDQKkysNxvf/u991QL9fGWqMDlIRlMHIy7T5e1CSm+uusZutr9T Z+EYNWIAxzIAkwZjOcHGNIs9rTRTz9vW5IsXHYnKMOA+iyoTKvv/g1j1nMjM101fXE+I Aq8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=jI6uonFe; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hw10-20020a170907a0ca00b00711dc46e14asi3202835ejc.584.2022.06.09.11.12.10; Thu, 09 Jun 2022 11:12:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=jI6uonFe; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344857AbiFIQvJ (ORCPT + 99 others); Thu, 9 Jun 2022 12:51:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344675AbiFIQuf (ORCPT ); Thu, 9 Jun 2022 12:50:35 -0400 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D6B16C0C6 for ; Thu, 9 Jun 2022 09:50:31 -0700 (PDT) Date: Thu, 09 Jun 2022 16:50:29 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1654793430; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dHielvjeadYHFGOtQOVaGYUxq8bvjP3EnPYD76F6TmU=; b=jI6uonFeKyqsyvgfnLhgVXBrrGtFANnEChLos7FFqAczLtwOHR13TKWO2xVIgQh+ctyU+s NsaMI2sPstwz7oGTZ0smgQsK7S4qYkcZRr8rZIbQXdk1qxl+SO0OfPnY01zQcOp26/EUfZ 5FOag7rdfbGO3opAgwYQNbfE8gS551JMWwqODiBZapALOj+4nG49J90kUPRtl9pmI75V8h ljbzhmjVJT9xMlLlLqhu+A+Qw8NilgoJMrqOhQv4NqBmO5bCVK3PcsE20Zg5XWOMShM4uq bauFMPQBT1q/pBdcgNR0D87uGC90P9BVWzFhFqdbde74F3qnq8awQ0gJrRkUvw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1654793430; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dHielvjeadYHFGOtQOVaGYUxq8bvjP3EnPYD76F6TmU=; b=sGodCvLZ3gr2mBUAXr4VtKNdrBRJ01vpKsCr2br3aWdpbISgea6f603WiOL3XFuSHM61Te q8B0tpk7hYNZJOBw== From: "irqchip-bot for Miaoqian Lin" Sender: tip-bot2@linutronix.de Reply-to: linux-kernel@vger.kernel.org To: linux-kernel@vger.kernel.org Subject: [irqchip: irq/irqchip-fixes] irqchip/gic/realview: Fix refcount leak in realview_gic_of_init Cc: Miaoqian Lin , Marc Zyngier , tglx@linutronix.de In-Reply-To: <20220601080930.31005-2-linmq006@gmail.com> References: <20220601080930.31005-2-linmq006@gmail.com> MIME-Version: 1.0 Message-ID: <165479342917.4207.8528273657753463802.tip-bot2@tip-bot2> Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following commit has been merged into the irq/irqchip-fixes branch of irqchip: Commit-ID: f4b98e314888cc51486421bcf6d52852452ea48b Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/f4b98e314888cc51486421bcf6d52852452ea48b Author: Miaoqian Lin AuthorDate: Wed, 01 Jun 2022 12:09:25 +04:00 Committer: Marc Zyngier CommitterDate: Thu, 09 Jun 2022 17:36:57 +01:00 irqchip/gic/realview: Fix refcount leak in realview_gic_of_init of_find_matching_node_and_match() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: 82b0a434b436 ("irqchip/gic/realview: Support more RealView DCC variants") Signed-off-by: Miaoqian Lin Signed-off-by: Marc Zyngier Link: https://lore.kernel.org/r/20220601080930.31005-2-linmq006@gmail.com --- drivers/irqchip/irq-gic-realview.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-gic-realview.c b/drivers/irqchip/irq-gic-realview.c index b4c1924..38fab02 100644 --- a/drivers/irqchip/irq-gic-realview.c +++ b/drivers/irqchip/irq-gic-realview.c @@ -57,6 +57,7 @@ realview_gic_of_init(struct device_node *node, struct device_node *parent) /* The PB11MPCore GIC needs to be configured in the syscon */ map = syscon_node_to_regmap(np); + of_node_put(np); if (!IS_ERR(map)) { /* new irq mode with no DCC */ regmap_write(map, REALVIEW_SYS_LOCK_OFFSET,