Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758614AbXEUS75 (ORCPT ); Mon, 21 May 2007 14:59:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756709AbXEUS7u (ORCPT ); Mon, 21 May 2007 14:59:50 -0400 Received: from keetweej.vanheusden.com ([213.84.46.114]:60534 "EHLO keetweej.vanheusden.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756707AbXEUS7t (ORCPT ); Mon, 21 May 2007 14:59:49 -0400 Date: Mon, 21 May 2007 20:59:47 +0200 From: Folkert van Heusden To: Andrea Righi Cc: Jan Engelhardt , Andi Kleen , Stephen Hemminger , Eric Dumazet , Rik van Riel , LKML , linux-mm@kvack.org Subject: Re: signals logged / [RFC] log out-of-virtual-memory events Message-ID: <20070521185947.GF14802@vanheusden.com> References: <464C9D82.60105@redhat.com> <20070520205500.GJ22452@vanheusden.com> <200705202314.57758.ak@suse.de> <46517817.1080208@users.sourceforge.net> <20070521110406.GA14802@vanheusden.com> <20070521124734.GB14802@vanheusden.com> <4651A564.9090509@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4651A564.9090509@users.sourceforge.net> Organization: www.unixexpert.nl X-Chameleon-Return-To: folkert@vanheusden.com X-Xfmail-Return-To: folkert@vanheusden.com X-Phonenumber: +31-6-41278122 X-URL: http://www.vanheusden.com/ X-PGP-KeyID: 1F28D8AE X-GPG-fingerprint: AC89 09CE 41F2 00B4 FCF2 B174 3019 0E8C 1F28 D8AE X-Key: http://pgp.surfnet.nl:11371/pks/lookup?op=get&search=0x1F28D8AE Read-Receipt-To: Reply-By: Tue May 22 12:32:47 CEST 2007 X-Message-Flag: www.vanheusden.com User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1260 Lines: 29 > >>> What about the following enhancement: I check with sig_fatal if it would > >>> kill the process and only then emit a message. So when an application > >>> takes care itself of handling it nothing is printed. > >>> + /* emit some logging for unhandled signals > >>> + */ > >>> + if (sig_fatal(t, sig)) > >> Not unhandled_signal()? > > Can we already use that one in send_signal? As the signal needs to be > > send first I think before we know if it was handled or not? sig_fatal > > checks if the handler is set to default - which is it is not taken care > > of. > What about ptrace()'d processes? I don't think we should log signals for them... Why not? Folkert van Heusden -- MultiTail es una herramienta flexibele para consiguir archivos de log, y para ejecutar ordenes. Filtrar, a?adir colores, merger y vista de las differencias. http://www.vanheusden.com/multitail/ ---------------------------------------------------------------------- Phone: +31-6-41278122, PGP-key: 1F28D8AE, www.vanheusden.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/