Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <165451871967.1941436.17828809503267245815.stgit@warthog.procyon.org.uk>
 <486b1b80-9932-aab6-138d-434c541c934a@digikod.net>
In-Reply-To: <486b1b80-9932-aab6-138d-434c541c934a@digikod.net>
From:   Masahiro Yamada <masahiroy@kernel.org>
Date:   Fri, 10 Jun 2022 03:18:50 +0900
Message-ID: <CAK7LNAR9R3OXzZXUWywR5EJf6n9tRp3QeJuo7UsS3pfDTzOvig@mail.gmail.com>
Subject: Re: [PATCH] certs: Convert spaces in certs/Makefile to a tab
To:     =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= <mic@digikod.net>
Cc:     David Howells <dhowells@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Jarkko Sakkinen <jarkko@kernel.org>, keyrings@vger.kernel.org,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jun 10, 2022 at 2:05 AM Micka=C3=ABl Sala=C3=BCn <mic@digikod.net> =
wrote:
>
>
> On 06/06/2022 14:31, David Howells wrote:
> > There's a rule in certs/Makefile for which the command begins with eigh=
t
> > spaces.  This results in:
> >
> >       ../certs/Makefile:21: FORCE prerequisite is missing
> >       ../certs/Makefile:21: *** missing separator.  Stop.
> >
> > Fix this by turning the spaces into a tab.
>
> These spaces were not part of my patch but they are indeed in this file
> now: https://lore.kernel.org/r/20210712170313.884724-3-mic@digikod.net
>
> Reviewed-by: Micka=C3=ABl Sala=C3=BCn <mic@linux.microsoft.com>


Indeed, you used a tab,
but the applied code (commit addf466389d9) uses 8 spaces.

I think something bad happened
when the committer locally modified the code.


--
Best Regards
Masahiro Yamada