Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 9 Jun 2022 19:44:37 +0200
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Tomer Maimon <tmaimon77@gmail.com>, avifishman70@gmail.com,
        tali.perry1@gmail.com, joel@jms.id.au, venture@google.com,
        yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com,
        sboyd@kernel.org, p.zabel@pengutronix.de,
        gregkh@linuxfoundation.org, daniel.lezcano@linaro.org,
        tglx@linutronix.de, wim@linux-watchdog.org, linux@roeck-us.net,
        catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de,
        olof@lixom.net, jirislaby@kernel.org, shawnguo@kernel.org,
        bjorn.andersson@linaro.org, geert+renesas@glider.be,
        marcel.ziswiler@toradex.com, vkoul@kernel.org,
        biju.das.jz@bp.renesas.com, nobuhiro1.iwamatsu@toshiba.co.jp,
        robert.hancock@calian.com, j.neuschaefer@gmx.net, lkundrak@v3.sk,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-clk@vger.kernel.org, linux-serial@vger.kernel.org,
        linux-watchdog@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 06/20] dt-binding: clk: npcm845: Add binding for
 Nuvoton NPCM8XX Clock
Message-ID: <YqIxhWeUbEAo3Jam@latitude>
References: <20220608095623.22327-1-tmaimon77@gmail.com>
 <20220608095623.22327-7-tmaimon77@gmail.com>
 <f4899b6d-fec3-5940-709a-f5fbc7ae6233@linaro.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="32Ze5EV+vj+4NHJh"
Content-Disposition: inline
In-Reply-To: <f4899b6d-fec3-5940-709a-f5fbc7ae6233@linaro.org>
Precedence: bulk


--32Ze5EV+vj+4NHJh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Tomer and Krzysztof,

On Wed, Jun 08, 2022 at 12:03:00PM +0200, Krzysztof Kozlowski wrote:
> On 08/06/2022 11:56, Tomer Maimon wrote:
> > Add binding for the Arbel BMC NPCM8XX Clock controller.
> >=20
> > Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> > ---
[...]
> > +  clocks:
> > +    items:
> > +      - description: 25M reference clock
> > +      - description: CPU reference clock
> > +      - description: MC reference clock
> > +
> > +  clock-names:
> > +    items:
> > +      - const: refclk
> > +      - const: sysbypck
> > +      - const: mcbypck
> > +
>=20
> I asked what is the suffix about and you replied "ck"... ok, so let's
> make clear. This should be:
>=20
>     items:
>       - const: ref
>       - const: sysbyp
>       - const: mcbyp
>=20
> or something similar, without the same suffix all over.

A bit of a side note on these names:

To make the binding as easy to understand as possible, I think it would
help to have every part of the clock-names reflected in corresponding
clock description:

- sysbypck:  presumably means system bypass clock
- mcbypck:   presumably means memory controller bypass clock


As it currently is in the patch, the "byp" part stays unexplained and
unmentioned in the descriptions.


Thanks,
Jonathan

--32Ze5EV+vj+4NHJh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmKiMWIACgkQCDBEmo7z
X9vEyw//UyXHHGnZqNSCU2vjJVfqb3xYR+6PkcHcT0S8zAQhF+r49qZjx2NHgU7M
UK49lMtTgrU3NtU+6zjY49TDUtBqImQtjshiTi1Ny8pk1EeILBOAtfs37Woh0RT0
/L0z/8MSiYSEiEFwMMQju9y0op3cBs+/7FraPBx/LlZiWvxmKi3U9+dYjKQnlzE6
i33Um6sHshnWKc3GUHRmhZcipbc06kgST4+iTJPGqip9l5p/HusyWfTB3HBHwV48
5oc4+0yPM3RksA2jkfwyPHSv5jaQ+Vli88tZC7NRQYGzVpMhrgjJ6tMszip//wsA
tIaIbAr2KBNOWsirnLya9y2lV/OHkaauS/wqn+WH+oliAu9NA0u4Wly8espADuVu
VeIa3jy1Lm1pYI+UmGJljRKDOWE07KMtwIsQ0XqloLXdYCAlCRLM3sQO6vztUPKl
eaLBbX2Oh2F5WLh9bkKzTg1vDusL/7YkAopmy9nejnayevRhpD1yApfQFAuOJTCO
1qvWxfbgzAMa2Ask0kaW7AIJ3L0KPJhRDVDVBqsGlQ4+gww7qoEeh6tOTGayfpXE
5QpbQzZNrHIpATf4nH+s+fyK9BgXftuoFQQBzi0FyxaIedlegtLymSFCxrhwY74E
5a7VDITbr+qiBNCkuH94zj0onqdpx8/4uWaraM3vvh3xf/z1C3I=
=CY1G
-----END PGP SIGNATURE-----

--32Ze5EV+vj+4NHJh--