Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp718943iol; Thu, 9 Jun 2022 12:25:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxBScBXnHa1gNjoROF8QkDiauWr9Db4HxBGG8NVQC1yyfM1xwcVN7IboCco0pMebzVbNKsE X-Received: by 2002:a17:902:ec82:b0:167:70f6:905e with SMTP id x2-20020a170902ec8200b0016770f6905emr25696140plg.114.1654802712793; Thu, 09 Jun 2022 12:25:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654802712; cv=none; d=google.com; s=arc-20160816; b=uX8HklwiSmI+BQPQqXI30fUAsrOKWvng1rRLMB8ETSfQlWoqm/hQcZm5slWhbuAhPD Iq/uIkCZNjZb8ZrfH3XtL4GSgUrxACmSmhfmAkIqnt5el8U8UM8okp1EYe9/eID3f2YG mFveYQ8cQsCY6d/sX/ld7ovlIiI5huMex5lFE3trCgYLfb68gULXbGqTXCK8t1SWkSX8 AQ6XiqOJBNYYwmFV82Og4QIiqq0AQc0M8ofxq/njaUL3qNoAy/cEUHBJHg0hO02xKdh1 iudEVZbqJ4u5rQCAB6gx6s0gnaEehntUyLoHcd6L5OscdwIA3u77ZM7ssk7oYqlUzM4y nHyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=81mJ5zteH9QajiguCF0ErkVpq5QJpHLN6IVQaINPgsw=; b=xLW81qo7dNKH7RFHKnJPnchfULrn37qknh0m7FB9JjGGygVMHApcMQxQ2+GE8dEmcw Rt7TDtwD+D1FMPzkzw9HxND8cLb6DmYw25SlpG1l5kZg3ARBg2ClXxeBTwaJNqUqaUHT hCX0ymxMc9Ldcv/Ynj6E2nlmp22JrYvDmt8ixqofwf0cB1IcoIX4hDJfBZ+prip03DDQ Fc8eM4deqK7ysYHbZaCjubP+CE7vWxckR24DmK+4ZmeACnYAOz3PEiHFGmXFws3pm16x tdQT2E9kBgesfAB3XxlzSIy9IJLP13HyYvMRku72+kYexmsGgxiCIpm26aNPhCeG/oA7 2EVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x14-20020a170902820e00b0016227beec46si30051212pln.143.2022.06.09.12.25.01; Thu, 09 Jun 2022 12:25:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237419AbiFISQK (ORCPT + 99 others); Thu, 9 Jun 2022 14:16:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232018AbiFISQI (ORCPT ); Thu, 9 Jun 2022 14:16:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4603E2BC4 for ; Thu, 9 Jun 2022 11:16:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D3D99614D9 for ; Thu, 9 Jun 2022 18:16:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7CC4C34114; Thu, 9 Jun 2022 18:16:04 +0000 (UTC) Date: Thu, 9 Jun 2022 19:16:01 +0100 From: Catalin Marinas To: Patrick Wang Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, yee.lee@mediatek.com Subject: Re: [PATCH v3 3/3] mm: kmemleak: check physical address when scan Message-ID: References: <20220609124950.1694394-1-patrick.wang.shcn@gmail.com> <20220609124950.1694394-4-patrick.wang.shcn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220609124950.1694394-4-patrick.wang.shcn@gmail.com> X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 09, 2022 at 08:49:50PM +0800, Patrick Wang wrote: > Check the physical address of objects for its boundary > when scan instead of in kmemleak_*_phys(). > > Fixes: 23c2d497de21 ("mm: kmemleak: take a full lowmem check in kmemleak_*_phys()") > Suggested-by: Catalin Marinas > Signed-off-by: Patrick Wang Reviewed-by: Catalin Marinas The fixed commit above was cc stable, so we'll probably need all these three patches in stable. But I'd keep them a bit in -next for testing first (and I see Andrew already picked them up; we might as well merge them in 5.20 and send them to -stable after, it's not some critical feature). Thanks for the series. I don't think you need to respin unless others of comments. -- Catalin