Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220607033122.256388-1-kunyu@nfschina.com>
In-Reply-To: <20220607033122.256388-1-kunyu@nfschina.com>
From:   Andrey Konovalov <andreyknvl@gmail.com>
Date:   Thu, 9 Jun 2022 20:29:20 +0200
Message-ID: <CA+fCnZd-JS2tdojpNigt9brcH=ZX78Pe3AB-wwc8o+3UNnGuJQ@mail.gmail.com>
Subject: Re: [PATCH] arm: create_mapping function to remove unused return values
To:     Li kunyu <kunyu@nfschina.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>
Cc:     Andrey Ryabinin <ryabinin.a.a@gmail.com>,
        Alexander Potapenko <glider@google.com>,
        Dmitry Vyukov <dvyukov@google.com>,
        Vincenzo Frascino <vincenzo.frascino@arm.com>,
        linux@armlinux.org.uk, kasan-dev <kasan-dev@googlegroups.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jun 7, 2022 at 5:31 AM Li kunyu <kunyu@nfschina.com> wrote:
>
> Change the return value to void to reduce eax register execution.
>
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
> ---
>  arch/arm/mm/kasan_init.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/mm/kasan_init.c b/arch/arm/mm/kasan_init.c
> index 5ad0d6c56d56..db2068329985 100644
> --- a/arch/arm/mm/kasan_init.c
> +++ b/arch/arm/mm/kasan_init.c
> @@ -187,7 +187,7 @@ static void __init clear_pgds(unsigned long start,
>                 pmd_clear(pmd_off_k(start));
>  }
>
> -static int __init create_mapping(void *start, void *end)
> +static void __init create_mapping(void *start, void *end)
>  {
>         void *shadow_start, *shadow_end;
>
> @@ -199,7 +199,6 @@ static int __init create_mapping(void *start, void *end)
>
>         kasan_pgd_populate((unsigned long)shadow_start & PAGE_MASK,
>                            PAGE_ALIGN((unsigned long)shadow_end), false);
> -       return 0;
>  }
>
>  void __init kasan_init(void)
> --
> 2.18.2

Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>