Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp733790iol; Thu, 9 Jun 2022 12:49:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJytRE+DiWU3rUsxh2XDT94TMrv2epg/i8Tam8O3GVF1PkHznM9foGmxjwSfWzaKlEElNOVM X-Received: by 2002:a17:902:7886:b0:167:5c8c:4d3e with SMTP id q6-20020a170902788600b001675c8c4d3emr30470696pll.74.1654804148239; Thu, 09 Jun 2022 12:49:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654804148; cv=none; d=google.com; s=arc-20160816; b=sTAWbMOcE/ZqWPr83k3jlpDNLyQdraD0zbhhd6bOGOm4ynmjDmcIPq+/RJ56sgZnlO r6I/h/K5agjwS8DDHrRUN0qzg+BZwrwHI1odqq2TjJ1hlMyjJuagDfUdew0+N0X5SJnc U8Qa1azj6jy9jCdDkkaACBRB0rHpVZK/rwQZhaX5yD57Tb5RsXIK1XDKVUmcl9dU9zB1 5kY5Vh5uicMSKSfDT44n7iEeto0XM6SWwDRPMTeu7jSKWBS47J1oIRv/YZqELusplRBH vhU8Fy7PCP9Gu9fywLJMz7meei2QGSQZ7eDiNhTicxMqa/S6woXDJKASbKE+b5uUtZA7 SJmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=hfXKkX/XGWqqzEHfEw8tUgBVb2Z/VZk77c56HOh7cXQ=; b=lLAsWRl8Bfn+VLMBe7sP1xPD9roHmmu0N4cLnx/CiSXgSUgmDIwotBOJq4El9D8xa/ dSSXzui7hBPk6bqP9jDbidewgFmxWSYECGz/vh7Si1n/TtFF3PE3q9k6CAATO2lsJ1Sa 8d9xL5yaX6QYFlULLMn6Cx9ingIy2SBWgI7mPibCmEOoUejQIcPao2h/7V3xi+syYnSb P8jzdeIbAsLdBJFe1fz1/aSPkp5mngfssJ0bkL5Sm2EVcUzDMAsqrq4yP+nUNnnkvoxW xhvwYFnnPd0h5pJjuj55rQ4qm4KvLlL83UTu6vMAlg1hFNBYvyR8Lm8if1maZdib/Y8h FfGQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="F05Oe/n/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j20-20020a63fc14000000b003f60333a5dcsi31047308pgi.560.2022.06.09.12.48.53; Thu, 09 Jun 2022 12:49:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="F05Oe/n/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234501AbiFITId (ORCPT + 99 others); Thu, 9 Jun 2022 15:08:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231907AbiFITIb (ORCPT ); Thu, 9 Jun 2022 15:08:31 -0400 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DD14C26CE49; Thu, 9 Jun 2022 12:08:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654801710; x=1686337710; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=c38Un+y998cp1mk//MudRgxdikF4s6RsjatPEg81vl0=; b=F05Oe/n/LDmEbUvDAFeOAiOuCAhMxvF7TtNLkWTaRXL0DC8KVnhNUgNl VDr1S9CYE1GcG1w5Gk/Lwun1CCPeKxbTnEY2BHnf8fre3mxtXYX4CBgRl eiF6eg3h4pYxhVSZ59S23mLYMA6Fj+U6Mvw5ITc05mpsgocZxh3he4oPC guVJt9rRMgZ5JpLkQFsg8XeVJyGgGzTfBCxTRtwTs4iaeeTRDDnNiXrbS Izag7k/RYuJLeB0SPKqpubeAs+tNZAjTsqRstCgw9u6U5MBiWYpCdh+9m MXFp5aVN/a+pjHk/dmhAnFoSvSeNjKW0ZBGSTwb5fglEiue7XtzQS7MFu A==; X-IronPort-AV: E=McAfee;i="6400,9594,10373"; a="278533566" X-IronPort-AV: E=Sophos;i="5.91,287,1647327600"; d="scan'208";a="278533566" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2022 12:08:14 -0700 X-IronPort-AV: E=Sophos;i="5.91,287,1647327600"; d="scan'208";a="585751984" Received: from jeremywe-mobl3.amr.corp.intel.com (HELO [10.209.173.145]) ([10.209.173.145]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2022 12:08:12 -0700 Message-ID: Date: Thu, 9 Jun 2022 14:08:11 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.9.1 Subject: Re: [PATCH v1 14/16] soundwire: Use acpi_dev_for_each_child() Content-Language: en-US To: "Rafael J. Wysocki" Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Linux PM , Bard Liao , "Rafael J. Wysocki" , LKML , Linux ACPI , Vinod Koul , Hans de Goede , Sakari Ailus , Sanyog Kale , Andy Shevchenko , Mika Westerberg References: <1843211.tdWV9SEqCh@kreacher> <5296779.Sb9uPGUboI@kreacher> <63d7f3ed-b5a9-c869-5d25-a33a1d4e63c8@linux.intel.com> <7652ddab-53a5-ac8e-33f5-d25527acb1a6@linux.intel.com> From: Pierre-Louis Bossart In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/9/22 12:35, Rafael J. Wysocki wrote: > On Thu, Jun 9, 2022 at 6:21 PM Pierre-Louis Bossart > wrote: >> >> >>>> Shouldn't the return of sdw_acpi_find_one() be trapped, e.g. with >>>> >>>> return acpi_dev_for_each_child(parent, sdw_acpi_find_one, bus); >>> >>> Sure, I'll do that. Thanks! >> >> I also added this EXPORT_SYMBOL to work-around link errors, not sure if >> this is in your tree already? > > One of the previous patches in the series is adding the export. ok. I ran a bunch of tests with those two changes, so feel free to take my tags: Reviewed-by: Pierre-Louis Bossart Tested-by: Pierre-Louis Bossart