Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 9 Jun 2022 21:30:35 +0200
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next] power: supply: Remove unnecessary print function
 dev_err()
Message-ID: <20220609193035.ojzsan6baoqmlaep@mercury.elektranox.org>
References: <20220504135214.28901-1-yang.lee@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="iej2of25yg6hskqe"
Content-Disposition: inline
In-Reply-To: <20220504135214.28901-1-yang.lee@linux.alibaba.com>
Precedence: bulk


--iej2of25yg6hskqe
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Wed, May 04, 2022 at 09:52:14PM +0800, Yang Li wrote:
> The print function dev_err() is redundant because
> platform_get_irq() already prints an error.
>=20
> Eliminate the follow coccicheck warning:
> ./drivers/power/supply/goldfish_battery.c:225:2-9: line 225 is
> redundant because platform_get_irq() already prints an error
>=20
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/goldfish_battery.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>=20
> diff --git a/drivers/power/supply/goldfish_battery.c b/drivers/power/supp=
ly/goldfish_battery.c
> index bf1754355c9f..a58d713d75ce 100644
> --- a/drivers/power/supply/goldfish_battery.c
> +++ b/drivers/power/supply/goldfish_battery.c
> @@ -221,10 +221,8 @@ static int goldfish_battery_probe(struct platform_de=
vice *pdev)
>  	}
> =20
>  	data->irq =3D platform_get_irq(pdev, 0);
> -	if (data->irq < 0) {
> -		dev_err(&pdev->dev, "platform_get_irq failed\n");
> +	if (data->irq < 0)
>  		return -ENODEV;
> -	}
> =20
>  	ret =3D devm_request_irq(&pdev->dev, data->irq,
>  			       goldfish_battery_interrupt,
> --=20
> 2.20.1.7.g153144c
>=20

--iej2of25yg6hskqe
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmKiSlsACgkQ2O7X88g7
+poP4g/+IBTPFMPxsgqiE8ymMfqh70gGwXufuI8Dz3MEpNSCgZZ1ZE7mEjaHiPiY
FqMuMDF170op04EUU68iOOhAm4Lhrzgen+2u8/oTpKFy4AFrGWwnRoMVwlRkwz9j
/3AYuKIu3XOTv83xijOZapgbvg9nNXnEOm8Vky2k48ZKnjM7XpoVN6eLbU7ld5I1
LUu5EIu7F4cMT7d8bT5ZgTkJtxjoHGEFNOlLMkCW6gEY1yspS20Ngri2U/tzWpG0
ZqYsbr8UZPVTX6MgKmr/YWCkU0FvM5kLJIdrZ667o7pP7DTjK1TQNAujAxZXomkH
b514/ZTkIBHTlLmSTbOt+PXYHiO+b0zUUEAE2gwR+hMmQZWj/Q+44ugIVuKl8JM7
mmLH3YIgtdyUzCZu7OxDcqtd+Q+JouzQANh8wj/CGXzUwcHBuSdwBovWIsJ6AC6e
Nq3vjBO86d0+cLHM/gVKruSaW1rUwEsCe1yWXSvXPZu9HSak/KWIuhCOYoHEe+CB
OFt6IwhPyZdvomqSM1xol4KzZn1LfT2Jz12W7fRG+r/utEjtYx3sdHfsVOpZ46q6
i9V4qq8FEdbBr/0ALv6LvEjnBjRFiGtiIQx4vFkdGcYwhKQihNuaX1sxM0AoEllo
um6PvdGToDppnA3V89JCQB0csNZdFHqxJIjUqBsBiW+JxmOaFiA=
=/SEh
-----END PGP SIGNATURE-----

--iej2of25yg6hskqe--