Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] selftests/vm: Add protection_keys tests to run_vmtests
To:     Kalpana Shetty <kalpana.shetty@amd.com>, akpm@linux-foundation.org,
        shuah@kernel.org, linux-mm@kvack.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20220531102556.388-1-kalpana.shetty@amd.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <4b0aab3f-83f4-80f7-6df0-447561f0da88@linuxfoundation.org>
Date:   Thu, 9 Jun 2022 14:21:20 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20220531102556.388-1-kalpana.shetty@amd.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 5/31/22 4:25 AM, Kalpana Shetty wrote:
> Signed-off-by: Kalpana Shetty <kalpana.shetty@amd.com>

Missing commit log - please add a detailed commit log explaining why
this change is necessary.

> ---
>   tools/testing/selftests/vm/run_vmtests.sh | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/vm/run_vmtests.sh
> index 41fce8bea929..54a0c28f810c 100755
> --- a/tools/testing/selftests/vm/run_vmtests.sh
> +++ b/tools/testing/selftests/vm/run_vmtests.sh
> @@ -179,4 +179,11 @@ run_test ./ksm_tests -N -m 1
>   # KSM test with 2 NUMA nodes and merge_across_nodes = 0
>   run_test ./ksm_tests -N -m 0
>   
> +# protection_keys tests
> +if [ $VADDR64 -eq 0 ]; then
> +	run_test ./protection_keys_32
> +else
> +	run_test ./protection_keys_64
> +fi
> +
>   exit $exitcode
> 

thanks,
-- Shuah