Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 9 Jun 2022 19:48:39 +0000
From:   Sean Christopherson <seanjc@google.com>
To:     Andrew Jones <drjones@redhat.com>
Cc:     Marc Zyngier <maz@kernel.org>, Paolo Bonzini <pbonzini@redhat.com>,
        kvm@vger.kernel.org, Vitaly Kuznetsov <vkuznets@redhat.com>,
        David Matlack <dmatlack@google.com>,
        Ben Gardon <bgardon@google.com>,
        Oliver Upton <oupton@google.com>, linux-kernel@vger.kernel.org,
        anup@brainfault.org, Raghavendra Rao Ananta <rananta@google.com>,
        eric.auger@redhat.com
Subject: Re: [PATCH v2 000/144] KVM: selftests: Overhaul APIs, purge VCPU_ID
Message-ID: <YqJOlysCQLGSrt7h@google.com>
References: <20220603004331.1523888-1-seanjc@google.com>
 <21570ac1-e684-7983-be00-ba8b3f43a9ee@redhat.com>
 <93b87b7b5a599c1dfa47ee025f0ae9c4@kernel.org>
 <YqEupumS/m5IArTj@google.com>
 <20220609074027.fntbvcgac4nroy35@gator>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220609074027.fntbvcgac4nroy35@gator>
Precedence: bulk

On Thu, Jun 09, 2022, Andrew Jones wrote:
> On Wed, Jun 08, 2022 at 11:20:06PM +0000, Sean Christopherson wrote:
> > On Wed, Jun 08, 2022, Marc Zyngier wrote:
> > > On 2022-06-07 16:27, Paolo Bonzini wrote:
> > > > Marc, Christian, Anup, can you please give this a go?
> > > 
> > > Can you please, pretty please, once and for all, kill that alias you
> > > seem to have for me and  email me on an address I actually can read?
> > > 
> > > I can't remember how many times you emailed me on my ex @arm.com address
> > > over the past 2+years...
> > > 
> > > The same thing probably applies to Sean, btw.
> > 
> > Ha!  I was wondering how my old @intel address snuck in...
> > 
> > On the aarch64 side, with the following tweaks, courtesy of Raghu, all tests
> > pass.  I'll work these into the next version, and hopefully also learn how to
> > run on aarch64 myself...
> > 
> > Note, the i => 0 "fix" in test_v3_typer_accesses() is a direct revert of patch 3,
> > "KVM: selftests: Fix typo in vgic_init test".  I'll just drop that patch unless
> > someone figures out why doing the right thing causes the test to fail.
> 
> CCing Eric for that one.

> > @@ -424,7 +424,7 @@ static void test_v3_typer_accesses(void)
> >                             KVM_DEV_ARM_VGIC_CTRL_INIT, NULL);
> > 
> >         for (i = 0; i < NR_VCPUS ; i++) {
> > -               ret = v3_redist_reg_get(v.gic_fd, i, GICR_TYPER, &val);
> > +               ret = v3_redist_reg_get(v.gic_fd, 0, GICR_TYPER, &val);
> >                 TEST_ASSERT(!ret && !val, "read GICR_TYPER before rdist region setting");

Figured it out, "val" should be "i * 0x100", not "0".  The asserts in this test
are awful and don't print the actual "val".  test_assert() shares part of the blame
for printing a stale errno, but holy moly this test makes it painful to debug
trivial issues.