Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765476AbXEUTV5 (ORCPT ); Mon, 21 May 2007 15:21:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1764988AbXEUTVJ (ORCPT ); Mon, 21 May 2007 15:21:09 -0400 Received: from 216-99-217-87.dsl.aracnet.com ([216.99.217.87]:46203 "EHLO sous-sol.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764253AbXEUTVC (ORCPT ); Mon, 21 May 2007 15:21:02 -0400 Message-Id: <20070521191739.274076000@sous-sol.org> References: <20070521191612.800400000@sous-sol.org> User-Agent: quilt/0.46-1 Date: Mon, 21 May 2007 12:16:54 -0700 From: Chris Wright To: linux-kernel@vger.kernel.org, stable@kernel.org, James.Bottomley@steeleye.com Cc: Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , Chuck Ebbert , torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Eric.Moore@lsil.com, linux-scsi@vger.kernel.org, doug.chapman@hp.com Subject: [patch 42/69] fix for bugzilla 8426: massive slowdown on SCSI CD/DVD drive connected to mptspi driver Content-Disposition: inline; filename=fix-for-bugzilla-8426-massive-slowdown-on-scsi-cd-dvd-drive-connected-to-mptspi-driver.patch Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1722 Lines: 50 -stable review patch. If anyone has any objections, please let us know. --------------------- From: Doug Chapman Patch for: http://bugzilla.kernel.org/show_bug.cgi?id=8426 A recent code cleanup that moved code from mptscsih to mptspi inadvertently change the order some code was called. This caused a massive slowdown (of 150x to 300x) on the CD/DVD drive on the high-end HP Integrity servers. Signed-off-by: Doug Chapman Cc: Cc: James Bottomley Signed-off-by: Andrew Morton Signed-off-by: Chris Wright --- [chrisw: Why is this not upstream yet?] drivers/message/fusion/mptspi.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) --- linux-2.6.21.1.orig/drivers/message/fusion/mptspi.c +++ linux-2.6.21.1/drivers/message/fusion/mptspi.c @@ -726,13 +726,15 @@ static int mptspi_slave_configure(struct struct _MPT_SCSI_HOST *hd = (struct _MPT_SCSI_HOST *)sdev->host->hostdata; VirtTarget *vtarget = scsi_target(sdev)->hostdata; - int ret = mptscsih_slave_configure(sdev); + int ret; + + mptspi_initTarget(hd, vtarget, sdev); + + ret = mptscsih_slave_configure(sdev); if (ret) return ret; - mptspi_initTarget(hd, vtarget, sdev); - ddvprintk((MYIOC_s_INFO_FMT "id=%d min_period=0x%02x" " max_offset=0x%02x max_width=%d\n", hd->ioc->name, sdev->id, spi_min_period(scsi_target(sdev)), -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/