Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 10 Jun 2022 00:22:39 +0200
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Zheng Bin <zhengbin13@huawei.com>
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        gaochao49@huawei.com, Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH -next] power: supply: ab8500: add missing
 destroy_workqueue in ab8500_charger_bind
Message-ID: <20220609222239.5fssqczkdqy4inoz@mercury.elektranox.org>
References: <20220512093844.1109923-1-zhengbin13@huawei.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="njbu6seuv6gscm5c"
Content-Disposition: inline
In-Reply-To: <20220512093844.1109923-1-zhengbin13@huawei.com>
Precedence: bulk


--njbu6seuv6gscm5c
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Thu, May 12, 2022 at 05:38:44PM +0800, Zheng Bin wrote:
> ab8500_charger_bind misses destroy_workqueue in error path,
> this patch fixes that.
>=20
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> ---

LGTM, but adding Linus to Cc and waiting a bit to give him time to
react.

-- Sebastian

>  drivers/power/supply/ab8500_charger.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply=
/ab8500_charger.c
> index d04d087caa50..a5d055a628e7 100644
> --- a/drivers/power/supply/ab8500_charger.c
> +++ b/drivers/power/supply/ab8500_charger.c
> @@ -3378,6 +3378,7 @@ static int ab8500_charger_bind(struct device *dev)
>  	ret =3D component_bind_all(dev, di);
>  	if (ret) {
>  		dev_err(dev, "can't bind component devices\n");
> +		destroy_workqueue(di->charger_wq);
>  		return ret;
>  	}
>=20
> --
> 2.31.1
>=20

--njbu6seuv6gscm5c
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmKicq4ACgkQ2O7X88g7
+poAkg//Z0Z4+2U4rbm82Kb9faRGI41hH9iWXmcaQPtxIL/7eT5sv/15vghXtfua
Oy5Ubsepr22BDo/RPt5HRget2ByyMPzp8YCY6/n2L4sOgOFPGAeksInKhPHvEUA8
b8RfjOC8zivfuo+OcseOErHD1KK3vNoY8oL/wLdnhPwedQGQchG6tAEvJAp20FL/
C21L/27qmW4vVJ0CDiAlvxZ+3w3uXI4lCrnlpQ8Aq5Jo6RSOOPtCW11AEPWNVI7f
uVC/YiSyAihR6FFaMg6QQvJ7mwrC6fnfmm0e+fecwDcalpR+0smK19ScfY1QIOOr
jqGdtX8071LVsav/0ddk07VSc69DztcSUZvChpMDrfh8kE7oCVixGrqzQS9ONeVx
bwpo3HJpk7jYDSB0JXcV+//BIk1OikDCYgnB+Zl30GZIJsq9Q3qL7X4/spf6fsLA
ifA2atSwDXlhgHdX0P7c0a8jsCba70stxUkJa7I9rwVQffGTrGDZwzwwOKYq2aL9
e3fHH4qHD2GcOABJAblAXFI2ncuq/VHCLYVskPdFjRNQpbM8Tw7a5UrJR/D0FNj4
phCGzljQZtSvrHWwQv56g/qyFtHBm/DvngGbhZk+ZvvVUarhgio4g2KuOoI2lsiS
/k0pLNaKZUYDvmBhhz8GYzdPF0vXGhVSArX7wv7qRMNpvTgJvd8=
=sJbO
-----END PGP SIGNATURE-----

--njbu6seuv6gscm5c--