Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] selftests: make use of GUP_TEST_FILE macro
To:     Joel Savitz <jsavitz@redhat.com>, linux-kernel@vger.kernel.org
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Shuah Khan <shuah@kernel.org>, linux-mm@kvack.org,
        linux-kselftest@vger.kernel.org, Nico Pache <npache@redhat.com>,
        Shuah Khan <skhan@linuxfoundation.org>
References: <20220609203217.3206247-1-jsavitz@redhat.com>
From:   Shuah Khan <skhan@linuxfoundation.org>
Message-ID: <cd8ca757-b041-cc3b-75af-eef20df65019@linuxfoundation.org>
Date:   Thu, 9 Jun 2022 15:12:51 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20220609203217.3206247-1-jsavitz@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/9/22 2:32 PM, Joel Savitz wrote:
> Commit 17de1e559cf1 ("selftests: clarify common error when running
> gup_test") had most of its hunks dropped due to a conflict with another
> patch accepted into Linux around the same time that implemented the same
> behavior as a subset of other changes.
> 
> However, the remaining hunk defines the GUP_TEST_FILE macro without
> making use of it. This patch makes use of the macro in the two relevant
> places.
> 
> Furthermore, the above mentioned commit's log message erroneously describes
> the changes that were dropped from the patch.
> 
> This patch corrects the record.
> 
> Fixes: 17de1e559cf1 ("selftests: clarify common error when running gup_test")
> 
> Signed-off-by: Joel Savitz <jsavitz@redhat.com>
> ---
>   tools/testing/selftests/vm/gup_test.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/vm/gup_test.c b/tools/testing/selftests/vm/gup_test.c
> index 6bb36ca71cb5..a309876d832f 100644
> --- a/tools/testing/selftests/vm/gup_test.c
> +++ b/tools/testing/selftests/vm/gup_test.c
> @@ -209,7 +209,7 @@ int main(int argc, char **argv)
>   	if (write)
>   		gup.gup_flags |= FOLL_WRITE;
>   
> -	gup_fd = open("/sys/kernel/debug/gup_test", O_RDWR);
> +	gup_fd = open(GUP_TEST_FILE, O_RDWR);
>   	if (gup_fd == -1) {
>   		switch (errno) {
>   		case EACCES:
> @@ -224,7 +224,7 @@ int main(int argc, char **argv)
>   			printf("check if CONFIG_GUP_TEST is enabled in kernel config\n");
>   			break;
>   		default:
> -			perror("failed to open /sys/kernel/debug/gup_test");
> +			perror("failed to open " GUP_TEST_FILE);
>   			break;
>   		}
>   		exit(KSFT_SKIP);
> 

Thank you for finding and fixing the problem.

Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>

thanks,
-- Shuah