Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 9 Jun 2022 23:52:36 +0200
From:   Sebastian Reichel <sebastian.reichel@collabora.com>
To:     Stephen Kitt <steve@sk2.org>
Cc:     Thierry Reding <thierry.reding@gmail.com>,
        Sam Ravnborg <sam@ravnborg.org>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, linux-kernel@vger.kernel.org,
        dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm/panel: panel-dsi-cm: Use backlight helpers
Message-ID: <20220609215236.ojxw6l2vkf652hgu@mercury.elektranox.org>
References: <20220607182026.1121992-1-steve@sk2.org>
 <20220607182026.1121992-3-steve@sk2.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="uo2obknpz3hrt7sr"
Content-Disposition: inline
In-Reply-To: <20220607182026.1121992-3-steve@sk2.org>
Precedence: bulk


--uo2obknpz3hrt7sr
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Tue, Jun 07, 2022 at 08:20:25PM +0200, Stephen Kitt wrote:
> Instead of retrieving the backlight brightness in struct
> backlight_properties manually, and then checking whether the backlight
> should be on at all, use backlight_get_brightness() which does all
> this and insulates this from future changes.
>=20
> Instead of setting the power state by manually updating fields in
> struct backlight_properties, use backlight_enable() and
> backlight_disable(). These also call backlight_update_status() so the
> separate call is no longer needed.
>=20
> Signed-off-by: Stephen Kitt <steve@sk2.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> ---
>
>  drivers/gpu/drm/panel/panel-dsi-cm.c | 24 ++++--------------------
>  1 file changed, 4 insertions(+), 20 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/panel/panel-dsi-cm.c b/drivers/gpu/drm/panel=
/panel-dsi-cm.c
> index b58cb064975f..aa36dc6cedd3 100644
> --- a/drivers/gpu/drm/panel/panel-dsi-cm.c
> +++ b/drivers/gpu/drm/panel/panel-dsi-cm.c
> @@ -86,16 +86,10 @@ static void dsicm_bl_power(struct panel_drv_data *dda=
ta, bool enable)
>  		return;
> =20
>  	if (enable) {
> -		backlight->props.fb_blank =3D FB_BLANK_UNBLANK;
> -		backlight->props.state =3D ~(BL_CORE_FBBLANK | BL_CORE_SUSPENDED);
> -		backlight->props.power =3D FB_BLANK_UNBLANK;
> +		backlight_enable(backlight);
>  	} else {
> -		backlight->props.fb_blank =3D FB_BLANK_NORMAL;
> -		backlight->props.power =3D FB_BLANK_POWERDOWN;
> -		backlight->props.state |=3D BL_CORE_FBBLANK | BL_CORE_SUSPENDED;
> +		backlight_disable(backlight);
>  	}

The brackets can be removed now. Otherwise:

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>

-- Sebastian

> -
> -	backlight_update_status(backlight);
>  }
> =20
>  static void hw_guard_start(struct panel_drv_data *ddata, int guard_msec)
> @@ -196,13 +190,7 @@ static int dsicm_bl_update_status(struct backlight_d=
evice *dev)
>  {
>  	struct panel_drv_data *ddata =3D dev_get_drvdata(&dev->dev);
>  	int r =3D 0;
> -	int level;
> -
> -	if (dev->props.fb_blank =3D=3D FB_BLANK_UNBLANK &&
> -			dev->props.power =3D=3D FB_BLANK_UNBLANK)
> -		level =3D dev->props.brightness;
> -	else
> -		level =3D 0;
> +	int level =3D backlight_get_brightness(dev);
> =20
>  	dev_dbg(&ddata->dsi->dev, "update brightness to %d\n", level);
> =20
> @@ -219,11 +207,7 @@ static int dsicm_bl_update_status(struct backlight_d=
evice *dev)
> =20
>  static int dsicm_bl_get_intensity(struct backlight_device *dev)
>  {
> -	if (dev->props.fb_blank =3D=3D FB_BLANK_UNBLANK &&
> -			dev->props.power =3D=3D FB_BLANK_UNBLANK)
> -		return dev->props.brightness;
> -
> -	return 0;
> +	return backlight_get_brightness(dev);
>  }
> =20
>  static const struct backlight_ops dsicm_bl_ops =3D {
> --=20
> 2.30.2
>=20

--uo2obknpz3hrt7sr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmKia6EACgkQ2O7X88g7
+pqSsA//QktD/WmlqL+qcD6FFq2qNMPgubTfREKR6uh6HfXyJLAvv6K3Qhht/wTW
xWvLwhARTKO9OwFHXY+qImmvsOSjLGV/lPaoaRP4/w5N7JATjTk2G5bucG//L6zu
agCIuQI/3PddHhToi+3zH+B+A9Iggy0AkfyHvhvYXxVuOJJ+fzKvPPTyvILWFZ/8
mGWZS0vHxEXWI9NUdAYjyuvcfavXFTYrSgIGqd6lPYUNEor37UkbfFeHG62lDB66
Cun0Dy0djURBet71rjQ2+wSc7w8s3ofNXw5ow33RXnmQHCYTqvI4rC3us5C3z4ZC
WO16JLeEfGVVg+kQhZ85GQvmSh2KK+hBfpb9WwxMyM5WjM+LFGq/MrF0wUSMcmY/
SU3f5Df1XOGp2yiajZrcoSuKsILvbF2BADsyZxDGaffB71rAUFzpnHfpJlPFPQMI
S+rhVSRW6Iybi0Wsfd2mDMdJkTUsM/sKaIP9Q5Mi3sRyp2GzLdcoKRwfSjkW8F7t
RtCvmD3sjO8ZEOR+I7UshqcMIKGm7DGpxdz3bAUcCQF4cAT9AF4zhSGPNTECeymM
tsibg0WrOE7/jzFmIV0qmUaL0mEvmxomVK5f/upnGVLUwgOsD3LOxONn/jGmjz6e
w33u0FvLLrZNmCQ6prDhQlu2rAcoNbIDLUIvbuyhHAbzYuRbl+k=
=akAV
-----END PGP SIGNATURE-----

--uo2obknpz3hrt7sr--