Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp869117iol; Thu, 9 Jun 2022 16:16:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsmNNXZ+N/MdqLWFpkrlcovo6Ad8pj18cgtm4TKc5MWxLNooAxS6vtkm1+zcbIoYO6mY3l X-Received: by 2002:a05:6a00:22cf:b0:51c:11c2:4bb with SMTP id f15-20020a056a0022cf00b0051c11c204bbmr25351912pfj.54.1654816581974; Thu, 09 Jun 2022 16:16:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654816581; cv=none; d=google.com; s=arc-20160816; b=LoadqJovFh27GuxvJFC8QmOK/YVzYvaUTz5M/FDkjpgIOPsAP+trwWBJ+NIXXf/8xJ 69hkK1tJpi2Blg6D3c1Ucxn5UZrfjqBmJwUtIfb9OXWW6Ur5zzkrKGVYxICY6Vozewje sh3+/82GQhkvFdA3fTSqd/R/V5z5zNWWAwoVAy8cAS+j/zolLFCYpG/5CrhFYFIGMWEH JrtoUbaRgsemkGWgbgQsTKUBBl7ca8mF678AJyMyngcBLTVZNQded8rtOp8hRJEvdCZv OJbcAulRKg/8Nr5gT/06EHesSbNQNTrKZElFu0ripxs8XM9GL1h22MLpXVPoTvX8cOnv 6txw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=bBsPEcUFbFv81V3oV5anqbzGLT4QmzqsPNjaMxe+zKA=; b=bECsZ2oK8a5Uzhua/IKLueBAnhcEpMcXbz8gnA6ap+KVtCuRQMx0X3EUlPwNXWMRaV ozecjy0uhecRKbQOml5xbKY2fbIm3wuL9M95bB9E0E304BzSnirFsARjCetm2LwHotmf B85eTFOGj9IdXC7Aki0Y7TFM5LVL5c21ADuZ1vqX6m4uA7RflR3uS0V+2dECkuZZDYm9 JIZL3L4VjB72JA5XTmhCBE7Fl7ysBfjouav5aQAgJNLeFka92t0eisTLPP/pNZQTyIp/ YZnF04xVIG7vfLuOBP16TI7aJxu+O4rRDdvR57CkMjq9QFxruQE0IhopPIc0mOFTxBxB rorA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=v1isGaFZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 142-20020a630094000000b003fcda8035e6si29186266pga.263.2022.06.09.16.16.09; Thu, 09 Jun 2022 16:16:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=v1isGaFZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345740AbiFIWZf (ORCPT + 99 others); Thu, 9 Jun 2022 18:25:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235078AbiFIWZe (ORCPT ); Thu, 9 Jun 2022 18:25:34 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85C52262AD2; Thu, 9 Jun 2022 15:25:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 45D63B83046; Thu, 9 Jun 2022 22:25:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9ABFC34114; Thu, 9 Jun 2022 22:25:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1654813530; bh=8DPG20VCczCvHexMZwkQ1zY5Py8+AevTKqQ6qMOe6VU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=v1isGaFZcOTd3hQSFwhJjKIptScdtzZdYTbChS0lD05tHMRSy7BT4ZgRXBgnC0WDM KgLV/3LJHT5eYoc434PB9zA81twQJVarz5OWwe6dzijmGQzObvdi2M2MX6KmWex0Ff UOZ65DWa7jodmuE8mcxI6Xnz3KDxzgQuDp9E63LI= Date: Thu, 9 Jun 2022 15:25:27 -0700 From: Andrew Morton To: Bill Wendling Cc: isanbard@gmail.com, Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Ross Philipson , Daniel Kiper , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev Subject: Re: [PATCH 00/12] Clang -Wformat warning fixes Message-Id: <20220609152527.4ad7862d4126e276e6f76315@linux-foundation.org> In-Reply-To: <20220609221702.347522-1-morbo@google.com> References: <20220609221702.347522-1-morbo@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 9 Jun 2022 22:16:19 +0000 Bill Wendling wrote: > This patch set fixes some clang warnings when -Wformat is enabled. > tldr: - printk(msg); + printk("%s", msg); the only reason to make this change is where `msg' could contain a `%'. Generally, it came from userspace. Otherwise these changes are a useless consumer of runtime resources. I think it would be better to quieten clang in some fashion.