Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 9 Jun 2022 21:04:34 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Alex Williamson <alex.williamson@redhat.com>
Cc:     kwankhede@nvidia.com, farman@linux.ibm.com, mjrosato@linux.ibm.com,
        pasic@linux.ibm.com, diana.craciun@oss.nxp.com, cohuck@redhat.com,
        eric.auger@redhat.com, kvm@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-s390@vger.kernel.org, yishaih@nvidia.com, hch@lst.de
Subject: Re: [PATCH] vfio: de-extern-ify function prototypes
Message-ID: <20220610000434.GE1343366@nvidia.com>
References: <165471414407.203056.474032786990662279.stgit@omen>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <165471414407.203056.474032786990662279.stgit@omen>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?fbatCssn4GawTpeCIlXO4P+V9btiSQaWnecQzFFkF7ZXBJe73V5uPx2dOk2q?=
 =?us-ascii?Q?NKG5XCeoIc7wSxUG2gwmn5xpOmHMfWVP70gFSFNW7FcfWKoiBlC99HFBO+kd?=
 =?us-ascii?Q?ccp8CrcBTGgBcpZa7uggl9XTfwWQMFw2t57mvxmx1C4LpTXpRhvObW4VM3WO?=
 =?us-ascii?Q?kiZIhYJXQCdbcoezDGAsAt2PUH7JrQiWB2MBvnMvA9IWBwkudFMN1lJ+DUtr?=
 =?us-ascii?Q?1lNBaiaUZreizhHWphDUMTACansJSQesfewED79BVt0kMx5OvXKmgykhvW8g?=
 =?us-ascii?Q?y8NUoTh3bdUfimMlrW3FJ7ldVEcZWKicLvxxor1H+3Y6y67dQt2JvzpVw0CB?=
 =?us-ascii?Q?u9gFsL8zuBSS+LdQTP5yzeCiVJ9W+8GyP25dD5SedHRqDWn6WHo5Ct54WRU0?=
 =?us-ascii?Q?DXWVTYP1HMnlp2wW7nSTR2bMfhePBgMtGNCohUJ2KVeGIPofsw8a7hRyPICh?=
 =?us-ascii?Q?r7UraBQ45UV0nOe15/8kt5NyYKlMaUV2AlLcWOCeJAB/y7Z1qPvMkPwYLt0I?=
 =?us-ascii?Q?fER7GcHc4NPFB2T8dgCAK5y7n7VGjSW3ftadkFT81EHE2vgnsCI3Pj2ZdNam?=
 =?us-ascii?Q?BTPZSJU6wTW/SeP7y+QeEY/rkUwg9rwul0RK3yWO36CLErfuVB/IQ6T3bbas?=
 =?us-ascii?Q?ufI+JqweuzqIbQuePAIS0QKnJwGJuse3Yd3IjEC8JxnzWdblpBZUP8lAKZZq?=
 =?us-ascii?Q?7rAFGkBGw2SObjmXcrbZltQ4xNUWAInpy9aemWuNgx3Mm+qDujMEmIiJ1+q1?=
 =?us-ascii?Q?yjrTjgpBj3zaDpixU3uQOx2q5XHmjhTJ5lOXTJ3l3S18eWTuiyjg98mL07kL?=
 =?us-ascii?Q?XzBs1Tvsfni8dQmIx02WMvjLqzGOEcYCOPvCbpDKFgMQRJGtvvDjF12LBvx0?=
 =?us-ascii?Q?3mAWI2ni2xSHcfW3TWRmvFhbQ8ZJ102v8F8llcGGuzv6iN/hZ/xAGd0Y7l9D?=
 =?us-ascii?Q?tTQL3WSevWtvOksfrCZTUgx82DrxJ+ciDXqnunj+FSLIkkH51gI9Kd9k+eF2?=
 =?us-ascii?Q?vQqSJ+QzoTHuaDEDODAkXVNka6HA7RiXDVpQ/HDh3FCAhD62KY2KTsKDvWvg?=
 =?us-ascii?Q?zkgmmqUlfPOm0LtYmeN426Ck4jpGH8OxlNTpp1vWlU5M+pJMSsOv3sMV4zyE?=
 =?us-ascii?Q?BfbKY0LnfnQ4ISMc6Z249Xc/bDREScMI6jHAfhMQi4O0ovR+db7hfryepBfw?=
 =?us-ascii?Q?U2ArKnmZv1gCTMCuJRjUGvOYKUhYRxLnZVoZHlEfziibOOlxEv/Zyc5wsLjS?=
 =?us-ascii?Q?88GjvpkenX0xnzoFPo4upkQiuegpgO9UZstyeVViAmq5XFqriDJOrsesryFs?=
 =?us-ascii?Q?0JUIegerxK8k/8lDX3lUJmkSDvdbPHOHvtX9lSLqghL7A8N9in5LQbYHwgq+?=
 =?us-ascii?Q?laJzqzzQdHAqReLYnN9VQDrxrs+2j6tRhjlG9ODYl9k4qbDkdvj4P+jg176i?=
 =?us-ascii?Q?wfgQOXyzIRtwl0IrqMeZMuv0QF62LUtkHNAR75GYUBiszvgLCysI1qqEPNQ7?=
 =?us-ascii?Q?JNyKDK8zZuNmIEBaIyRU0WECGoNMCZ5B04BbwhT2QIEFkiHR7DYzV1BvFQnc?=
 =?us-ascii?Q?eBcXAQ25Xiw6ewnqKkIUuxoO0KJJd5gB7n6/sYUfyiWwlFzmuPKl8ibrUmgi?=
 =?us-ascii?Q?OE5Ebp0paROITbWFybTZKKvmWTnWpTbxk3cZtHoaIXKlBDoBpuVfDBXnHFHa?=
 =?us-ascii?Q?/eAJh7e/ywCKCWN0F2UiLbDLr5qwoHW59dSeptlrLjA8BldWspFsBi0zoREc?=
 =?us-ascii?Q?uIvnQUfhJQ=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a54be9f8-45fe-4684-df7e-08da4a74cdbe
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2022 00:04:35.6565
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7rIPBbajZ9g25y1MrwWXPxrj+W01nrWfCnwVLe2nXhbGAhHXqKdUgJE5o0U0vUkN
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR12MB1768
X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 08, 2022 at 12:55:13PM -0600, Alex Williamson wrote:
> The use of 'extern' in function prototypes has been disrecommended in
> the kernel coding style for several years now, remove them from all vfio
> related files so contributors no longer need to decide between style and
> consistency.
> 
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
> 
> A patch in the same vein was proposed about a year ago, but tied to an ill
> fated series and forgotten.  Now that we're at the beginning of a new
> development cycle, I'd like to propose kicking off the v5.20 vfio next
> branch with this patch and would kindly ask anyone with pending respins or
> significant conflicts to rebase on top of this patch.  Thanks!

Can you stick it in your branch please?

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Thanks
Jason