Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c96522a1ebfe79d7a0cb8bf6311c59d92b015c5c.camel@nxp.com>
Subject: Re: [PATCH v8 00/14] Add some DRM bridge drivers support for
 i.MX8qm/qxp SoCs
From:   Liu Ying <victor.liu@nxp.com>
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc:     dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-media@vger.kernel.org, andrzej.hajda@intel.com,
        narmstrong@baylibre.com, robert.foss@linaro.org, jonas@kwiboo.se,
        jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch,
        robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
        shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com, lee.jones@linaro.org,
        mchehab@kernel.org, marcel.ziswiler@toradex.com
Date:   Fri, 10 Jun 2022 10:27:36 +0800
In-Reply-To: <YqG+Hxswo5ON1MX0@pendragon.ideasonboard.com>
References: <20220609064931.3068601-1-victor.liu@nxp.com>
         <YqG+Hxswo5ON1MX0@pendragon.ideasonboard.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3pUNkxUaE1ZdnBkRWJDMnlNTVZ3TUFmTDlQb0tFQVE5Q1Vuc3paWmNqcFhy?=
 =?utf-8?B?YmpKTjFqc0JFUEJ6MVRKSHhvdDNOY0FENWVhV1FkTDRsTExRYnhMQksreDZ3?=
 =?utf-8?B?RHoyOGZuUC9KcUUybU15d0E0dy93YWtza1NpSG9nWjBEeXQ5RTM3dDVqWmpO?=
 =?utf-8?B?eTVNMStNRUFra1pHNDVrRDU0TXkxa1gzSU9vckpMUlhIUWhwbVlrWW03dW9E?=
 =?utf-8?B?UTV4c2tGckJZYmZzRmQvRERKN2RNTjdaOUNtd21qYTYyV2VLdzc4TFhHc3JW?=
 =?utf-8?B?TzIrNXJZdVZwV1VkeXQ1cHk1My95aFp5NlB2YUdHOGs2THZyV0N6ZWZqUytp?=
 =?utf-8?B?UFdqMFk1bm1RdTlpTjh2UWlHYXVXc2Z5WDJUNmpOZ3lBY2xWTkZaeE9Kc1RD?=
 =?utf-8?B?WWVDb3ZGOFBBOTI0S2FtOVR6cHd3R3ovNkoxVG5YWEhlZHc3RG95ekRKeHRY?=
 =?utf-8?B?TFhycmlJTjlqRjlRYWp0cW42cTNvSngzQ095WjEvRmFDQWdxQUlFd0laWkVL?=
 =?utf-8?B?Ni9KWHN2OWpKamRKYXBlZ3I2UjhDVlZha0paRU9yOEltYVZBd0xsZ2FkV1JS?=
 =?utf-8?B?cWRTdVNvTkd2NFgrdGdMQlluWHpaZmptNXRXckF0STIvZm51OXB1Y0FWekJK?=
 =?utf-8?B?OG9aZUxPRFdFOExHTUdUMWsyY1ZwRHlJQ3lLYnl3bTJucERqOUxUT0w0cXIw?=
 =?utf-8?B?UjU0d0lvMDZ2TGM4RGNubklINVo5SVRCRm04eUtSRUJWTEdzNHQrbnY3TzJs?=
 =?utf-8?B?aGZvOHQ4NzROeVpVdDcrc2o0aDBXd05zenFnUVJKVnVkRmh1bllxUmhKSXcw?=
 =?utf-8?B?N2JubG9VSVNIUGMyUHpnemFMaTVUdGFqSHdaOU9Pczg0ckVacFkvTk1hN0Mx?=
 =?utf-8?B?YkV3V0dDMGs2MUcyZU56Y1I5Vnc1Z0RFakthaXcwR3ZUejlLd1ByTXN0bDYx?=
 =?utf-8?B?dWQwM0RRcm5ORHFFd3RkNWxiVFhBMW8xMVhtdnJCRFdOV2IxWlFGUmFtZ0RI?=
 =?utf-8?B?YmljSjFIcFFQcGhGRCtoWHVzSFNkbjFPdit0Rnp0UDRuSUluSXhlMlVEUTVx?=
 =?utf-8?B?Nm1tem1TbVlIQnU1bDZiMUNkWWo4U1NlVEE0VzRzZXEwZkdxMUZnNVFVUjB5?=
 =?utf-8?B?bVpLdW5lT3QvWVJmQWtibllZS1IwVXJnekZ2eFk0SUlLc1Urd3FCcU92NlhT?=
 =?utf-8?B?Q1kxWUhYMDhJZ01DMjU5K2huaUNzOHVtU0p5ZlAzSTFSOWlRQ2NlQk1uZUxW?=
 =?utf-8?B?a2EyczNxU1FyNFBCckFDTWZud1ZlTmw1Mk9ZenZyZHBUMFFEa0pEaVhlMnBU?=
 =?utf-8?B?am0xeFUyWWV3UTQyeGxvbzdDbFZFY1B2dHpEWXF4T1FndmN5STlONjRNekkv?=
 =?utf-8?B?V3J6VWVNU090Z1B0Y1F4QVpNQzVEVU8vc1pZa1RoZFdyMjFOYXpFby8yL2pz?=
 =?utf-8?B?YlVwbldlM2lCdEgrbVJkMjVVK0JYM21VSlhqMG9YbXZvT21ZekNqYjFOOUZE?=
 =?utf-8?B?dlRkSk85T2J5Z01jajJpemtWODJJNk12b2xmUmJMd05lU1dZWm1MRXpsYmZM?=
 =?utf-8?B?WTJEN0tMNmZDOXc1VVlmUXNRelVYZEM1c3NKZUF4ZGtaNDZaVmVkYjRQcE1q?=
 =?utf-8?B?N3FuN00veXhNZHp2Slp0ZkdFem5UbjhJaEYwM1ZLRXpOSC9JeUd6MlozcStZ?=
 =?utf-8?B?aXh5eVIyV2pHd0FXeUhHbjhIV2M5VnVGdm1oUXIyZ3FjQjdURTJVVE5LRTNT?=
 =?utf-8?B?L2lZQUlOM1VaV2QxNHZqM3h0Y0tXRHFIN0lZN0xzK2cxa0V4V3NIUnZmajhE?=
 =?utf-8?B?Q1BPTzY5clZUVDNuK1pMOHFHM0YzNWVMZCtWeDA5blkxVEQwYjZzRjRlU0E1?=
 =?utf-8?B?SmMyTzdsWmMxb2Rjb243WXU1QjlUaWs2S056aEVpc3lSakxNK2VQMHFuZThl?=
 =?utf-8?B?M1F4dFNlYmdjNFc3Tll1TVFKT3FGL1FWN1FyNUdoL29iaWxscnBoMkVOa1o2?=
 =?utf-8?B?UVhWTkp1RlM2QjFYVUlvMGowbXp2eHhpd1FGR3M2RDlMNzlkcjd3V1hGQUNV?=
 =?utf-8?B?SGZLYzA2TGZzQURWVzBwazVFc01RL0FpVWlhK2VTTVk5Z0hDT3FHZEg1WnFv?=
 =?utf-8?B?M2NvN2RuQW1SQy9yeTNuenFSNWpyN3VtSnZZNnM4cDFJTXFERk9idkRPRFEr?=
 =?utf-8?B?dzVFR3psc1QwWjRvYTZvektwQUlBRFA1MnljbWl6eXZnUE9OODdPOWFhWlc2?=
 =?utf-8?B?Yi9VT2J5ZnlZNlE4OGdaeDEwSDA3ME5QUHJPMTdiaFd1dmk2ZTBpZkU4ZTJk?=
 =?utf-8?B?SU1OMWpGUDExSmtQbWdrTWVXanhwRlJ2MUVjV2tmTkFXQTdRdzhvZz09?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d02e4dfb-55fc-41b1-cf17-08da4a88cf06
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2022 02:27:47.7558
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6nq3zNFgs1g+rNcampXPziqo02o+uCwrFCpv7Bzu4Ys6vgdF57dNEvF6jc21K2E9Uo+tlcxWCenhYOt3PlxDfg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0401MB2359
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Laurent,

On Thu, 2022-06-09 at 12:32 +0300, Laurent Pinchart wrote:
> Hi Liu,
> 
> On Thu, Jun 09, 2022 at 02:49:17PM +0800, Liu Ying wrote:
> > Hi,
> > 
> > This is the v8 series to add some DRM bridge drivers support
> > for i.MX8qm/qxp SoCs.
> > 
> > The bridges may chain one by one to form display pipes to support
> > LVDS displays.  The relevant display controller is DPU embedded in
> > i.MX8qm/qxp SoCs.
> > 
> > The DPU KMS driver can be found at:
> > 
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.kernel.org%2Fproject%2Fdri-devel%2Flist%2F%3Fseries%3D629908%26state%3D%252A%26archive%3Dboth&amp;data=05%7C01%7Cvictor.liu%40nxp.com%7C52bc453b59654345591f08da49faf477%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C1%7C637903639438033239%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&amp;sdata=ciw5SX%2FdUHu5z6tVpY383LBxkWmEoFu03ljhrkKsj%2FQ%3D&amp;reserved=0
> > 
> > This series supports the following display pipes:
> > 1) i.MX8qxp:
> > prefetch eng -> DPU -> pixel combiner -> pixel link ->
> > pixel link to DPI(PXL2DPI) -> LVDS display bridge(LDB)
> > 
> > 2) i.MX8qm:
> > prefetch eng -> DPU -> pixel combiner -> pixel link -> LVDS display
> > bridge(LDB)
> > 
> > 
> > Patch 1/14 and 2/14 add bus formats used by pixel combiner.
> > 
> > Patch 9/14 adds a helper for LDB bridge drivers.
> > 
> > Patch 3/14 ~ 8/14 and 10/14 ~ 12/14 add drm bridge drivers and
> > dt-bindings support for the bridges.
> > 
> > Patch 13/14 adds dt-binding for Control and Status Registers
> > module(a syscon
> > used by PXL2DPI and LDB), which references the PXL2DPI and LDB
> > schemas.
> > 
> > Patch 14/14 updates MAINTAINERS.
> > 
> > 
> > I've tested this series with a koe,tx26d202vm0bwa dual link LVDS
> > panel and
> > a LVDS to HDMI bridge(with a downstream drm bridge driver).
> > 
> > Marcel Ziswiler has tested v6 with two LVDS panels(single link
> > LT170410-2WHC
> > and dual link LP156WF1) on Toradex Colibri iMX8X.
> > 
> > 
> > Welcome comments, thanks.
> 
> I'm not sure if this comment will be welcome, but what's the reason
> to
> handle the pixel combiner and pixel link (DPL) as bridges ? They seem
> very tightly couple with the display controller, wouldn't it be
> better
> to handle them in the display controller driver ?

i.MX8qxp display controller, pixel combiner and pixel link are
standalone IPs. i.MX8qxp reference manual has separate chapters for
them.  Not sure if pixel combiner and/or pixel link will be used to
work with other display controllers in future SoCs. So, it looks
appropriate to take them as separate bridges. 

Regards,
Liu Ying