Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <395072af-3349-cead-fe07-62d3d758d635@infradead.org>
Date:   Thu, 9 Jun 2022 20:19:32 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v9 1/2] thermal: Add thermal driver for Sunplus
Content-Language: en-US
To:     =?UTF-8?B?6YOt5Yqb6LGq?= <lhjeff911@gmail.com>, krzk@kernel.org,
        rafael@kernel.org, Daniel Lezcano <daniel.lezcano@linaro.org>,
        amitk@kernel.org, rui.zhang@intel.com, robh+dt@kernel.org,
        linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     "lh.kuo" <lh.kuo@sunplus.com>,
        =?UTF-8?B?5ZGC6Iqz6aiwTHVXZWxscw==?= <wells.lu@sunplus.com>
References: <CAGcXWkzJwOPXfE6ESAtwBbe7W-UkApKosKUy=UBRh0kmi-Bc2Q@mail.gmail.com>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <CAGcXWkzJwOPXfE6ESAtwBbe7W-UkApKosKUy=UBRh0kmi-Bc2Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi--

On 6/9/22 18:32, 郭力豪 wrote:
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 0e5cc94..c85e668 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -504,4 +504,14 @@ config KHADAS_MCU_FAN_THERMAL
>     If you say yes here you get support for the FAN controlled
>     by the Microcontroller found on the Khadas VIM boards.
> 
> +config SUNPLUS_THERMAL
> + tristate "Sunplus thermal drivers"
> + depends on SOC_SP7021 || COMPILE_TEST
> + help
> +   This enable the Sunplus SP7021 thermal driver, which supports the primitive
> +   temperature sensor embedded in Sunplus SP7021 SoC.
> +
> +   If you have a Sunplus SP7021 platform say Y here and enable this option
> +   to have support for thermal management

End the sentence above with a period ('.').

And the indentation here is all messed up.
See Documentation/process/coding-style.rst:

10) Kconfig configuration files
-------------------------------

For all of the Kconfig* configuration files throughout the source tree,
the indentation is somewhat different.  Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.


> +
>  endif

-- 
~Randy