Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To:     Javier Martinez Canillas <javierm@redhat.com>
Cc:     linux-kernel@vger.kernel.org, Peter Jones <pjones@redhat.com>,
        Alexander Larsson <alexl@redhat.com>,
        Colin Walters <walters@verbum.org>,
        Alberto Ruiz <aruiz@redhat.com>,
        Muhammad Usama Anjum <usama.anjum@collabora.com>,
        Lennart Poettering <lennart@poettering.net>,
        Chung-Chiang Cheng <cccheng@synology.com>,
        Christian Kellner <ckellner@redhat.com>,
        Carlos Maiolino <cmaiolin@redhat.com>
Subject: Re: [PATCH v5 3/4] fat: add renameat2 RENAME_EXCHANGE flag support
References: <20220609093638.664034-1-javierm@redhat.com>
        <20220609093638.664034-4-javierm@redhat.com>
        <878rq54pf1.fsf@mail.parknet.co.jp>
        <9d837076-f666-c3c3-dd09-5c3705da23e6@redhat.com>
Date:   Fri, 10 Jun 2022 12:17:24 +0900
In-Reply-To: <9d837076-f666-c3c3-dd09-5c3705da23e6@redhat.com> (Javier
        Martinez Canillas's message of "Thu, 9 Jun 2022 22:36:21 +0200")
Message-ID: <874k0t437f.fsf@mail.parknet.co.jp>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Javier Martinez Canillas <javierm@redhat.com> writes:

>> 
>> Looks like unnecessary complex (and comparing raw i_mode, not S_ISDIR(),
>> better to change before make dir dirty).  How about this change, it is
>> only tested slightly though? Can you review and test?
>>
>
> Your change looks good to me and indeed the logic is simpler than in mine.
>
> I've also tested it and AFAICT it works correctly as well. Do you plan to
> squash this or should I respin a new revision of the whole patch-set ? If
> you want to post it as a follow-up I'm also OK with that.

Could you merge to your patchset, and re-send?

Thanks.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>