Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp1098674iol; Thu, 9 Jun 2022 23:36:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4Q8clepelFLQhqtp5yne7Yi+yL59tvgYJD1Bw+KvB7U6VebBRw/IOisj763t5xbZDDnqs X-Received: by 2002:a05:6a00:b51:b0:51c:1219:569d with SMTP id p17-20020a056a000b5100b0051c1219569dmr26394816pfo.2.1654842966047; Thu, 09 Jun 2022 23:36:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654842966; cv=none; d=google.com; s=arc-20160816; b=pcMPVm0NiuHQwXlK/e7rBv/ckIVRIVzv2EylRgIG891qkt4BdlKAqJ6ZEeaSFJPca4 4I/CAo1UYRnRghGY2fIyj29TGNOXjYENPD/GVkqcWtyjgidklPErwhWWshykExrEkHf5 ZP4fs8cqgx7aw1hLy0ygt8+3RUcy7+GYKBwvfNgxYMEUboCqLaya0ncIilizKZQEf3nk 3rEYP0JfzOMxVHuc6k6ubRCc/cUvGW1/D19TQBt5m5ZLp75tdC78t+QW6T7h/ZF6a+hc 1mBIMNyPzRLtxTuE6sDjzC3zGZhOsp2xlmqASna+n8HHpszSUt1HFSwv8YL2UW+hLFjc HErg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=xfWpH/f18Gn+fuZpd0gUuSPLsyGKd5opDvcqr3Q9COI=; b=D5Mtbn9sj6AH9LEve+ZvQyhQ+qptpiKEd2n6ZXDOAv/cobWBhFW5JyEwF8QfiBdM2S qXrIyyP0xrFFzGykr3HxHlLGDsX5uRiQ6StzjE2k65nzkTAJhihpVM6tl4SMjxGY7fPY iuxKfYIef1zFOpEKxNHebQtL+g1eHBXk/wVgwnGd1Bs1rVYCNv5yaNi8G/n3c3MfPP7j R1SbSt+ipQAPUC2Punc5/y27OA1FEY0PtpuQq8FSfy/o7unzD6coRMN+3ILLBPxybgJR 0Hwrc1C7CwwLs3aDUYwB+3hBeKQ96CLR2W/Nj1KtQSwfR6w6GsBXXMqN1Fc+4k22vV1C tnwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Hdh7bWVg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l73-20020a63914c000000b003fe0f4990ddsi11585770pge.255.2022.06.09.23.35.52; Thu, 09 Jun 2022 23:36:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Hdh7bWVg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243132AbiFJFwt (ORCPT + 99 others); Fri, 10 Jun 2022 01:52:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242654AbiFJFwl (ORCPT ); Fri, 10 Jun 2022 01:52:41 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C786F0; Thu, 9 Jun 2022 22:52:40 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B983EB830A8; Fri, 10 Jun 2022 05:52:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A97ABC3411B; Fri, 10 Jun 2022 05:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654840357; bh=9zkxBIOVn1jqpEIn3oRNOtYHxAz8CrVcwvYLEOX+hUQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Hdh7bWVg2Kn+IOmG8VDaHsYzXzO5C8DP99mi7sI/gyXTsydvAp7Rp1ScECqRxQFMR 3jv4cwtrL13VLFj8F9i4WpZCMcqsE4jC/1lIMMQAi1Mm4ewszyg/CflVwHsmX99B/W 2NxwXQruv3/CCnZYo2LoujCOhCGHUJ3P15x74TlXbn4VfbarmvG6ShTWuG8EXBGjUA egeV837WAYF588soBoZtSrFrJj5y6xlQe/AYip5rTPmqHITwGB4E3PLhDJAjRiNU8J VctdO0qOhBgUJ0ZaXiFeSTBuBu4We+xzTSPr0HlTk/lWs5wgcdeO6T8z5H8L07edNo KRFFZPln4bsvg== Date: Thu, 9 Jun 2022 22:52:35 -0700 From: Jakub Kicinski To: Ong Boon Leong Cc: Alexandre Torgue , Jose Abreu , Andrew Lunn , Heiner Kallweit , Russell King , Paolo Abeni , "David S . Miller" , Eric Dumazet , Vladimir Oltean , Vivien Didelot , Florian Fainelli , Maxime Coquelin , Giuseppe Cavallaro , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Emilio Riva Subject: Re: [PATCH net-next v3 0/7] pcs-xpcs, stmmac: add 1000BASE-X AN for network switch Message-ID: <20220609225235.4904ea56@kernel.org> In-Reply-To: <20220610033610.114084-1-boon.leong.ong@intel.com> References: <20220610033610.114084-1-boon.leong.ong@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Jun 2022 11:36:03 +0800 Ong Boon Leong wrote: > Thanks Russell King [1] and Andrew Lunn [2] for v1 review and suggestion. > Since then, I have worked on refactoring the implementation as follow: > > My apology in sending v2 patch series that miss 1/7 patch, please ignore. Please wait 24h before posting v3, as is documented to be our process: https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html#i-have-received-review-feedback-when-should-i-post-a-revised-version-of-the-patches In the meantime try to build each patch with W=1 C=1 flags set and fix the build errors and warnings you're introducing. Thanks!