Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp1099000iol; Thu, 9 Jun 2022 23:36:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFoRz9hjswapZESbSNRgdMOnMt8VcapOWgwcKPjFpITV190Th60Z1VoldT/BtP03qwXJ9P X-Received: by 2002:a17:902:dac7:b0:166:3dfe:f4b8 with SMTP id q7-20020a170902dac700b001663dfef4b8mr42576355plx.55.1654843006932; Thu, 09 Jun 2022 23:36:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654843006; cv=none; d=google.com; s=arc-20160816; b=Ah3XIYWVLdn4yLS0uPX9O/1aVSKsZyxpMx2FL9fnhN7XnNy7W3HJzFIlluPmB7taZr QHDjc0jDJ1PxfucbWkJuT19gcIJ+cFTYiwQd1sv5ysiwdfsq0EJ/VJryF2gYnCm7UunX hOT3imTNI0iuZ7r9VxeD46K1zw680lA5OwL/Vzvp5QLdTMVWj/qh3u7EwquuHfTfxZFG u11jD6WIX0iUJj0iSsJyezMFI6r2lsE5vbE87qZ/eeVgtQ/i0NtsbcaE2LCjXox6eAxn xHPug2cIvZdpCVNDN7TuaZsDjcmXmP+3UQXld0L5pvN45wx0L6zxCcIWcPP73uqqh+gs EARQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=fQQYd8rH7yJgcH0WS5t7Iydx1WYbX6aTpNe9zlkn5xY=; b=Q6LL0cKBa1krb/A5SaQVKfNVf1VLGWhmYLsF60MPT5TbxTNukil/c0kZjfOcinLw3c /8yVoOhitEz2TD/7JxStyNCaekolyyzpAu7HSKJbop3biYJQRKqgYUnu2qrG43ZQQkj1 1Zw1+Az9+dWXs/clvuCwBjXCVb632e4Qxu/IJeP7ZYyrHnkFJMbZygP+ubDxuDdvND/X dCYQdg2Wta/cNvELz48MizO5mLTEnRtnU7diDMI/j9vmk0V8688gibLIVibejfaDDixJ BcgKfRgyuIYRwqIrtZHof4YSNgF7faMq3OFT0Rk2NROXfvnV+voIgavKbS0UCC687uLF byfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=knb9VjPH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n19-20020a170902d0d300b00163eff0e715si30924623pln.106.2022.06.09.23.36.30; Thu, 09 Jun 2022 23:36:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=knb9VjPH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346264AbiFJFqL (ORCPT + 99 others); Fri, 10 Jun 2022 01:46:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235507AbiFJFqI (ORCPT ); Fri, 10 Jun 2022 01:46:08 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 188CEB4B5; Thu, 9 Jun 2022 22:46:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fQQYd8rH7yJgcH0WS5t7Iydx1WYbX6aTpNe9zlkn5xY=; b=knb9VjPHC+6O7WDiHU1GAHcTAG vRgrANbZCRTzUEEFNEjFJ1RdGOfNA/zo2JrBBPC+yL6tSluDm289+6nyXfosJtKmlyZlBieC7vkkz QE+AGKTlV/bfs9e2X6gg8YTXmB+lbg9RldomOdR9TXR7wcDPHzZYjcFA9ivk5gypnNfJ+PG8MIqWv jb3fC56WsabH27bAKa+26acnxmxXetekXbR4k99gDJ1eLm8bsipbbeON7lqnj3i1K4QksMVFK2MiX UWkr5+1IN9mWvoqKgH+esAlnwDVxmlsDwGC2wYggJwT9uExQr93/yAyGe32WwmBfYGoeEox9EeC0X fd4876rA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzXTB-0061yU-Ai; Fri, 10 Jun 2022 05:46:05 +0000 Date: Thu, 9 Jun 2022 22:46:05 -0700 From: Christoph Hellwig To: Shiyang Ruan Cc: linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, djwong@kernel.org, david@fromorbit.com, hch@infradead.org Subject: Re: [PATCH] xfs: fail dax mount if reflink is enabled on a partition Message-ID: References: <20220609143435.393724-1-ruansy.fnst@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220609143435.393724-1-ruansy.fnst@fujitsu.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 09, 2022 at 10:34:35PM +0800, Shiyang Ruan wrote: > Failure notification is not supported on partitions. So, when we mount > a reflink enabled xfs on a partition with dax option, let it fail with > -EINVAL code. Looks good: Reviewed-by: Christoph Hellwig