Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp1109609iol; Thu, 9 Jun 2022 23:58:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzxgn1HCAE4rWF6Hc6+Wp0448YuZ318Pz2S6QYWzFpiMfXGV9jgw8aOoJmnjBnmhgulztDG X-Received: by 2002:a05:6402:3594:b0:431:4cb8:c7b6 with SMTP id y20-20020a056402359400b004314cb8c7b6mr31143024edc.334.1654844335398; Thu, 09 Jun 2022 23:58:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654844335; cv=none; d=google.com; s=arc-20160816; b=Excg7zXpsAlav3hLdSg8Lw8/iFnSeDa0GoSDgOyeIXDPvtOEUK8IkWWUWMMtLsiJCU poUIqfkVmXv30TGkJAEyHxeIqMk5azpAJhIyM8EoqlNckEXfNvT8B8DCIGFHivhJZr/l krcv3/Ku+enoT9zbhJ/2raKTiJ0y4jJRUlKsb/+PylD656enPdbME31fcHV4WHzouNMt GquCBSnebJqvhAk4nImEilmTwSTZrMm6hyBNOKMKfPx5k+FM17wHlA51Ey8kHlKvV3Zd YksryUJcw+OhUWz2hhj3+DXnu8zoNwfGW0zzR11bIoE4ND1qIVmWhtXCKYhUtAOsPLgS Iucg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=6kddBTnnpmcymh+ofbgGU6mpkJUAD9EB6hg8dLpQHFw=; b=BPoYIN2pyDYhyfxoKfQK6zi4CCAuayUCf/Ls4OyscfnaU+dBX6MKoDsKzBZXxKaITc xUphuClZBRJaM7t6dZpsduLPuq+PBeFsdZ1tRT3EMQ+ykDcbu23lY1+4yvYaNVY2z53v W9hQMOBtmsN6SWRejZmASQrOhEFW3kNGVN1QY/ajD2gjb+Ke3Eqd4gJ5Sdwj9azBQduY +Smy0802UzCwL7ssA/vqfyhbuwjRVUUXzVcDqqDaouDNrIK4kZdU7NVXkdRAdyQ3YBYK zRdGY3yPR2GgL7Geki7Y39spn4GVgx+vla0CY/9wI6RhD7TmuxFojYPsdjucCLVqY1h6 dfyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HryEewmp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id jg10-20020a170907970a00b00710e677138dsi7674044ejc.981.2022.06.09.23.58.09; Thu, 09 Jun 2022 23:58:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HryEewmp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346234AbiFJFpb (ORCPT + 99 others); Fri, 10 Jun 2022 01:45:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235507AbiFJFp3 (ORCPT ); Fri, 10 Jun 2022 01:45:29 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E067F245AE; Thu, 9 Jun 2022 22:45:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7D9B4B830A7; Fri, 10 Jun 2022 05:45:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC190C3411B; Fri, 10 Jun 2022 05:45:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654839925; bh=1CUCflqyQ5OvcBwT12upAn5jk64F2GggywWZMTmX+sc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HryEewmp3Cy0HEInxqtqog3JfkcOk+1JqoW6/HFN2ZUY2nxsbKp+StQqUEE3xTBq6 NqXWWfc0LE1Fp+aXozdeNy3a7gqTEMwe44d0hKulKj+CfgXIoEW61gRZfF96+t4zvl UHphClI1QFsKYciO/fSxf+BsXfX7n+MtKMiP6J57GnF3cuonUKRM60GpJFvGX7ARoR Us8LSME+lFf69zaRfH5+SBqcfGvRKc416CMaJfXCq4+0RMjhdRGCPX+s8sFNZRPscE xG49FDKIrFfdBWgUOdjTpm8+4Hjy86n4S+B93tzdtoUQLfsk6w+UeinXgG4E3+2aX3 TjmjuMWsdJRDg== Date: Thu, 9 Jun 2022 22:45:23 -0700 From: Jakub Kicinski To: Andy Shevchenko Cc: Jonathan Lemon , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Richard Cochran Subject: Re: [PATCH net-next v1 1/5] ptp_ocp: use dev_err_probe() Message-ID: <20220609224523.78b6a6e6@kernel.org> In-Reply-To: <20220608120358.81147-2-andriy.shevchenko@linux.intel.com> References: <20220608120358.81147-1-andriy.shevchenko@linux.intel.com> <20220608120358.81147-2-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 8 Jun 2022 15:03:54 +0300 Andy Shevchenko wrote: > Simplify the error path in ->probe() and unify message format a bit > by using dev_err_probe(). Let's not do this. I get that using dev_err_probe() even without possibility of -EPROBE_DEFER is acceptable, but converting existing drivers is too much IMO. Acceptable < best practice.