Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c079243c-9084-b565-2320-20453815c79a@amd.com>
Date:   Fri, 10 Jun 2022 09:24:19 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] dma-buf: Don't use typeof in va_arg
Content-Language: en-US
To:     Wan Jiabing <wanjiabing@vivo.com>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org
References: <20220610072019.3075023-1-wanjiabing@vivo.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220610072019.3075023-1-wanjiabing@vivo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R2k1WGZSakM0aGRBQWRPY0x2MDlNdnp4M0NLUDVkNFV6YU1RN0pyTnJISDBv?=
 =?utf-8?B?aDYvYVB1S2pRTWZKQWI3N1ZPeFJ6aUcrWVh2UjBEYmsybU4zdDJWVitvZ2FT?=
 =?utf-8?B?STZnT1FHd0ZlVmY4YXRreVRrcUgxUTY4eG9EcFJIQ2thcHUxVnYvVTZBMTVj?=
 =?utf-8?B?WGVDdGhhK2U0Zm1DZ2lUM25wUXkyTnBtMWttL056K0NPb0FHMFRTbGx2TkhS?=
 =?utf-8?B?bVBCQzQ1WXMvd0JNRWRRbWJFdEFHL2Y3MDFFcEFJWVYyc0t1UGNjUHRHcGdn?=
 =?utf-8?B?dEx3R29XeTVnZXF4MGdFSGZHckpZQzFUdHJhckRIcHhpSENYWllkZ1ptbzlL?=
 =?utf-8?B?N3k0M3dwVTFSRVREQW8vOVc0QmlRem1vS3NDTVQ1YllEcjlETEtjWDgvd3VQ?=
 =?utf-8?B?bjk4UlRiNi84N3pDRWN5dzhueFJjMzFqc21ITy9yOFhzZUNxZTdGUktHZ3pj?=
 =?utf-8?B?SmZkaURveEJjVWh1V0JmeFlTcmVycGRDVzNEdlB1Z1puMzZwaDJQZFpsUmhO?=
 =?utf-8?B?VzdtRWV3d1lOcFlyM0xBNXlUUHVSeWw2a1pDNTkyZDVmWG9vdTF4WWtaclZn?=
 =?utf-8?B?a2xMV0x2SFl5d1RHWElWbnFTRTdCVVRWcFROYnNKMGlFOXY5V0pIRnBLUjc2?=
 =?utf-8?B?aW5GanYrUUtQM2tvSGRoNk9uYUovTnBrbjcvdDRHQzVaRHBRUGYvUDRSbkZ6?=
 =?utf-8?B?MXlHVlUrbmNJUE1WaS9LdmI2TnZQYVlHZjJNZFNPbG5YeU9MTHJxRVVKSnVa?=
 =?utf-8?B?ZXU5S2tMU1JIYXBtcE5zVWJGWUZNR1FqdWlyQzREN2YrN0ZIaWJXZlIxL2VG?=
 =?utf-8?B?Z3VqKzIxMThXTjFGV0hPYUcwMkxGUDFjU0htdldMaE80UzRGSTVkUWthUnRq?=
 =?utf-8?B?UkM3SlJFaTVHNUZPZzRmL0ZOelkzN1ZDN1pxQ0t0c3NscERlSUkzQ0xRenRn?=
 =?utf-8?B?RCt5UVdMc1RXM2FHQkdWamhPbWp6dHhEQmdNTzVHTkdXMkdJOTZqemdQeGkr?=
 =?utf-8?B?UlAyNDNxTGw0MFhTZ3JoMWIrSkRkYkhQZ1Q5VzJGbHlCaVlYUTEwcHJveW1R?=
 =?utf-8?B?OUxpUXI4ZU4rdUJOT3VFdEpYUXB4MExWSlhwRFhOL2x3UlFKdzB3VXVKU2hL?=
 =?utf-8?B?RG5HOFhFNkpTK1duSFQxaVUyZEZQRDhoYXpzVGRWSDFTVEZReVU5VnJzL2Ri?=
 =?utf-8?B?QjgyL29SRkE4NGJhY25NYmplZ3R6RWQyUmMwNWpENk9sUXZKVTR4bmRyNUhU?=
 =?utf-8?B?dkpFZXNXOHBNTkZKVlAyZEZMck9LdjNLd0h1akl6VWIxN29RZHhhMjlyeW02?=
 =?utf-8?B?VU8rTy91NldOKyt5eE1UQXpOL25NVklKRm1EaWRQOGdhcmFJc3hOZDZWK1RH?=
 =?utf-8?B?b1FGRzFCOTZUeXUyWHhoUUtaNWtGR1NKbzRKUFVWaERlTTBuYVBZbDY1QWhG?=
 =?utf-8?B?ejVXRmxidmV2dnRqeXNUZ1dIRTVtWm9jVE82MzkvdVpoV0ZjeHhOeUV0RSs0?=
 =?utf-8?B?MFlVQ3Y3c0J0ZWtuV3JhZHNHVmdLbnkvUkZramhNVy9NKzFZOE1CUDFnK1NO?=
 =?utf-8?B?MnNxK1NYZTJqaHU1NlpOUWdhTzBjeTEzbElYZGszc0NVaGdiU09XYUJOTTl3?=
 =?utf-8?B?VUkzZ3NxdklNelVoVDFRa0hvdDEycmc1eTZZMmFEaTZFdGpBaSs3aTFWclpU?=
 =?utf-8?B?RTVkNkVmeUZnVUVtc2ZOVjNuKzFCUHlNUktEdkcyL0FtUkF2OGFyRkxCSGNm?=
 =?utf-8?B?azcrUUY0NDNaVnhUNno2V2JIMHEwTlQwVGdNa2JuVElONmJuVmpxRGJOYnhB?=
 =?utf-8?B?cHB5REhud2p0N2lidWVnZVVYQUxsbnNEYzRicG0vL2hSUEMrTCsvT21CTUpu?=
 =?utf-8?B?SGlRakZydXIyY1BIaEhtRTBBYUR4Vm1ZVURwTmpHN3JPbjdESkQ1NXRkdU9i?=
 =?utf-8?B?cVJ1cW1kUDFBUDN3Q0VaKzNrRG5Rem9JbDI0b20rK0U1aE9MUkxtandiem9u?=
 =?utf-8?B?TVUvZnlXWGk5eU0rRHlJclkrQk96b1F2WTZ2RDhLZm50QzFFUzNaL1llczZD?=
 =?utf-8?B?MGMxNDZDRHI5akZTby9KVGxWOTd1am9ENHY4M0kyMzRVMkhQTm5RWDRIRURV?=
 =?utf-8?B?QnQ1RGxSdlJoMDRncXQzY1J0a1FmY1RVQmZ1R2Fha1VIaWoremJsaXZuSU1l?=
 =?utf-8?B?QkJ0YVVxZS9Da2VTN0h4clZlb1lNSkVWRGxZbEswRlZseHo0YkxuTUhCRUtj?=
 =?utf-8?B?WWdEYWtoaWt2ZG1mN2w5VzQwMXEzUDVnYzZHT1RuZjN6RmtGQUxack9DUzRH?=
 =?utf-8?B?OTlXdWZ6cDlQSDBHa0dWNEZodWNJbTdOWUhrbytGUWlsOGZqOFVzZz09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 09589f81-332b-47df-a058-08da4ab23f7b
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2022 07:24:25.8234
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PcooZvNhIYs3zT25cJ4Q9WkUGRuTsCGCjT3oOpnxi18eqrdvgXIuZAlX26iW/xgy
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5189
X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 10.06.22 um 09:20 schrieb Wan Jiabing:
> Fix following coccicheck warning:
> ./drivers/dma-buf/st-dma-fence-unwrap.c:75:39-45: ERROR: reference preceded by free on line 70
>
> Use 'struct dma_fence *' instead of 'typeof(*fences)' to avoid this
> warning and also fix other 'typeof(*fences)' to make them consistent.

Well that doesn't looks correct to me.

*fence should be valid at this point, why does coccicheck things it is 
freed?

Regards,
Christian.

>
> Fixes: 0c5064fa8d5a ("dma-buf: cleanup dma_fence_unwrap selftest v2")
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
>   drivers/dma-buf/st-dma-fence-unwrap.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma-buf/st-dma-fence-unwrap.c b/drivers/dma-buf/st-dma-fence-unwrap.c
> index 4105d5ea8dde..1137a6d90b32 100644
> --- a/drivers/dma-buf/st-dma-fence-unwrap.c
> +++ b/drivers/dma-buf/st-dma-fence-unwrap.c
> @@ -56,7 +56,7 @@ static struct dma_fence *mock_array(unsigned int num_fences, ...)
>   
>   	va_start(valist, num_fences);
>   	for (i = 0; i < num_fences; ++i)
> -		fences[i] = va_arg(valist, typeof(*fences));
> +		fences[i] = va_arg(valist, struct dma_fence *);
>   	va_end(valist);
>   
>   	array = dma_fence_array_create(num_fences, fences,
> @@ -72,7 +72,7 @@ static struct dma_fence *mock_array(unsigned int num_fences, ...)
>   error_put:
>   	va_start(valist, num_fences);
>   	for (i = 0; i < num_fences; ++i)
> -		dma_fence_put(va_arg(valist, typeof(*fences)));
> +		dma_fence_put(va_arg(valist, struct dma_fence *));
>   	va_end(valist);
>   	return NULL;
>   }