Received: by 2002:a5d:925a:0:0:0:0:0 with SMTP id e26csp1166112iol; Fri, 10 Jun 2022 01:30:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzFMkUW3ijqKYuZlqsJjwzzGl9Pgx0oQvzbt4MU04OlIU8YIm2Y4i1pTqp0vCBPGdbbjSct X-Received: by 2002:a65:6a50:0:b0:3f6:4566:581d with SMTP id o16-20020a656a50000000b003f64566581dmr39351732pgu.122.1654849806128; Fri, 10 Jun 2022 01:30:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654849806; cv=none; d=google.com; s=arc-20160816; b=Xg6HSolByKaHZtItLshcM4I931bv/SE/xJm5QjdOTyvL6QK8CrqWV4EbJf/W+hVjre scnnsqWxT+HVmUelQ8Qo//EcKNB62dxh2bKOXjImo7X8RkopiB2amHL+mYcM+eHB0pMU 9IABncPZO7WhikYyqDUjzC/J+KEg8nhknAyzJiVWYVc2fJnDjCBsaf/bS891pGr7nKjx 69NC8tkA1yVFRZPGyRXwX+IlngPJc37WfT3tPuauM3bFGDaHu1tzVuZU59tbgWFz/xCB EzV2vpGalKfiTIt9nniyGXM8YWjh4KIY//If8z9EEbdDnW8FMXAtHtOwckBVeU3KLnA6 kEqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=w8J2KWjgjx9J/jKYFe8GjW3jNW9wYeGtv0q5FHV/ys4=; b=bhhiSSZfcX2B2u6VnsLSEIS0iiU+WqUCJ8MYgOn99Ll2EsG05io9sSfw7uXr4QX5yo tAzIAqOAD1/jKSdphm5WdS0ORw5t0+oEHUBcRV1/wUHbX6d5yeKsTsSI7wahGCtlD9oR AgOPlyuxKfuVwi/ahewY+XsuNo/1NpSNpnqzCW69/inLLkKzDgxNJT3JAr9MleF1/NgO +t62cLPCJTsYzrVlnIxQHbpYv6BHqVywRuElj3BDNycRm/3CkrFF255tRGLNhd/+hpgt MUMt8HKt4yHRdnz3Br4hqF4N02uLlCAvJ6MJH4M/EfyavsfzleguZ5sfAeFe8ZMcCtqV 09sA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=GB5aPyYF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f7-20020a056a001ac700b005180f251cd5si9690202pfv.184.2022.06.10.01.29.52; Fri, 10 Jun 2022 01:30:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=GB5aPyYF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347179AbiFJILL (ORCPT + 99 others); Fri, 10 Jun 2022 04:11:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347159AbiFJILK (ORCPT ); Fri, 10 Jun 2022 04:11:10 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 697F021E0EF; Fri, 10 Jun 2022 01:11:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=w8J2KWjgjx9J/jKYFe8GjW3jNW9wYeGtv0q5FHV/ys4=; b=GB5aPyYFM6PkAx1k8v49cM2BwJ WcHcAb9jUq2QalpM0aIhDr3+BATD+8EYM+eWrdcimaNJm2xzuBjssr8WpUOHCt60n94XAWc3FLON0 Ea9J0QBamM6uWTM+4HzYRBxWYDjskhw+JmLncWTsnFKFqxOWIxsmL4IFLm4L1tdnFjZSI0pPplO8o 9sJxX0TlKZO3aKYVSMxNIiHKcE1/kS+w9R9M0LWGRUAImkmbZyNxVDSII1uFSuj5x0bXfi1yfXOOK c3DmI+O3f6cqKS1/lbJzaDxCojVk8Q1W7xF3ZeNStt9QC+dLwogmOOIHoLpghg/0Ij+XccRx5toAG ilnXeRzQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nzZin-006gfR-MQ; Fri, 10 Jun 2022 08:10:21 +0000 Date: Fri, 10 Jun 2022 01:10:21 -0700 From: Christoph Hellwig To: Bill Wendling Cc: isanbard@gmail.com, Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Phillip Potter , Arnd Bergmann , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jan Kara , Andrew Morton , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jaroslav Kysela , Takashi Iwai , Nathan Chancellor , Nick Desaulniers , Tom Rix , Ross Philipson , Daniel Kiper , linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, alsa-devel@alsa-project.org, llvm@lists.linux.dev Subject: Re: [PATCH 04/12] blk-cgroup: use correct format characters Message-ID: References: <20220609221702.347522-1-morbo@google.com> <20220609221702.347522-5-morbo@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220609221702.347522-5-morbo@google.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 09, 2022 at 10:16:23PM +0000, Bill Wendling wrote: > vsnprintf(bdi->dev_name, sizeof(bdi->dev_name), fmt, args); > - dev = device_create(bdi_class, NULL, MKDEV(0, 0), bdi, bdi->dev_name); > + dev = device_create(bdi_class, NULL, MKDEV(0, 0), bdi, "%s", bdi->dev_name); Please avoid the overly long line. But given that bdi names aren't user input this warning seems to shoot from the hip a bit.