Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 10 Jun 2022 11:06:27 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Johan Hovold <johan@kernel.org>
Cc:     Jared Kangas <kangas.jd@gmail.com>, vaibhav.sr@gmail.com,
        elder@kernel.org, gregkh@linuxfoundation.org,
        greybus-dev@lists.linaro.org, linux-kernel@vger.kernel.org,
        stable@vger.kernel.org, linux-staging@lists.linux.dev,
        mgreer@animalcreek.com
Subject: Re: [PATCH v2] staging: greybus: audio: fix loop cursor use after
 iteration
Message-ID: <20220610080627.GA2146@kadam>
References: <20220609214517.85661-1-kangas.jd@gmail.com>
 <YqL6A3pVC8LOqE4d@hovoldconsulting.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YqL6A3pVC8LOqE4d@hovoldconsulting.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gRNVeWzi5DY/6XiRj+POG7CHBp9mDvVhobPtuucoPfkLuNZQqGbDFzBVk4pp?=
 =?us-ascii?Q?U7r3eVgpmvdggoNCcubz6IwHx5MVwUSjKhVRFWs3+YyfmSIGsLr1Rt9VLfSL?=
 =?us-ascii?Q?AGlN25Pnhqa/OOEPef8yPOxuFnWzGFO5OOuN0mY01pyj0OPMdV+9IutkhjO3?=
 =?us-ascii?Q?QiJetXd7L1TNZ8ff9pWQPpheJLk4QDnfRsJoE7X3AHWb5ozgowpTqCR+9bsT?=
 =?us-ascii?Q?EiDn7iyXs0BYNsRsNkjMoneEiqw2ZW0c/lkESqj10+pI6s26Bxms/eNUzisx?=
 =?us-ascii?Q?OQ1eGeUugZEEv7HbNIU+lEg4HoA2MTsQhYfUFVrXmgUxTeN5OAds651KKA7g?=
 =?us-ascii?Q?GyMdiAJypVIVpsDjxMgzlAzqaeCqJQzfqNx1hT6B30P1kSXakxL7e4QdA3nz?=
 =?us-ascii?Q?yDoGiWNirmwJy1SIIAicfcn2Lnh7/NKwXY8ul9Lqb4NF0TLDDe7J1M3z34Dv?=
 =?us-ascii?Q?ev+6XlbwNucD4wwUBejNbCChd+5nf0/a4CsP067pJVUR0Rz/d53Ri+0gQ8oI?=
 =?us-ascii?Q?xDEO6Xyp4VMh30RKPfb11QBTGw+G/Yx4giiwH/nkW3vZULNz9XoztcQgXJii?=
 =?us-ascii?Q?ivwFxCdWVmR1bUTgmaT2E8EgBAmUb8Di/gSNG4QrH9WiWtFryXg6RntbT2wn?=
 =?us-ascii?Q?oxmoC8wABt8oZpxIKAE1ZOJ3uwHG6Zu3FIQWEH4JQeRlWlW0WIYr5eaeRvDE?=
 =?us-ascii?Q?WAQAaib8K1UAYyeH+mflNHRp2xFYmBqxKZymuyOFphYgi5IoPkDQSXpaSNos?=
 =?us-ascii?Q?I24WPoptdGQmOFG+wsUixqhiiuG7PVCKlO2eb+i35A7D7KjRuUco0OqwDFVh?=
 =?us-ascii?Q?SyLRIuthrqkUrb/dg35THRxhHK+ca/5X1OVIx/ibemogDTTNyZsxs/MlbnTr?=
 =?us-ascii?Q?lOfmjHF51RxsBXNfQkAdufEVtkCrNUsxbjjgnlekTbFo1xaUoAiiWTIA9Zy7?=
 =?us-ascii?Q?uY9GyrWC4+UM7urZ2mROnW+JMJgGvcV0haDhS862MgF7XsvrIIetpvlOcsBA?=
 =?us-ascii?Q?v5phxXbhEXjimNHwgejEngoBhGTAt/ruUR77lyU3GHJWrZcN4be9sVYRPDZS?=
 =?us-ascii?Q?FjdAiSncXnAqrD6lZvBiTwC3rckbs5+Bcvfpm8sl3uofaJcZcM95GTELneIy?=
 =?us-ascii?Q?kNT24FMiq+JTVAE1+7ULBXESsJ0Be2h+JFNw7WF7OySAn5ET0pjAlJnLJaf8?=
 =?us-ascii?Q?fq6+Mhfppxfy/UuyzI/GRjsfA2fqnuO+X5mpRd/CjHLvFlvDCSpUXI4tQJCD?=
 =?us-ascii?Q?EYE7t1Px3KImWM4buxYmYUv+GAHBSLHp+S9wDxIZjc6vf/jHbwT3Zb6cvl01?=
 =?us-ascii?Q?XPG+9DqBcsY/V2KuUwjmvlUUUH2wFpbn4g3l+C67iLc3lONkC0baXfsLoK6E?=
 =?us-ascii?Q?ZqPYXqGtgXJsERml0+lIIRXwd+CjgFGbv0EbIUlNMbZqi4+c61CIJ8ThJTTA?=
 =?us-ascii?Q?xnhnWLBZCG+l5aaBJ+rohGITe57O3uHe51JuCVWifbX1BwYtM+Jfdj1kmR6v?=
 =?us-ascii?Q?M5btph6HCPfqS5QKfvagT40awIAFQswz1p9kd3BV/6fcwqOBlQBiLY60tTe0?=
 =?us-ascii?Q?TgwBvpvMuF+npr2qtqbAp51F6GPsbJynfmAmpb9W0GL8BHD1mvkamcLHvx6b?=
 =?us-ascii?Q?XpuBDrhUctCNYXn6Y04p41ICQWIQmGz5FJB4TQPsF4DO3+Iz2t2zGo0SEIse?=
 =?us-ascii?Q?AyeqZzXlQ9JnmJDvykhgbf6il+r4N2UYxsN9pV6bwskIQscABB5OTQWR1/LR?=
 =?us-ascii?Q?lbOg0sEox1c0meF/HtMby3+wq6+WioQ=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8f747d4c-15e3-4e6d-fdfd-08da4ab82544
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2022 08:06:38.8718
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mASLmnN3tNqqKEjo3+gftEEj9GnUEcByEaHG4Z8p7rQ1puCNGby0aSPCTT8RE+6vK/gC4o2Cz7Ck50iQxfszHKyy9W4KVJ/3NhwKBqEXbfg=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1948
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-10_02:2022-06-09,2022-06-10 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 bulkscore=0
 malwarescore=0 phishscore=0 adultscore=0 suspectscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2206100028
X-Proofpoint-GUID: 0H3o_cx7UYGEvettKc36KCJ3RtgZi7ot
X-Proofpoint-ORIG-GUID: 0H3o_cx7UYGEvettKc36KCJ3RtgZi7ot
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jun 10, 2022 at 10:00:03AM +0200, Johan Hovold wrote:
> > Fixes: 510e340efe0c ("staging: greybus: audio: Add helper APIs for dynamic audio modules")
> > Cc: stable@vger.kernel.org
> > Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
> > Reviewed-by: Johan Hovold <johan@kernel.org>
> > Signed-off-by: Jared Kangas <kangas.jd@gmail.com>
> > ---
> > 
> > Changes since v1:
> >  * Removed safe list iteration as suggested by Johan Hovold <johan@kernel.org>
> >  * Updated patch changelog to explain the list iteration change
> >  * Added tags to changelog based on feedback (Cc:, Fixes:, Reviewed-by:)
> 
> Apparently Greg applied this to staging-next before we had a change to
> look at it. You should have received a notification from Greg when he
> did so.
> 
> 	https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/commit/?h=staging-next&id=80c968a04a381dc0e690960c60ffd6b6aee7e157
> 
> It seems unlikely that this would cause any issues in real life, but
> there's still a chance it will be picked up by the stable team despite
> the lack of a CC stable tag.

If you want you can always email the stable team to pick up the patch.

regards,
dan carpenter