Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yihao Han <hanyihao@vivo.com>
To:     Felipe Balbi <balbi@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Yihao Han <hanyihao@vivo.com>
Subject: [PATCH] usb: phy: tahvo: Check before clk_disable() not needed
Date:   Fri, 10 Jun 2022 00:45:25 -0700
Message-Id: <20220610074525.69453-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ijK4UKeFlqHjwUbYYebbK5Ad7tQvotdZIOQOLdRrVPaNp1B8e2Y4czfcTXmj?=
 =?us-ascii?Q?FTekHZ1ZFrHjeJdexhcfCeE632zkcrFM1BpiNPVxGHtkg29rlRMFcr2nEwRs?=
 =?us-ascii?Q?chrxCKoOqzylNfBd2Ml0qwefV4BenoK1b3iW9rFcgeKbvICfsaT4gtISO13q?=
 =?us-ascii?Q?//fWvNdixqIXQ/DGADuqDedWQuv6GE6mTh7jIZP/Y0umm4YIQjI06w65rp5J?=
 =?us-ascii?Q?A4KNcujx1VoxqS8CDNXfCPXHqcdh6SUnY63l41t5QkM2bZZZKtSWQ1mhoRhA?=
 =?us-ascii?Q?MIFkkozbtP5ZEKZQZYYO0suDasqrKEjs4mtOmf9g2gpsES6WmvXCK0Twub9C?=
 =?us-ascii?Q?zP1/MpD4Kon3RGjDxeFaLZYSHFJ9PGEptRYbc/6668dvkPFtKbb9ZNK670mx?=
 =?us-ascii?Q?wxNxR01upSnftctyDnkqvaP19cHMbAhAQYsztDCMe/+EMOVNU63IgCgFh7tA?=
 =?us-ascii?Q?IH7B3hjVoW5qHfIMwKRm8wPWZW/osRVv1EcxRKCAB0V77+HoBpDqOCI1KTiC?=
 =?us-ascii?Q?R9hxst4hsB3PqMiuPdlkI7Aa8mrRBYqR8NpGn6P6Siha2Ky2xT2kJ4zLRazc?=
 =?us-ascii?Q?UhX36ykRF56MQCIgeMEXEzUWar4ixN86MdK5MAB7zU7KELZow4v+N8JE9caT?=
 =?us-ascii?Q?U2UaQGquGPPEU4V5QAq8cqSN2Ie0+zXP3O5bvUjw9hwuluUoMn8iNHpOsSlJ?=
 =?us-ascii?Q?YFoffA9PyjIRJkefy0A0jcWyxEvmKywlTS5lVdxbn6f6vmKJnnbe8FLUk7tL?=
 =?us-ascii?Q?Zp/aHucn2kXOcWCbC0wNrmFN7OKJxkifma6yRafPAhuXMqBB5EBsJh6YX9+v?=
 =?us-ascii?Q?4RKlfwhtYRNQADSddGIeh9wOn2zk6hgI7T4WpdCLKENTz2poIJS1Fr6Twihu?=
 =?us-ascii?Q?PaoHegEXVXeF6I5l4fYNiObKmkO3ZgNrdIWh7RuSwYz72jXeimZDLl3dHfZK?=
 =?us-ascii?Q?dWWiSDy1DznsZer2P241y+tlkyfGdKQ7k1f/OVFUo9KUwMjbJQp+hcnzjPoP?=
 =?us-ascii?Q?wPSD8NvDv3H7/BfOsbi3FAetsBJjLyBCkGHqGRhGUSqlHt+jVoTiK/gPN/XE?=
 =?us-ascii?Q?jMPCirmE8mY3GdXNMgISslPWmO4KLQ2WUsSKigQxPvxOpczMNv9d7TqMnqhF?=
 =?us-ascii?Q?7yRzG/RhK5wY3A49qO8tWxxw/zAJVmV7oVsQ2/8Mrwxs7X9mb6mV4Md/8ZI6?=
 =?us-ascii?Q?O4UKQ6ZZo1Oa2mpqETmV2xFVASBQtsn6PTDfU01pWJ7m6AytWQs9BlRghxu/?=
 =?us-ascii?Q?TZkMFHeYP3p100YEeWO9dpe1D5JgrJrWwPmaEqTWZOvnwUf7rVnH9Ugz1c6q?=
 =?us-ascii?Q?BeC6Dwqk5pisI4prwpFbWjZMHMgXGUFZ8BlWYOa6WJA8DqSYlTOXB5km0AEm?=
 =?us-ascii?Q?yWILMWUrzr9LYseFIniXk0rvBFYZlO5wAdIA53qTC/9dmY+L1f0NDPZmXyZG?=
 =?us-ascii?Q?qqU7cYuQzCbGmOJ3pZ6Bce3845DBk1fcmK57biWt6zXfcgAUAyk9XbFgOPBa?=
 =?us-ascii?Q?HIAv6HCjToMj9zcJfvmazD3j5qhJUKA7TtCh2o4e+LkFYSHJdv7NgxAi5aD0?=
 =?us-ascii?Q?l2CvFEpntlh2521EgahQ6VCaJBna3+MvuXlFtBZfsYN39E2YVw/wy8ipQ/us?=
 =?us-ascii?Q?bKOq2pCtYiQJv7INesq3CY4YXocodnchfb5YzSnAu5OKrf9Y9y/5hP78YiKg?=
 =?us-ascii?Q?6pe5EiVEYSkbxsO6jfnKNOMIU1bIfryqjqnOmaOtg1Jd8xbyMWCbFwN96uHU?=
 =?us-ascii?Q?LHQq2omS2A=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b61a0354-903f-4f9b-ad95-08da4ab53981
X-MS-Exchange-CrossTenant-AuthSource: SI2PR06MB4171.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2022 07:45:44.3025
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jeMY68QxouBOGhtNeeKLhUPOE+S1b68lT5IsKdO3zhjmfnO/jS0Q0ULJgfdQdAdOOraFhjX6furqbnGQy9SuCw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS2PR06MB3285
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

clk_disable() already checks the clk ptr using IS_ERR_OR_NULL(clk)
so there is no need to check it again before calling it.

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 drivers/usb/phy/phy-tahvo.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c
index f2d2cc586c5b..9cecc5444515 100644
--- a/drivers/usb/phy/phy-tahvo.c
+++ b/drivers/usb/phy/phy-tahvo.c
@@ -406,8 +406,7 @@ static int tahvo_usb_probe(struct platform_device *pdev)
 err_remove_phy:
 	usb_remove_phy(&tu->phy);
 err_disable_clk:
-	if (!IS_ERR(tu->ick))
-		clk_disable(tu->ick);
+	clk_disable(tu->ick);
 
 	return ret;
 }
@@ -418,8 +417,7 @@ static int tahvo_usb_remove(struct platform_device *pdev)
 
 	free_irq(tu->irq, tu);
 	usb_remove_phy(&tu->phy);
-	if (!IS_ERR(tu->ick))
-		clk_disable(tu->ick);
+	clk_disable(tu->ick);
 
 	return 0;
 }
-- 
2.17.1