Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Chanho Park" <chanho61.park@samsung.com>
To:     "'Alim Akhtar'" <alim.akhtar@samsung.com>,
        <linux-kernel@vger.kernel.org>, <linux-phy@lists.infradead.org>
Cc:     <krzysztof.kozlowski+dt@linaro.org>, <vkoul@kernel.org>,
        <pankaj.dubey@samsung.com>
In-Reply-To: <20220610070547.71193-1-alim.akhtar@samsung.com>
Subject: RE: [PATCH -next] phy: samsung-ufs: fix NULL pointer dereference
Date:   Fri, 10 Jun 2022 17:15:21 +0900
Message-ID: <000001d87ca2$3ac0f520$b042df60$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQJNUr2mveM3EJGNpu0kIdNV5dOukgIPmyx5rE4hWXA=
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <CGME20220610070811epcas5p3c62ef9ad9c82092deac59ff9be896677@epcas5p3.samsung.com>
        <20220610070547.71193-1-alim.akhtar@samsung.com>
Precedence: bulk

> Subject: =5BPATCH -next=5D phy: samsung-ufs: fix NULL pointer dereference
>=20
> commit f86c1d0a58b1f63a (=22phy: samsung: ufs: remove drvdata from struct
> samsung_ufs_phy=22)
>=20
> removes _drvdata_ initialization which resulting in NULL pointer
> dereferencing in samsung_ufs_phy_wait_for_lock_acq(). Fix this by
> initializing drvdata.
>=20
> The said commit also duplicate =22has_symbol_clk=22 both in drvdata struc=
t and
> in samsung_ufs_phy struct, let's go back and use only one =22has_symbol_c=
lk=22.
>=20
> Fixes: f86c1d0a58b1 phy: samsung: ufs: remove drvdata from struct
> samsung_ufs_phy

This might be conflicted when you apply your patch.
https://lore.kernel.org/linux-phy/20220610072924.12362-3-alim.akhtar=40sams=
ung.com/T/=23u

When I created my patch, it was not existing so my previous patch make sens=
e.
If you get back drvdata for your patch, please drop this =22fixes tag + pat=
ch=22 and put this in your patchset.

Best Regards,
Chanho Park