Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 10 Jun 2022 08:40:33 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     "Michael Kelley (LINUX)" <mikelley@microsoft.com>
Cc:     Saurabh Sengar <ssengar@linux.microsoft.com>,
        KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        "wei.liu@kernel.org" <wei.liu@kernel.org>,
        Dexuan Cui <decui@microsoft.com>,
        "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Saurabh Singh Sengar <ssengar@microsoft.com>
Subject: Re: [PATCH] Drivers: hv: vmbus: Release cpu lock in error case
Message-ID: <20220610084033.r6llz4dadlw6gyoz@liuwe-devbox-debian-v2>
References: <1654794996-13244-1-git-send-email-ssengar@linux.microsoft.com>
 <PH0PR21MB30259484AB91D8EA2DEBD3E7D7A79@PH0PR21MB3025.namprd21.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <PH0PR21MB30259484AB91D8EA2DEBD3E7D7A79@PH0PR21MB3025.namprd21.prod.outlook.com>
Precedence: bulk

On Thu, Jun 09, 2022 at 05:39:06PM +0000, Michael Kelley (LINUX) wrote:
> From: Saurabh Sengar <ssengar@linux.microsoft.com> Sent: Thursday, June 9, 2022 10:17 AM
> > 
> > In case of invalid sub channel, release cpu lock before returning.
> > 
> > Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
> > ---
> >  drivers/hv/channel_mgmt.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
> > index 280b529..5b12040 100644
> > --- a/drivers/hv/channel_mgmt.c
> > +++ b/drivers/hv/channel_mgmt.c
> > @@ -639,6 +639,7 @@ static void vmbus_process_offer(struct vmbus_channel
> > *newchannel)
> >  		 */
> >  		if (newchannel->offermsg.offer.sub_channel_index == 0) {
> >  			mutex_unlock(&vmbus_connection.channel_mutex);
> > +			cpus_read_unlock();
> >  			/*
> >  			 * Don't call free_channel(), because newchannel->kobj
> >  			 * is not initialized yet.
> > --
> > 1.8.3.1
> 
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>
> 

The bug comes from a949e86c0d780.

Added a Fixes tag and applied to hyperv-fixes. Thanks.