Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Serge Semin <Sergey.Semin@baikalelectronics.ru>
To:     Arnd Bergmann <arnd@arndb.de>,
        Philipp Zabel <p.zabel@pengutronix.de>
CC:     Serge Semin <Sergey.Semin@baikalelectronics.ru>,
        Serge Semin <fancer.lancer@gmail.com>,
        Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
        Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
        <soc@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/2] bus: bt1-axi: Don't print error on -EPROBE_DEFER
Date:   Fri, 10 Jun 2022 11:01:03 +0300
Message-ID: <20220610080103.10689-2-Sergey.Semin@baikalelectronics.ru>
In-Reply-To: <20220610080103.10689-1-Sergey.Semin@baikalelectronics.ru>
References: <20220610080103.10689-1-Sergey.Semin@baikalelectronics.ru>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk

The Baikal-T1 AXI bus driver correctly handles the deferred probe
situation, but still pollutes the system log with a misleading error
message. Let's fix that by using the dev_err_probe() method to print the
log message in case of the clocks/resets request errors.

Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru>
---
 drivers/bus/bt1-axi.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/bus/bt1-axi.c b/drivers/bus/bt1-axi.c
index e7a6744acc7b..47bcf18f3115 100644
--- a/drivers/bus/bt1-axi.c
+++ b/drivers/bus/bt1-axi.c
@@ -136,7 +136,8 @@ static int bt1_axi_request_rst(struct bt1_axi *axi)
 
 	axi->arst = devm_reset_control_get_optional_exclusive(axi->dev, "arst");
 	if (IS_ERR(axi->arst)) {
-		dev_warn(axi->dev, "Couldn't get reset control line\n");
+		dev_err_probe(axi->dev, PTR_ERR(axi->arst),
+			      "Couldn't get reset control line\n");
 		return PTR_ERR(axi->arst);
 	}
 
@@ -160,7 +161,8 @@ static int bt1_axi_request_clk(struct bt1_axi *axi)
 
 	axi->aclk = devm_clk_get(axi->dev, "aclk");
 	if (IS_ERR(axi->aclk)) {
-		dev_err(axi->dev, "Couldn't get AXI Interconnect clock\n");
+		dev_err_probe(axi->dev, PTR_ERR(axi->aclk),
+			      "Couldn't get AXI Interconnect clock\n");
 		return PTR_ERR(axi->aclk);
 	}
 
-- 
2.35.1