Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Alim Akhtar" <alim.akhtar@samsung.com>
To:     "'Chanho Park'" <chanho61.park@samsung.com>,
        <linux-kernel@vger.kernel.org>, <linux-phy@lists.infradead.org>
Cc:     <krzysztof.kozlowski+dt@linaro.org>, <vkoul@kernel.org>,
        <pankaj.dubey@samsung.com>
In-Reply-To: <000001d87ca2$3ac0f520$b042df60$@samsung.com>
Subject: RE: [PATCH -next] phy: samsung-ufs: fix NULL pointer dereference
Date:   Fri, 10 Jun 2022 14:46:44 +0530
Message-ID: <000601d87caa$cede0150$6c9a03f0$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQJNUr2mveM3EJGNpu0kIdNV5dOukgIPmyx5AVPcAqqsQ5QiIA==
Content-Language: en-us
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
DLP-Filter: Pass
References: <CGME20220610070811epcas5p3c62ef9ad9c82092deac59ff9be896677@epcas5p3.samsung.com>
        <20220610070547.71193-1-alim.akhtar@samsung.com>
        <000001d87ca2$3ac0f520$b042df60$@samsung.com>
Precedence: bulk


>-----Original Message-----
>From: Chanho Park =5Bmailto:chanho61.park=40samsung.com=5D
>Sent: Friday, June 10, 2022 1:45 PM
>To: 'Alim Akhtar' <alim.akhtar=40samsung.com>; linux-kernel=40vger.kernel.=
org;
>linux-phy=40lists.infradead.org
>Cc: krzysztof.kozlowski+dt=40linaro.org; vkoul=40kernel.org;
>pankaj.dubey=40samsung.com
>Subject: RE: =5BPATCH -next=5D phy: samsung-ufs: fix NULL pointer derefere=
nce
>
>> Subject: =5BPATCH -next=5D phy: samsung-ufs: fix NULL pointer dereferenc=
e
>>
>> commit f86c1d0a58b1f63a (=22phy: samsung: ufs: remove drvdata from
>> struct
>> samsung_ufs_phy=22)
>>
>> removes _drvdata_ initialization which resulting in NULL pointer
>> dereferencing in samsung_ufs_phy_wait_for_lock_acq(). Fix this by
>> initializing drvdata.
>>
>> The said commit also duplicate =22has_symbol_clk=22 both in drvdata stru=
ct
>> and in samsung_ufs_phy struct, let's go back and use only one
>=22has_symbol_clk=22.
>>
>> Fixes: f86c1d0a58b1 phy: samsung: ufs: remove drvdata from struct
>> samsung_ufs_phy
>
>This might be conflicted when you apply your patch.
>https://lore.kernel.org/linux-phy/20220610072924.12362-3-
>alim.akhtar=40samsung.com/T/=23u
>
>When I created my patch, it was not existing so my previous patch make
>sense.
>If you get back drvdata for your patch, please drop this =22fixes tag + pa=
tch=22 and
>put this in your patchset.
>
Thanks Chanho
Because of the merged conflict this got messed up. Will correct it.

>Best Regards,
>Chanho Park