Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <bc5f1d0f-ffa3-6341-58c1-8a781d9071ac@amd.com>
Date:   Fri, 10 Jun 2022 14:39:05 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH] selftests/vm: Add protection_keys tests to run_vmtests
Content-Language: en-US
To:     Shuah Khan <skhan@linuxfoundation.org>, akpm@linux-foundation.org,
        shuah@kernel.org, linux-mm@kvack.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220531102556.388-1-kalpana.shetty@amd.com>
 <4b0aab3f-83f4-80f7-6df0-447561f0da88@linuxfoundation.org>
From:   "Shetty, Kalpana" <kalpana.shetty@amd.com>
In-Reply-To: <4b0aab3f-83f4-80f7-6df0-447561f0da88@linuxfoundation.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WUpzR0ZHek9IcG5lemlpMklZWS9uOXVUT29hTGwyY1Bha0xiWU5nSFNjYm5R?=
 =?utf-8?B?TFF1RitBOVREa1Q5WlpNU1pPNStXSDBCaWIyeU9uNmdVNVNsSExJaVhoUHhR?=
 =?utf-8?B?eFV6aWJKekw5VnRicXphUmlqaytXazg2Mk1iWTV0WEN1RWc1L1lHVnNPV0FH?=
 =?utf-8?B?RkJOYU92TUhmRU1lb09meE1ud2dqTVFpd3V2YjFIcno3RWlzd3ZMZmZFOVhU?=
 =?utf-8?B?WmZhVXZkYnNTMnI3M0NuZkQ5MlZZOE8waVg0bEh1ZWJpK29xVDZOZ0VGNjJE?=
 =?utf-8?B?VWRqV2dlSWxaS0RCMXUvSVQvblpjNlBVWXR5QktCQzRTNGx4KzYwUWpKWmVC?=
 =?utf-8?B?b3loSzRqVVBMTkttTDh5UGRQVVFsRFAvYnZGb0JrSTA5aHBsMmYzVFBVdk9L?=
 =?utf-8?B?anFzNGIxZm5LOURlQ2hkTnZ1aWxZTmNNMXdDZUp6YWtLTVlBa3VoVlpTYUpa?=
 =?utf-8?B?UzhpT1hsSmc4UFYwQ1ZIcHZRZ0daNllaM08wTDR0dXVqa1B6cmVpSWoyQWdD?=
 =?utf-8?B?cmdvTmZUR0RtN1BGZ1hVam14N21ibzcvemphZk5ndTg5eDMzLzJTcVVvRVJF?=
 =?utf-8?B?ckNKem9LQTl1M0QzK1orUTNFdE9BalRTU1pqY3J0VWNDTTUxaU5OQUVYa1BO?=
 =?utf-8?B?d2JJbDhIejlPU2dxUzNEM3p6UVgwcHNZUlhaVThmN3NpSURzdEVydE12K29K?=
 =?utf-8?B?d1JqN21nWG5TMkJzem5OQ21JQllZR2pTU3ZRZW5YeDBiZlV2Sy83Q0pGZVZr?=
 =?utf-8?B?empLTyszT25oVy9QZXpxK2MvajdQYU4vL2k4MmpsN2l1ZUMyL3F2c0hNdER3?=
 =?utf-8?B?bXY4RXVqVy9lcStrUWVEeFVNODh5d21CMXl3am41bXpmWXlRV2dLdzZCOGtO?=
 =?utf-8?B?YXI2b0NlMExvRVFuTzdkbUR2K2h0SGVqdUk4NEk1STBzMHFhb1NGRmoxNVNw?=
 =?utf-8?B?VE1ZcEdXY0taZFBOdFpYQ0YrdmtoVGllM3RHYlB1OGgzc204akdhQ0l1YXhz?=
 =?utf-8?B?akx1VHhvMERQbjJ0d3l5SVQvMGNNdWYvUUI0dzlEMjVOTHV0NHVneUVWakhm?=
 =?utf-8?B?aWtJR3dyNHdrU0wrdUlneVF6NzZ6TzdtTld2VjdGUitibUloR0lLRmp3bVNU?=
 =?utf-8?B?a2NlMHYxSXBQcjdZRkdxMGxJRjRldHJrRXJ0SEtRMVd0VEVzUzJHZVBKcy9j?=
 =?utf-8?B?ekc0SXI3NXM0RGZNdnpDc1JGUFRWZjVYVHd5Y3FxbVQybEJuSXNnVm9sQ01R?=
 =?utf-8?B?TmVYajBTcEtEZXVwbVFpVVhDdkgrMUVXWkFPOVQ3SG5SSXZDMFo5R3RGMjdX?=
 =?utf-8?B?bFl6dC9vU0F5R1pKd01nbFFTZjF5eURLODNNZnJQd2s2eWNSZEFQNW9tUGtD?=
 =?utf-8?B?K01VQlZkWWZaMTdlZEhtTWFFS3F3eVk4K2tWRkwvS24wWEJ1N0NCcVlTWHl1?=
 =?utf-8?B?RDFmQmNCWk5zWk9nSWt2bGEzanp4eTR6OXJlRkFJWVhTKzA4N2ZXZGVNOWNz?=
 =?utf-8?B?V1hxMDFYaUI2OURBLzhyZk15MUw4MjZhcHBnUmdiWk0rVmlTOTRSaE5UYnpQ?=
 =?utf-8?B?cGVrelNUc2JWLzZYeUhlU3o5L0x1VW9ta1JEaW5QcFZ6UVpOTzZBdjZUZGpW?=
 =?utf-8?B?NWlHT2VmdXNsdU1kWjlyOFZFbUxvSFRDK2d5dmpacm5kOUQ1cW5uWWppNFhs?=
 =?utf-8?B?aWoyZ3d2MFRjYmNzeHRKYlAyWFlnVmlYOFdFLy9TUWRRRXVBeVNndFBCN3Fi?=
 =?utf-8?B?SHM4S2lzVTllYU5ONU4rcGVjaVVkL2ZRUUVLbzUxZ2hwRnJya1dSdWxBRmtN?=
 =?utf-8?B?WmlqVWtXZ0VzVkpDNFpPeGZkMXNVS2dVZzVsekNsQllNQ0I2TWpKdnBEOWtK?=
 =?utf-8?B?SkZ4Y0tDd2o4SWZUSU1qQjJSQ3BGd2JSNTZzRGMwV3ZaOWlHazQwd1JuVWJZ?=
 =?utf-8?B?Y2MzNXpCbkk5ZE14YUN1bUk4T1hycDNhL2dpd1JmODJoUWJPcE05dVNtVDl3?=
 =?utf-8?B?aWw5N09LaHlJZEJNWmJSdWtBSTlBbTlMY2QvK3NNY1AxMXBXZnRiM0hnTlV2?=
 =?utf-8?B?S3dwZ295cWNIc0FVaUt4NktyZno0cTB0RzFzSWsxYUVJNDUvT3l4aFZiL0pk?=
 =?utf-8?B?eWpoMDhhdVRQY2Q2OXlucTQ1cUx0VFREMGhXQVEzS0JnWHAvaFhOc1MyQjFQ?=
 =?utf-8?B?cW8xQVRST3NUc2RvQWEySFQxK2JaSldMaHdXaVM1OXVvY21yZGdYOW1YODNz?=
 =?utf-8?B?YkNSYmtqTHltcDRHOEFyNmZrTVpkRVhKWDRoOTlpU2ZWQXZZTGQzYmdFTXQx?=
 =?utf-8?B?RktYdFJ4M0JSS3ZrOWlnM1VTZ2hQMzg1b29ZLy81ZmhyWTB6NVhYQT09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 498e6e42-d47f-4ac3-8f0f-08da4ac0e3e5
X-MS-Exchange-CrossTenant-AuthSource: BL3PR12MB6449.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jun 2022 09:09:14.6963
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: v/cdka+TwXkrvvCApq1aPTITNfnqkIKllmDsIkYqfr+Kshyl+niMcH/XBqcGIBwi0EzQKfQOAMZIeg55NiS0Tg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1903
X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE,
        URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/10/2022 1:51 AM, Shuah Khan wrote:
> On 5/31/22 4:25 AM, Kalpana Shetty wrote:
>> Signed-off-by: Kalpana Shetty <kalpana.shetty@amd.com>
>
> Missing commit log - please add a detailed commit log explaining why
> this change is necessary.

Sent V2 patch with patch description.

Thanks,

Kalpana

>
>> ---
>>   tools/testing/selftests/vm/run_vmtests.sh | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/tools/testing/selftests/vm/run_vmtests.sh 
>> b/tools/testing/selftests/vm/run_vmtests.sh
>> index 41fce8bea929..54a0c28f810c 100755
>> --- a/tools/testing/selftests/vm/run_vmtests.sh
>> +++ b/tools/testing/selftests/vm/run_vmtests.sh
>> @@ -179,4 +179,11 @@ run_test ./ksm_tests -N -m 1
>>   # KSM test with 2 NUMA nodes and merge_across_nodes = 0
>>   run_test ./ksm_tests -N -m 0
>>   +# protection_keys tests
>> +if [ $VADDR64 -eq 0 ]; then
>> +    run_test ./protection_keys_32
>> +else
>> +    run_test ./protection_keys_64
>> +fi
>> +
>>   exit $exitcode
>>
>
> thanks,
> -- Shuah