Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 10 Jun 2022 11:01:04 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Yihao Han <hanyihao@vivo.com>
Cc:     Felipe Balbi <balbi@kernel.org>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: phy: tahvo: Check before clk_disable() not needed
Message-ID: <YqMIUOTU/k5XpW3I@kroah.com>
References: <20220610074525.69453-1-hanyihao@vivo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220610074525.69453-1-hanyihao@vivo.com>
Precedence: bulk

On Fri, Jun 10, 2022 at 12:45:25AM -0700, Yihao Han wrote:
> clk_disable() already checks the clk ptr using IS_ERR_OR_NULL(clk)

It does?  Are you sure?  It will check for NULL, that's it.

> so there is no need to check it again before calling it.

This will break on some platforms, please always test your patches
before sending them out.

thanks,

greg k-h