Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 10 Jun 2022 13:13:19 +0200
Message-ID: <87h74sn54g.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Takashi Iwai <tiwai@suse.de>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org
Subject: Re: [PATCH] media: uvcvideo: Fix spurious DMA max segment size warnings
In-Reply-To: <YqMHhPXPGkTcXICd@kroah.com>
References: <20220609082246.13182-1-tiwai@suse.de>
        <YqG65hU4SLUrxMI7@pendragon.ideasonboard.com>
        <YqMHhPXPGkTcXICd@kroah.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 10 Jun 2022 10:57:40 +0200,
Greg Kroah-Hartman wrote:
> 
> On Thu, Jun 09, 2022 at 12:18:30PM +0300, Laurent Pinchart wrote:
> > Hi Takashi,
> > 
> > (CC'ing Greg and the linux-usb mailing list)
> > 
> > Thank you for the patch.
> > 
> > On Thu, Jun 09, 2022 at 10:22:46AM +0200, Takashi Iwai wrote:
> > > As default, the DMA max segment size is set to 64k, and uvcvideo may
> > > overflow that size easily, resulting in a warning like:
> > > 
> > >   DMA-API: xhci_hcd 0000:00:14.0: mapping sg segment longer than device claims to support [len=98304] [max=65536]
> > > 
> > > Explicitly set up the DMA max segment size for avoiding spurious kernel
> > > warnings.
> > > 
> > > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > > ---
> > >  drivers/media/usb/uvc/uvc_video.c | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c
> > > index 1b4cc934109e..25aa6e6a6906 100644
> > > --- a/drivers/media/usb/uvc/uvc_video.c
> > > +++ b/drivers/media/usb/uvc/uvc_video.c
> > > @@ -2160,6 +2160,8 @@ int uvc_video_init(struct uvc_streaming *stream)
> > >  	for_each_uvc_urb(uvc_urb, stream)
> > >  		INIT_WORK(&uvc_urb->work, uvc_video_copy_data_work);
> > >  
> > > +	dma_set_max_seg_size(uvc_stream_to_dmadev(stream), UINT_MAX);
> > > +
> > 
> > uvc_stream_to_dmadev() returns the pointer to the HCD's struct device,
> > which is shared between all drivers on the bus. Is it really fine for a
> > USB device driver to change the maximum segment size of the HCD device
> > directly ?
> 
> Ick, no!  That feels wrong, it should only change things for that one
> specific device, not all devices on that bus.

Hrm, indeed, that points to the HCD.  This made me wonder, though,
whether the current usage of dma_*sgtable() with that device is OK or
not.  The warning came from that code path, after all...


Takashi